From: Ryan Roberts <ryan.roberts@arm.com>
To: Lance Yang <ioworker0@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com, 21cnbao@gmail.com,
mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com,
shy828301@gmail.com, xiehuan09@gmail.com,
wangkefeng.wang@huawei.com, songmuchun@bytedance.com,
peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] mm/arm64: override mkold_clean_ptes() batch helper
Date: Fri, 12 Apr 2024 12:21:22 +0100 [thread overview]
Message-ID: <84eca849-5da3-4272-ade6-dc0f2b3dc4b2@arm.com> (raw)
In-Reply-To: <CAK1f24m=nC=ecuOZesQvytnxJms2d-wONKT4_7GUfvz0PJz+oQ@mail.gmail.com>
On 12/04/2024 03:09, Lance Yang wrote:
> On Thu, Apr 11, 2024 at 9:17 PM Ryan Roberts <ryan.roberts@arm.com> wrote:
>>
>> On 08/04/2024 05:24, Lance Yang wrote:
>>> The per-pte get_and_clear/modify/set approach would result in
>>> unfolding/refolding for contpte mappings on arm64. So we need
>>> to override mkold_clean_ptes() for arm64 to avoid it.
>>
>> IIRC, in the last version, I suggested copying the wrprotect_ptes() pattern to
>> correctly iterate over contpte blocks. I meant for you to take it as inspiration
>> but looks like you have done a carbon copy, including lots of things that are
>> unneeded here. That's my fault for not being clear - sorry!
>
> My bad. I must have misunderstood your intention.
Not at all - it was my bad. wrprotect_ptes() is nothing like what I eventually
suggested below, so sorry for the bad steer.
next prev parent reply other threads:[~2024-04-12 11:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 4:24 [PATCH v5 0/2] mm/madvise: enhance lazyfreeing with mTHP in madvise_free Lance Yang
2024-04-08 4:24 ` [PATCH v5 1/2] mm/madvise: optimize " Lance Yang
2024-04-11 11:11 ` Ryan Roberts
2024-04-11 11:20 ` David Hildenbrand
2024-04-11 11:27 ` Ryan Roberts
2024-04-11 12:23 ` Lance Yang
2024-04-11 13:51 ` Ryan Roberts
2024-04-11 13:55 ` David Hildenbrand
2024-04-11 12:46 ` Lance Yang
2024-04-11 13:48 ` Ryan Roberts
2024-04-11 14:07 ` Lance Yang
2024-04-11 14:39 ` Ryan Roberts
2024-04-11 14:42 ` David Hildenbrand
2024-04-12 1:48 ` Lance Yang
2024-04-08 4:24 ` [PATCH v5 2/2] mm/arm64: override mkold_clean_ptes() batch helper Lance Yang
2024-04-11 13:17 ` Ryan Roberts
2024-04-12 2:09 ` Lance Yang
2024-04-12 11:21 ` Ryan Roberts [this message]
2024-04-10 21:50 ` [PATCH v5 0/2] mm/madvise: enhance lazyfreeing with mTHP in madvise_free Andrew Morton
2024-04-11 5:01 ` Lance Yang
2024-04-11 10:29 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84eca849-5da3-4272-ade6-dc0f2b3dc4b2@arm.com \
--to=ryan.roberts@arm.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=peterx@redhat.com \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xiehuan09@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox