From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2C7CE7A81 for ; Mon, 25 Sep 2023 15:27:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30BFA8D002D; Mon, 25 Sep 2023 11:27:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BBF98D0001; Mon, 25 Sep 2023 11:27:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 183348D002D; Mon, 25 Sep 2023 11:27:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 080808D0001 for ; Mon, 25 Sep 2023 11:27:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C4B36140726 for ; Mon, 25 Sep 2023 15:27:20 +0000 (UTC) X-FDA: 81275498640.10.1D389C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id D7BF51C0017 for ; Mon, 25 Sep 2023 15:27:17 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DPq2+bow; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of sebott@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=sebott@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695655638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7H2XAzpH3NNwBCL8tlfLO4lmIswP7Ba+4agi7nq1T3A=; b=3Ba3O4JbhW2XefL1rZb1czLv0INby9aFXtxpwUxQppsQW3k7bv6tA5E7t4Tyx+46+1y5r9 mltzVkzuZ9s67k1pgEiUmjlgIcTDpH2926khMqeOa6/SiMowv70Wk0XysAMeRZcziO3DgS On/fB/1pjifehBANQhv0R9Rp7Cw6E7Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DPq2+bow; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of sebott@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=sebott@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695655638; a=rsa-sha256; cv=none; b=xkEv5e4edd2rdU/GY8HPyIrxrGiWnawUJwRV2Uh6LrJqv9up/9yrLvVMjzQoNV7oul9WWd pcOnsVQ/0SoFXqKe1uMeohiSFxnhLeA8/z5kaQcuAzJCNUISsS9bU2OFJT63AXjwS6mUaN h/FsdZqj5A0CQkvw5H8Aze6L+CCkFBs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695655637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7H2XAzpH3NNwBCL8tlfLO4lmIswP7Ba+4agi7nq1T3A=; b=DPq2+bowKkgS1ES/lDWZ6yN0Sfv2ELW6CWF8DR/gGLkL1NvIqXUox6cVHpVMZIRMxcxg/D XW2ca5zItw6bkeyvN7dJ4NFcisL46Ku2FmAV5VnFByRioyvhm5JIr84DIJoORtWZ+HAhLf VD5KGX07QXB7/nu8x7iyYY9PYyXWgm4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-pFU9FbvMPLySA0C0F8DU4g-1; Mon, 25 Sep 2023 11:27:15 -0400 X-MC-Unique: pFU9FbvMPLySA0C0F8DU4g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f41a04a297so59069915e9.3 for ; Mon, 25 Sep 2023 08:27:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695655634; x=1696260434; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wckYes9tuj8TsYij0Z4ld4U0TeFfOFKN2Inn7boKvjk=; b=derdGG+53ymVUrtPZqMoinYkOrGTyj/Qn8vJiVokj3tRUOz/znqxonk8U84jbyWEco 0K4KkqOfL8uzBSDWZp8zFJdBI16Htgfnl62AoU/R7QODYbeFf0+sW9FQyRO3JjLeuI7Q c80w42FYkcNQw3TInFbAousGcsO6amL5WIQIcNxP9KlqTNeWO5G6ML0cQ4uYMrfBXWz9 VyB9N0j+onx2dJwOAIS5nRy/aYoujQLTB6cYM22QjvEhSeEvfCw+DbAGPNTFV4GLeIUd Rt6C1luzRJaGuKlgOw2szNG+mc6pmRsM4QUgxqGu4T1q+oFxfaSNlbgjduXtI8jK8FfT D4tQ== X-Gm-Message-State: AOJu0Yz0iRWuO0w5ji5G8VGPtP90TavLjy7NZsZLzrYv3gx96yHCcqyr yfsxb511fYeqJFtVCOm376pmwhxZSF5jnspA3jjDgFMKcHMezcwhyt8uBpo0Yd51g8iYgg9sjOm 6DKKs8Es6AwA= X-Received: by 2002:a7b:cbd1:0:b0:405:36e3:e863 with SMTP id n17-20020a7bcbd1000000b0040536e3e863mr6718232wmi.8.1695655634469; Mon, 25 Sep 2023 08:27:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnUGDIoj3/uAJn5Af95qg7TvdfuoTHpeIxNzT9laP9ft2YNgz4K0T93YKo0VDl+RqviGHKHA== X-Received: by 2002:a7b:cbd1:0:b0:405:36e3:e863 with SMTP id n17-20020a7bcbd1000000b0040536e3e863mr6718216wmi.8.1695655634131; Mon, 25 Sep 2023 08:27:14 -0700 (PDT) Received: from rh (p200300c93f1ec600a890fb4d684902d4.dip0.t-ipconnect.de. [2003:c9:3f1e:c600:a890:fb4d:6849:2d4]) by smtp.gmail.com with ESMTPSA id v21-20020a7bcb55000000b00404719b05b5sm12555738wmj.27.2023.09.25.08.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 08:27:13 -0700 (PDT) Date: Mon, 25 Sep 2023 17:27:12 +0200 (CEST) From: Sebastian Ott To: "Eric W. Biederman" cc: =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= , Alexander Viro , Christian Brauner , Kees Cook , Mark Brown , Willy Tarreau , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] binfmt_elf: Support segments with 0 filesz and misaligned starts In-Reply-To: <87jzsemmsd.fsf_-_@email.froward.int.ebiederm.org> Message-ID: <84e974d3-ae0d-9eb5-49b2-3348b7dcd336@redhat.com> References: <20230914-bss-alloc-v1-1-78de67d2c6dd@weissschuh.net> <36e93c8e-4384-b269-be78-479ccc7817b1@redhat.com> <87zg1bm5xo.fsf@email.froward.int.ebiederm.org> <37d3392c-cf33-20a6-b5c9-8b3fb8142658@redhat.com> <87jzsemmsd.fsf_-_@email.froward.int.ebiederm.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="-1463795790-784343621-1695655633=:4500" X-Rspamd-Queue-Id: D7BF51C0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fprw9biqum6x3cix3z8pqu91rt8muadj X-HE-Tag: 1695655637-545786 X-HE-Meta: U2FsdGVkX18M68H1y0cCLKYNCml3ydfABVo+6maBFL73LRYAzXWVRaTwu6efViAwNmZCs4dHn/A4MRyWZjj+sCDBDXSQqQXG2yL/nCm0js3c45P4vs8ESC30afpxOSHMWfG/inwfQyR13j+2Dwkp6J7i10LY42YZlku4f1vFwp2UtLArBomWZ9SelWrVlCL1xIlJnTj1Nv6A7D4ojtb2GkCJxnVUfiEDFfU8K1Z6GsuQLRd8GmJUncuzvm6Lu741G5Fou0I8dFhGVh/QBBCQZMTtO+bYzrcwax1v+Vg8itjjlk0tq5zMQR4lEdlzLVDLjXlq3oufjf9SYQ3XdWKZ69wn4CbgEg1vSxAGUW4ZsRZ6GzMtEeCc/CzgMCPpOXZ5bkYdiFSMslcfR1jv6jFLriiqu+7lVje1H5CSAiNSnLxg5fG8AKY94suICM2lwgsnsZneBvmCNqmvY1P4gAzwokA0xzbiFTGJYfgcJONvby1L0WP/QT4dXzYyqqCjqSb9V+jiMXRtQd/3joWGoz13Y7Nk3yrbb+iCD12kMRl9Vzc6Veg6G9xD5/K8I4Pz6AE9R3cNoiEsnReH3gqGjpp3ArOCcrdrR3JHBBkaLDfLNMOjGBiOpVuhRko7CxxcasjB7vnbx9By0wmA1mjjXU3tX7RvcFrApCFjF5BK0eP3ftSeyTVF3/myB4vQ2buTCxLeN4aAVJvnY0LloRSKiKxi8ne1vFKT6p0aZSqKotXq2OepoMKUi+9ysUxIYwd+6i1PqPKyQRrfHq4XUtQlTixMp8w9dGI9z9QUXQvjo7lbvcq8zlZFw9dhgtNKP16RFnq3u8kkB6kpN9TY9N9qm13uOa/rqmUW4KNmDjyzsxNs2a8vHoQhi8cQiaOu2+bKQzwrl4TcFM4iCsZIJGrJtsOsWWaWXVKTHakBrhz7yfdtQe5RtbhZcu6Ig5FCzgKw3dK6nB1V3Eo2Xypac+PoeWC L1kWERYl Q/jgmAl7r68colK5wsb4yy8cZ2ISfsT5zuTdHzSWkFRP8sTTSzpWe0uu4Okyx41OfiVenBCVccN8pRhSv74VDwNJbJv62+5WDkuY7nmU62TGvODQuH/eMub1AS+Hz/1qfiLRff0dSimY9nVOmsu0WVQTwZfT5Kb8vLNJJ1nqQboZztqdQ+KXou9SHuA2VcjdPczZ366gVdLbsDJyaJhb2F0bhkDVO3SOaQUxB/oZbOKpYYV3NfsKUFXrXo7RlHyf/vCITrJthKls0Jv51zlezjh1aOmLrgVMNyn/ZzUHL0SiDv++YSGLwUY9xys4L8ngNMbbby54lihnq6j66b8jwS7Vox84azq0Ike28bkvE5dBcWuQN+/m61y18I2dV0wX36UkEHeRXHYlvrK0iYQ8NZ//ZWmKEt5LZPPSGL5XUfSuE6Q8Za6SS5YT8VXCypJE4L0wNXXMEmD00DOkP7i/gCiv0UbJZoS2Gq+eCJmWbStM8MJayXdfy1yrjg/x/23WrnO+ZI7ZNHsaeFwDsWd9702FTOflgo1JqIjqbqxr46twM/A1Xvi0i/49HBM7j8i6papR5EWPjY7pI8nECp5htMW9mMX+nh0UF9m48e7u9jClYRWP8GxTNp//dLpXBhbMTk6zPRVtkdv8G1r5B5xYSTq3nWE/geXhof7gQN6t/MKs1NAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463795790-784343621-1695655633=:4500 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 25 Sep 2023, Eric W. Biederman wrote: > > Implement a helper elf_load that wraps elf_map and performs all > of the necessary work to ensure that when "memsz > filesz" > the bytes described by "memsz > filesz" are zeroed. > > Link: https://lkml.kernel.org/r/20230914-bss-alloc-v1-1-78de67d2c6dd@weissschuh.net > Reported-by: Sebastian Ott > Reported-by: Thomas Weißschuh > Signed-off-by: "Eric W. Biederman" > --- > fs/binfmt_elf.c | 111 +++++++++++++++++++++--------------------------- > 1 file changed, 48 insertions(+), 63 deletions(-) > > Can you please test this one? > That one did the trick! The arm box booted successful, ran the binaries that were used for the repo of this issue, and ran the nolibc compiled binaries from kselftests that initially triggered the loader issues. Thanks, Sebastian ---1463795790-784343621-1695655633=:4500--