From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B343DC4707C for ; Sat, 13 Jan 2024 05:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CB176B0096; Sat, 13 Jan 2024 00:57:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 254566B0099; Sat, 13 Jan 2024 00:57:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11EA56B009A; Sat, 13 Jan 2024 00:57:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F151B6B0096 for ; Sat, 13 Jan 2024 00:57:33 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 779AE12075E for ; Sat, 13 Jan 2024 05:57:33 +0000 (UTC) X-FDA: 81673230786.15.1A83E40 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 5AACEA0006 for ; Sat, 13 Jan 2024 05:57:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="h5M/1VGt"; dmarc=none; spf=none (imf15.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705125450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yS6I6mddaN1yhy8N4LUTGdLFHpiWXV0zrUgAi9pBpv4=; b=ZQB7n5e0ixhNf1CGXNtYGE5w3/E/VlLPHXGCfGGO096wSIMS2RSF3QAziB4eS5wa3LXI0V 9WdzgPwnucwPGGgc2glmObV1AuTuKqXFQ0TwgwRndThvWbYUgguau0SQH2NxEDt6XQvTxg AW2e4cyno1N9LycprnQntAq8nEu75OI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="h5M/1VGt"; dmarc=none; spf=none (imf15.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705125450; a=rsa-sha256; cv=none; b=rqGYA95nNtTewjRoG9m3xgnMlS6T1UGmsW3IZ3mBo+s0UYM7clGdGtg8eoTiUKPUOS7M/9 xIgGHj7cMs51aZrLBLBSuguIhpYXXqgtBYpAfgs8qgNHVIMsc5H0ToUJLtAIglCxdtesNH qdzETS1aqz9Gktw1GxFB9X/RWZTV77U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=yS6I6mddaN1yhy8N4LUTGdLFHpiWXV0zrUgAi9pBpv4=; b=h5M/1VGtX+ODHUeJEoWo69qsbW z6FFC22WSyh33kzA7XO2XfdN5fg60WbujwazNJUVxZC0wrH9qzw+Zd5rfqk4DpGaGyFd7651Y3pJa 5l0Ol3isbnzMD1khnGn/sinOaf7tsVIQGZ969EPt/zIf4PrS0MN3ce6nYiv6K+cIhSO3WSFJYWPLu kMhy412zKba0Nso3hCjJw3bqc7sfCgzEiItUuinmJmWOyHQdPLgT8UfCn275137linx2xBu5aM1Vh Fg634eI7ESNhLxbYXpCj+X8zTzl8GrrlP4KGg8cRWwzbiQ56xQf3OH4N1miNeVRsVU8G5oeKNG5x8 A+0Vr+kA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rOX16-004aGO-0f; Sat, 13 Jan 2024 05:57:12 +0000 Message-ID: <84df0f74-b165-4076-97bc-9f90e29410d4@infradead.org> Date: Fri, 12 Jan 2024 21:57:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/4] Introduce mseal() Content-Language: en-US To: Jeff Xu Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org References: <20240111234142.2944934-1-jeffxu@chromium.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5AACEA0006 X-Stat-Signature: tmoh7zfm4ndedokfc8b3drc6onscojys X-Rspam-User: X-HE-Tag: 1705125449-600551 X-HE-Meta: U2FsdGVkX1/pSko0qv7Aw0KjDVt+BqvuGotHBxFjsCR5n1pNJF6tDQT/7KeqZo4uGf7qiM/sQkb344uE8rDUZm7Nqny/vcPckEbHR6q0MU1DjpQ/tb35wArb2sYsOUdx3En+/DOhrsCVSnSro5YAOXVN43urrQ2aj4Z3Q1pQu4ZBwudqkRgop/6Jmaq3InGLZ3+LRKOZioBMsEV2cI9nTN4uIH6hd28Sxz31VLrEW3fTRWIAbO+7UES6i5hVd9TjUlEGL1pFRSZ612h9WSPaPuyQb5C6dLT5LBKidMVdM8U6bkV4KXqEZS5Kx+zZTAP/jzEOfPcqx2uxBzZDWRmZ1/VmklGPuMkOfngz9mRFQsVr9OUiTdmGPTXdTlwgLQBt0u9C/R04vnw9zJ0txyuEZGZeUbnrAN3Tz3YhBTQxbdOGKjc/N20LrvP1IMc6VV5+yfebis1k3ktnIch0Vsx9Z9KrjkdSXkjhOk5RD6n82W7zO+UqmIK72ZCxuSrcmXw1XafCy0ckdYM0RWMTMkmTvv1BkZAc8KjnJT7SdW6fA+20MHlUoSFMQnlCl0Zt8YbE10PATR7X1KoHA7/KMJimH8QG/RsZB3Eq0VzGKO+/LdQALSeG4U80OEH8YJlLjqNdHvykYxKtVVdx4r3UchU8p7JZcKPFG7i4ryTj9WLLy0ilgiumnAu3KoAbsHIQBAwiwzfT8ayfanaTK9Wf7GaCXKaVRjFcBjqsYl7tCTPexmRtzdz14Acv1WNFC82OnWGvSJaZjnUZZa2AsV7T2BoQUJ+F0M2wRP6ysZd6O5GMkXMfg0AzKu/pEn0kF40W1wYtm+xR+cRQ61kedCKS38jbq0RDDtQ3/LqFSAG+nMpAUyNRyysYUV17p2g+VHPV6AGrIYR1uzv2aiPapHET/9o/wlsLLcpwbB0Vje18Use0jSmyNP2ph/65gIF0n2nsY8QyqtBeAwozypJnvqkjULj j9rK0oSk 2Iirbi4LjyINHnNcr2rT2+C11wxpUIl125LHbe7jfTPurYd9SYrw6U9VfBma0oOYbLl4TIFSI1/JKCdX2QjT2sBPTMAgcHjcEm6XfkSGacR/l7UhugR6QPFV303JM4nFmBD66KTb8HKiaBFnYV7vpApF7e7cS9deX+WzwcfRFpFKJZ6eGylUV6vFNACYfDX6KOMjOpfqPR7GGGxj7VhnFwqzgChxWV0YGdpZkG2P5OjonCwBGHZl/Ws44u91wmwx5f9dKBl5F/ZLODGAYAEcFz4esOROri0c+b275ym0wqa7nbqzQfhz/3qanq0tUdLEVjNke05kykj+DKoMoyF+PZfN4rE9zjl8jkRTNk/O5m8qC+oJL5OCjrhGFynhzQvP1E0CKIZjAjf9AmXKmf3tERMTD3ETEFovw763AfV9Az8JOKQnF+OdMyrzL0CwQy7JPd1EhrDrqvHdnnxCOcPqGlOHKvpTZlnLhSe3ZzOzg0Uo2f3Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/12/24 20:53, Jeff Xu wrote: > On Fri, Jan 12, 2024 at 6:20 PM Randy Dunlap wrote: >> >> >> >> On 1/11/24 15:41, jeffxu@chromium.org wrote: >>> From: Jeff Xu >>> >>> This patchset proposes a new mseal() syscall for the Linux kernel. >>> >> >> Jeff, >> Building arm64 defconfig, on linux-next-20240112, I get: >> > I don't quite get how this is related to my change. > Can you please send me the steps to reproduce ? I don't usually build arm. I don't get how it's related either, but when I build arm64 defconfig without your patches, it builds without errors. After applying your patches, it has errors... I did it 2 times just to make sure. It may just be some difference between x86_64 headers (is that what you build?) and arm64 headers. Install the x86_64-hosted arm64 compiler from https://mirrors.edge.kernel.org/pub/tools/crosstool/ in e.g. /opt/crosstool . In the kernel source tree: mkdir ARM64 make ARCH=arm64 O=ARM64 defconfig make -j25 CROSS_COMPILE=/opt/crosstool/gcc-13.2.0-nolibc/aarch64-linux/bin/aarch64-linux- ARCH=arm64 O=ARM64 all 2>&1 | tee aa64defcon.lst make ARCH=arm64 O=ARM64 clean make -j25 CROSS_COMPILE=/opt/crosstool/gcc-13.2.0-nolibc/aarch64-linux/bin/aarch64-linux- ARCH=arm64 O=ARM64 all 2>&1 | tee aa64mseal.lst If that does not reproduce the problem, please let me know. (I use a script, but that's the essence of the script.) >> CC arch/arm64/kernel/asm-offsets.s >> In file included from ../include/uapi/linux/mman.h:5, >> from ../include/linux/mm.h:33, >> from ../include/linux/memblock.h:12, >> from ../arch/arm64/include/asm/acpi.h:14, >> from ../include/acpi/acpi_io.h:7, >> from ../include/linux/acpi.h:39, >> from ../include/acpi/apei.h:9, >> from ../include/acpi/ghes.h:5, >> from ../include/linux/arm_sdei.h:8, >> from ../arch/arm64/kernel/asm-offsets.c:10: >> ../arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_prot_bits': >> ../arch/arm64/include/asm/mman.h:15:24: error: 'VM_ARM64_BTI' undeclared (first use in this function); did you mean 'ARM64_BTI'? >> 15 | ret |= VM_ARM64_BTI; >> | ^~~~~~~~~~~~ >> | ARM64_BTI >> ../arch/arm64/include/asm/mman.h:15:24: note: each undeclared identifier is reported only once for each function it appears in >> ../arch/arm64/include/asm/mman.h:18:24: error: 'VM_MTE' undeclared (first use in this function); did you mean 'VM_MAP'? >> 18 | ret |= VM_MTE; >> | ^~~~~~ >> | VM_MAP >> ../arch/arm64/include/asm/mman.h: In function 'arch_calc_vm_flag_bits': >> ../arch/arm64/include/asm/mman.h:32:24: error: 'VM_MTE_ALLOWED' undeclared (first use in this function) >> 32 | return VM_MTE_ALLOWED; >> | ^~~~~~~~~~~~~~ >> ../arch/arm64/include/asm/mman.h: In function 'arch_validate_flags': >> ../arch/arm64/include/asm/mman.h:59:29: error: 'VM_MTE' undeclared (first use in this function); did you mean 'VM_MAP'? >> 59 | return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED); >> | ^~~~~~ >> | VM_MAP >> ../arch/arm64/include/asm/mman.h:59:52: error: 'VM_MTE_ALLOWED' undeclared (first use in this function) >> 59 | return !(vm_flags & VM_MTE) || (vm_flags & VM_MTE_ALLOWED); >> | ^~~~~~~~~~~~~~ >> >> >> -- >> #Randy > -- #Randy