From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549C3C3DA4A for ; Fri, 12 Jul 2024 10:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 809D46B0088; Fri, 12 Jul 2024 06:22:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B93F6B0089; Fri, 12 Jul 2024 06:22:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680D26B008C; Fri, 12 Jul 2024 06:22:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4BAC66B0088 for ; Fri, 12 Jul 2024 06:22:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C5DCDA3939 for ; Fri, 12 Jul 2024 10:22:55 +0000 (UTC) X-FDA: 82330712310.14.F6B646F Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf15.hostedemail.com (Postfix) with ESMTP id 36ED1A0027 for ; Fri, 12 Jul 2024 10:22:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of shameerali.kolothum.thodi@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shameerali.kolothum.thodi@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720779756; a=rsa-sha256; cv=none; b=zQIg+ZC3GPW46HRQSJKcMIVmzdlsYP1cZlTPElWqYG9oZC1CJxBjUHh779/JrirGitjplO JDwvfugh4tkpgJexQEMMh1lXUE7ftcH7tqa9oN0iwepH/z1AgDbJeF9wAVVtTRCe2jBsT2 Y4Sc2+uGJ+uKZOJD4obpssrEVswH0kA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of shameerali.kolothum.thodi@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shameerali.kolothum.thodi@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720779756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QS4nPbBoC9SH9KlpMbrnFlSlRX6UDLvJfXPNflULYkg=; b=6dXdVz9L6Kx+XKQIAjFtt+Fh2wjtBiGn/q3+s9mO4g23s2VhW8IId+ti1gXm3qq80FAXXV q4f+qbNrd1RqFT/Cwk4ujB4araeY3lQk1zcfApXfbIjkuzK7R9djdu72h9ryS8gpaGX/wx Rcm+FhulDwFsDh7eFaLLt7wN+fPgVgo= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WL70s64tFz6K5t9; Fri, 12 Jul 2024 18:21:17 +0800 (CST) Received: from lhrpeml500002.china.huawei.com (unknown [7.191.160.78]) by mail.maildlp.com (Postfix) with ESMTPS id 89046140B2A; Fri, 12 Jul 2024 18:22:49 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by lhrpeml500002.china.huawei.com (7.191.160.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 12 Jul 2024 11:22:49 +0100 Received: from lhrpeml500005.china.huawei.com ([7.191.163.240]) by lhrpeml500005.china.huawei.com ([7.191.163.240]) with mapi id 15.01.2507.039; Fri, 12 Jul 2024 11:22:49 +0100 From: Shameerali Kolothum Thodi To: kernel test robot CC: "oe-kbuild-all@lists.linux.dev" , "Linux Memory Management List" , Will Deacon , Ryan Roberts , Jason Gunthorpe , "Kevin Tian" Subject: RE: [linux-next:master 9539/12880] drivers/iommu/io-pgtable-arm.c:772:50: error: 'IOMMU_DIRTY_NO_CLEAR' undeclared Thread-Topic: [linux-next:master 9539/12880] drivers/iommu/io-pgtable-arm.c:772:50: error: 'IOMMU_DIRTY_NO_CLEAR' undeclared Thread-Index: AQHa1DSGChJrAKxTUkKXF/6p5xqHYbHy4YEw Date: Fri, 12 Jul 2024 10:22:49 +0000 Message-ID: <84de5d98f80f4890943eada39b795fec@huawei.com> References: <202407121602.HL9ih1it-lkp@intel.com> In-Reply-To: <202407121602.HL9ih1it-lkp@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.147.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Stat-Signature: 6qn5ihbkroog3h5u5g34pq3568wm1nws X-Rspamd-Queue-Id: 36ED1A0027 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720779772-614085 X-HE-Meta: U2FsdGVkX1+Q5ZUWD855SmEaFDkjBy53o5LqbdxudDSwHWI1vYmpIa5SAl9+jiRKP7KSeAlEfgDwGvTT7qv/0SJM8JnnSa0yio1lbpqC4ncP4Hviff9gxQJouQcn6sGeTi432sQuT1gUDE9aId322CXUowCz98CxGUKvVqTtv+C1IUtpZdHPi1st3RfOWJ6bXnO0VZaVQniqToOl83l/1rt/D8GvAPo4xnkCfBvSSerI+Q1c2hYyvD/28TLWcP0kwF2i04eIGCwSN0VSGindC2mG1DF5gxfMQzX5568fB7SO7K0/b+Hc2wUZQlRaNnCtmq4Mpxnq7EfcBhbQB14/hLoE98rxbBtDC1ZONlAv0JdBEvOh6015DAULuwNsWmUZvMRMf2tBGZdf85CIuMfJha26vjmSe5kO5vC0stbcbUf9azBu+wHoNw6lnlf2G8If5Ylzi+cffxZD89dnnPoS8nv3zUMplXttSm10URrpVamFVRmoFs/idM/8W85yMsVkLtSPzhbsE6cwyYb3ttcSMO5hDPMQLwbaMczTxUb3uKKkY95EHOvsPeBwLbe32tmBwtKp744uvLbdPyaONt9rG+68B0IoodLfMaa3J3qnKp5b3/HcZAq13XJ1ihznQEmBtkHYpVhqRwlM2WLWbXUEe0tagNx3x9NakSwFDdC3zdavcJKwvvACWBD7kZMEujr3o6cHOzpVcCtRwog960EujnrxeIyS5veTqTNBa+I1DAcjrE0vyCnqsvYJGDELus9Z3lXiqZxgZLMsJcEn/f/4XEI2PSrXb4iD9IPXqyXboZeDJsw5QN06H/E/FCPExo//ubDcVvOZ2KtU/yIF2vF1r3H3jsy8/ROyrYMnUxilhY7t0hYWqaVr7WiGEFKyHTHYitk9aEqs18huZxECkFNvc5ZR22bmFZs9vIkstPUQf1ydDl7RDgRnExoUSUKgo94kL/gtmgmxqIZKTNi3u5T Yqg2Ro0L 3i3zlOKsYT3Kz/CfmCJ7VcloPMuphd91RKbBBwYlsetGalw2fzdxkCzE1MNbyyL0FCUmB3Tm8Ycbm2WLriM/2cEoTaqQfK4M9jqq4H5+Bp0ujvzOnjtVIxDvgADYaourMwJ0q/pRBRONRixOFg/9gs5lzq0ZmtEuQKiUsdtYatIGw2XklhRAWCH11cUTnOc7m4PX+xnksC0TMFX0HSAdNLDh5Df/avr1PjShIon7CdMUSUGuieKQtSloXNveZbWAN5CZDMcRvQLA/8L43S/YbMCMOqAQmzx/lMTNRdnfM11CPIIa6u8MlgHxRQ+slTA9NSItB68Bb1tc8LYrjpuLUNkpFCAIKD5ZtJ0aAIMD06CzyyCGk6gh5I2PkCLibdZhXKt9hCbn+n8WQGP9A6QbwbYzFgjqsGTvDiKH+xN4sZWJXCs9SRoB4AOjDiCjRIy+ti2HALyppu5Mp9c53QzYuffc2DAE0auEmWsUkcnu/nyFL86q6k0iwmVLXtX5dOOcpaQ7HOlV3KNeHTaom3U1KD6D5FLMf3mc5ukd4xyot87NXVe8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: kernel test robot > Sent: Friday, July 12, 2024 9:21 AM > To: Shameerali Kolothum Thodi > Cc: oe-kbuild-all@lists.linux.dev; Linux Memory Management List mm@kvack.org>; Will Deacon ; Ryan Roberts > ; Jason Gunthorpe ; Kevin Tian > > Subject: [linux-next:master 9539/12880] drivers/iommu/io-pgtable- > arm.c:772:50: error: 'IOMMU_DIRTY_NO_CLEAR' undeclared >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it > master > head: 3fe121b622825ff8cc995a1e6b026181c48188db > commit: 4fe88fd8b4aecb7f9680bf898811db76b94095a9 [9539/12880] > iommu/io-pgtable-arm: Add read_and_clear_dirty() support > config: arm-buildonly-randconfig-r005-20220402 > (https://download.01.org/0day-ci/archive/20240712/202407121602.HL9ih1it- > lkp@intel.com/config) > compiler: arm-linux-gnueabi-gcc (GCC) 13.3.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day- > ci/archive/20240712/202407121602.HL9ih1it-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202407121602.HL9ih1it- > lkp@intel.com/ >=20 > All errors (new ones prefixed by >>): >=20 > drivers/iommu/io-pgtable-arm.c: In function 'io_pgtable_visit_dirty': > >> drivers/iommu/io-pgtable-arm.c:772:50: error: > 'IOMMU_DIRTY_NO_CLEAR' undeclared (first use in this function) > 772 | if (!(walk_data->flags & IOMMU_DIRTY_N= O_CLEAR)) Looks like we need to move the IOMMU_DIRTY_NO_CLEAR define in iommu.h to cover !CONFIG_IOMMU_API case. ---x--- diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 7bc8dff7cf6d..104ce84647d4 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -317,6 +317,9 @@ enum iommu_dev_features { #define IOMMU_PASID_INVALID (-1U) typedef unsigned int ioasid_t; +/* Read but do not clear any dirty bits */ +#define IOMMU_DIRTY_NO_CLEAR (1 << 0) + #ifdef CONFIG_IOMMU_API /** @@ -353,9 +356,6 @@ struct iommu_dirty_bitmap { struct iommu_iotlb_gather *gather; }; -/* Read but do not clear any dirty bits */ -#define IOMMU_DIRTY_NO_CLEAR (1 << 0) - /** * struct iommu_dirty_ops - domain specific dirty tracking operations * @set_dirty_tracking: Enable or Disable dirty tracking on the iommu doma= in I will sent out a patch. Thanks, Shameer