From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA350C74A5B for ; Wed, 29 Mar 2023 23:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C3A6B0078; Wed, 29 Mar 2023 19:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A58F6B007D; Wed, 29 Mar 2023 19:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8166B007E; Wed, 29 Mar 2023 19:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1D06C6B0078 for ; Wed, 29 Mar 2023 19:38:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EAEF840F3D for ; Wed, 29 Mar 2023 23:38:44 +0000 (UTC) X-FDA: 80623552968.29.4A718D6 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf27.hostedemail.com (Postfix) with ESMTP id 812914000C for ; Wed, 29 Mar 2023 23:38:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=pnHbg7Vl; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=KBjlQKVF; spf=pass (imf27.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680133122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+5HwXhhrhHrQfkuI7Y7ovm+xrXzXoZBgfLszf1ePCZs=; b=PXvm6dUWWIg4gqFxKq568AmBiY+L/HtO/JXqoIFLtySlJZFV9zgN1zUM4tn9X2rPdcs0sT E+TsQAhOoCzaJH06vZirB3LO6QF1LiITrzwL8H5nQ6WmNC0iZimjLLbFcnZrIGGAsiB7xl jTcScQXngZZfkkcgXv74UTweMMl6Uk4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=pnHbg7Vl; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=KBjlQKVF; spf=pass (imf27.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680133122; a=rsa-sha256; cv=none; b=I9G0aJsy2334Mb6w8PFkim5ZYUKeoapp2BU8HeiEmnN9jblg64oKFlfvZ19pxFK1HMerLm M+74tP8hGR9EVjhXJhswIPsxgYw9j6seFxb6tdbWrcWMA4mAZ1+CoCbkS2qrf35CciIW09 Pvj08cymM9dImseywcfjXT72cRJjjqU= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680133122; x=1711669122; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aODFcqxqHz5iuZ9R2+Bd+E8Nkx+iNXfbVHgy68x60n0=; b=pnHbg7VlRfryIZfqK57DeibJUwN4w9Ka+aUrOXVv0jF7EAjAS6SPrrP+ 1RBDk+mbKabnO7nkEgrVLhELlEQc1eBQnLI6lIqLiPTjmSseZ+/WpaKGr KyMiIbAjqWEdNM12EPqz014eVWgU22lmbwTxPMY+SzSZS5Ve8CEuuwKrY ZBcruobjacSobDcdZ1dstjmPozAC8izcuGZsOLkS3l4r1BGRJqg+VKCGL HnO4EUQbxgeyljLjFGvSj3SqMgmly1yCa4KE8GAcaJqT9VybC0Nea5OdN D1kQaaKUq+f99u9+70ByTwLJ7yUom4E9UG+JHdfWdrhIZxAUMXQfG0sJy w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="231808952" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:38:41 +0800 IronPort-SDR: bT5ZurjNB6dGp8SOhN6uKWAVgnmJcp+uu6pOhPV9QsRdFkQ85qfb/nsEzlBPHz4rpwAIqDSee4 HVeVixxmuGFTTjdEGd5w3X5h/wGsv9itHzQ4K9kuXpilcBmO6QTd6Xx9ODlP0KCgnOYFL500rM rvjceo237e3zKEQQOWbHtnNUsEGLZyRJMPq2tWM/U38jBuA/IAJheXZvcfAoxrfPE5/3xscLEH tRRUn4KyRENQm9p1T2acP4ygwnUEHiSDYpvK7l3MsiGZqX7yQ7gwQkkwIZlCcq0w0P6fKW7OH8 Tsk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:49:08 -0700 IronPort-SDR: 9x4HrSCmw48KpOomcyYq0JwE63UEnwKFOFwXG0c4z3t0RcEdfMvIwfoi+tXIuoqxBuo7ioZgJ2 sqBFX30WgPwt0E5fBUyYcQgEElojwNsgpMIXux6UXcwR62gPZJFYiCs8zvXAvtPJiJbx6DgTFb 7uUGiWt9hNZNxukL9MeXFxkYRPKltKbaxKquTHv3IwAM960xHlFllyxx11QqEZ/gkzjWcw1gk+ S5ay0FMWy7E7HtTsRtUT7LF2/Eicn4JI8m6Jxl/25WT9DBKXGXgPKfPNtdHagJkTrc3LkstrSy YuA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:38:41 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn30J3hc0z1RtW2 for ; Wed, 29 Mar 2023 16:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680133119; x=1682725120; bh=aODFcqxqHz5iuZ9R2+Bd+E8Nkx+iNXfbVHg y68x60n0=; b=KBjlQKVFv+faQXsHdbboX8Xx9NxcmIm9AdBgDadiYuEI6iU44Gp jIKLTOiXkry8UpjbdYwauGh77NnsPrQSFZpCT7/P7YDoBzDw9zAFX+sbYXbItBD4 Awy5kRAsBzpAxGEQt6/iFRAhFRIvGXb6QP2BKhHdWdA6t/8jyHKIjGtg0XDfA0ep 9/S+K4tRXJIRFwdQ+UasHvlXj7W7pXISUVz/O/kQ1s0icT+btM6C83LvSU896SWN zX3mTR/5AXoqxmQ7Cm4R0QRAsxtuKFEiZ8wGyy7Y6iwGwfe3kKGL98CIKdDi6AJd jzR0sEF+xRcPBDw1yJoRYinpIPNolkCqMHw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qp7lK7AUlH3P for ; Wed, 29 Mar 2023 16:38:39 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn30D5vG4z1RtVn; Wed, 29 Mar 2023 16:38:36 -0700 (PDT) Message-ID: <84d3057f-58b3-b3da-a473-082806c4b5f2@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:38:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 16/19] md: raid1: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <8758569c543389604d8a6a9460de086246fabe89.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <8758569c543389604d8a6a9460de086246fabe89.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 812914000C X-Stat-Signature: 5n8o9xjqyjkquxcfer6jschbpy8xqrgb X-HE-Tag: 1680133122-341916 X-HE-Meta: U2FsdGVkX19ykFTYobBzCBoY0hqQjz0n9cjA+XX247gXrd+tmKs0hJJ1Oi69eGlgnm8x6wJUC4zvuImfE73rzl5ysdstAoEI0skPLHkVbqRmR1IWDlqSEjxsGx+3F/Xx9F7S3XVQy/C/DvyZ4+kzv9bBXBRNVrEIVgeILg2gx6cOX5gMDRbAtdEDavbaJXbrAbrOFs7mbEUJpBAIcfi7lZVYtf8TSU0YHq2xvCuYWhKtHT3eKv5FM/PJNu8qqQOtmEQsS4kULPlcJ9BOe4QKVHj2Sg0hTPUE05XRQHSu1auB7OjWppDBKel2pIxumw14mAPCxrIw1sneLG7ovDzKjddNdQz4Io6z4TXL/siwBD2EDSdw+g3Xl+xfheAvylFInn03xlfx3brPb80OjSo3TDTcKBgHgubFUMg2690GrY2uDw9VSUml00JsASKy+0dpT0lD6RzYDPVQA5hW4s1cX2z4ZVHHwzvDvQvhDkjQpV4kyrqbceOYrtmNa+HKfL8mf2j0I29RV9MZ+koN+alKeFcvrtMJQjDghufsi8eZ45TyxcSK9Kc6XrglQP6Eq7gOEpod8mcIlVpsBr3vd5AwqHgdwR0Dk1Y8rzcQ5Rqb0iM4hMW3/L3NdUyTFDzSnP2MxXC8qKzHYtETKngI90wPj3DkZDbc8yV4XRf97LOu0LudDVij2kNQwyYTxqX3KdiWnJ3vvO+CdDOSUagmLPepAlC6Bc/4U5xXfFAG7QNFTQ4bQEv8bgVMldf0jZlQNE7CWxfyHwzyrpFWXmz9fojPse/YDZbJ4EWyM/JXJ0yaVNoCcA/AqQMCP/iIst+N3ZVBeyGP0yRlbBZOqIHlkBeKmrTegY64tpjeU1kgyS3cK1TZwjJ+eNTQuHuYZcEKT8kqTPHHwHUS4BG+jmEBsShEroLBKMk+BRIgXzFXvKU1lCH3qM7pZhK0RnXakwd+QA+kSNMRycQCWr6Nc6BVQay mcv3MMYq 0bwYF1rAbvWowoDFEaDXJZsJCpZcHDU5id5hN7npizAspD96thhtGB9mQtF3EZBlekecZJp531oMe4PSh1ei7hKBUI2wui+xWVW0mLZ41UpeLzWv1gWO+iPyWq/KgAs9A9CvdDB2QjHEEfUwXAc2s+Y7aQQEiN6aVRHpSOhYKvg/Oi6X1cuYrDA32mHMHE0RnlFaZfO/wZGPalSC3/CXJKTvwOjPsnZU2eiZKMcyh+BHgIGuSQAEG3pxqrTh4/uVo2xs5LkpWYoazTD+GF0f+uk5aEzQ+WpfI+YmpAbrnPKMoVcUresuPRzAOYmJfqEewj1+8EzG9nmzMYJPUp3HNhnxASI6kQCxFu/NFbsLHF7Us8xC+9ciNzXpzgqW/870L+lApHmyRVY1bB2CyUzFxkOxhR1T38fK7CUvgH7BYmn+LBzTij71dEyQXYj2wicWtcuij+mk7Oym76PhaK/tTgvAoGN/Q1a84wHc/1mSF6tYUzPsi+jWAtew4VMDhoijUb3B6B1NUBqOtt2MAeozf+0/F8iSP6sQX7sOJKmpgJrolAWfoqxVrb1UkSc+lqO69qVjg5DMr1f0OptPl403Z9QqTdtDv4s49+ATMl5XjDmVhcW3k6q2M5zEqUCjm/5QUEFIlDe3FpAaz7G962EDSYXhRthOtg4zpUlEiIL9AJlFKK0bbwZ6nU2E8mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:06, Johannes Thumshirn wrote: > The sync request code uses bio_add_page() to add a page to a newly created bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research