From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A472C77B73 for ; Wed, 24 May 2023 09:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78A94280003; Wed, 24 May 2023 05:11:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73A65900003; Wed, 24 May 2023 05:11:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6026B280003; Wed, 24 May 2023 05:11:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 51123900003 for ; Wed, 24 May 2023 05:11:49 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 140A81A08FB for ; Wed, 24 May 2023 09:11:49 +0000 (UTC) X-FDA: 80824581138.01.D2E258A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A0A6140010 for ; Wed, 24 May 2023 09:11:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jMHrwZAK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684919506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pcora42m3cheTOIBvw6GkIZ5gCuxPX3EpEruDFY9GWU=; b=bQj59gPFm+xkMQk8PM6pI6//1jRC6vfDNdXxys2KImbCPgFQQiCXjmVVn+2+8yy6DQ8kax CPfPiQmcqpEPc7Q5oMaNHuW8qjvj0uymAwIWmN7AXT0gO4sJN0uCvia3TBEL4y1Aj2SlJj aBgBoKz2VhLXynOuPC4eodoej/ZAxtw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jMHrwZAK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684919506; a=rsa-sha256; cv=none; b=jhfKMGCSzLJRpFXDz64L02JcX6tcwKEgx6q2MrOx+RBQirw0Kvubv/OktDilhvCu2ZrFVO iYOGWXEezpxxiAR6n+Oh4A8c6qHuZckLzNFR7qvDfBkwtpksLWS/btE6iJuqqm7ZAKwO0O 79Hg2Ct0a8YFNITc7qvcZ2DBnUJvknU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684919505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pcora42m3cheTOIBvw6GkIZ5gCuxPX3EpEruDFY9GWU=; b=jMHrwZAKnFFu9t/9XA2FV0phoRFe0jalPqO2bKEdW+AIjy0y3oS8reQIqWlik2m8AkTl0O ivA2W6RuUrc6x/eM8A1ZxLIVwXFaz6QYvVCjMjwMO132rIWVxZGIPXHfj5lQAT60P6H9FR H46lMcGkgMyeTqXdiOnfJnFfqWo90rk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-cFUDdvYePbSUHxLBWa6zaQ-1; Wed, 24 May 2023 05:11:44 -0400 X-MC-Unique: cFUDdvYePbSUHxLBWa6zaQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3062e5d0cd3so215857f8f.3 for ; Wed, 24 May 2023 02:11:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684919503; x=1687511503; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pcora42m3cheTOIBvw6GkIZ5gCuxPX3EpEruDFY9GWU=; b=YtEX3HsPEy0gRq0u9Zw/MO+B+EBmf674LNLjUTsxrwE7cCDpiweLaWgLvYJcX8xqEL mBfIbhOSKEebo6PSZx2+NS3ToOYX8RefOPJaHQo/SSxg443E1Ilrhr+pHSNdb7FCcD8H SMZDd2+3lfn6ov1Iwtb0T/4u6SeyTj7VOph+OgEo5PTg7gtlbMq/7/WghT3YtbHrNOfg Yl+SujXo6EQEBzwPfYAgIJDbPBSvmgP7Aus551pzmeyT/lBGuDikmbWTG7Qdr33pdkiC Fo0lhABvIWLq1rGFP4qit0E3GCmz6UZ9hZKPl7hWPf+4nftVwbB+jWwCF2ALL3XX0qDg b4Yw== X-Gm-Message-State: AC+VfDwxGbUY+Bt1Mn0MLBVGKoxvpV42X/gfAiWUgrTxQ/ZnJecbF6h8 Okk+DfhhCXGeZct8sIB0NyemkeUSN/f86P2rgqB0LBx2PbdtHYCSCZR3W27bhFO4ZXzxwT+qKEp c4ojex420Hp0= X-Received: by 2002:a5d:6083:0:b0:30a:ab38:3104 with SMTP id w3-20020a5d6083000000b0030aab383104mr1140208wrt.34.1684919503306; Wed, 24 May 2023 02:11:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5CQILuzjlrD3B4P8U9hT6uxcQuhQfkt1q2wkryb51NsaKxV8s6VcEUl52yg/LGWKdqkGTnLQ== X-Received: by 2002:a5d:6083:0:b0:30a:ab38:3104 with SMTP id w3-20020a5d6083000000b0030aab383104mr1140179wrt.34.1684919502962; Wed, 24 May 2023 02:11:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:f700:24cd:855:1c60:1ff4? (p200300cbc70df70024cd08551c601ff4.dip0.t-ipconnect.de. [2003:cb:c70d:f700:24cd:855:1c60:1ff4]) by smtp.gmail.com with ESMTPSA id l9-20020a05600012c900b003078354f774sm13644544wrx.36.2023.05.24.02.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 02:11:41 -0700 (PDT) Message-ID: <84c00f9d-0b83-e4a2-de6f-617cf23b6444@redhat.com> Date: Wed, 24 May 2023 11:11:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202305241351365661923@zte.com.cn> <20230524055906.20614-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v9 5/5] selftest: add a testcase of ksm zero pages In-Reply-To: <20230524055906.20614-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A0A6140010 X-Stat-Signature: 4ahhciahfqce3oac9aqdwkoxmhysf6ip X-HE-Tag: 1684919506-388600 X-HE-Meta: U2FsdGVkX1/pWPH20OG2aSuBLNniykD1gbNo2R5wo6mgF3xPBt48Gtif8HcBtozO/mgaGuWDc/P1WDBtb/aY/D1DSR9y5KEswHt6745KIUYyezS+XZxkGkVpO9qScVx3VsmUe5ZlOpRKAf83kl6Ymr1Gg0p79cHjtyG2JmoroScm24m/BoQmgdM2XFu/Wzctr0rfMRRwDqQOQIZ8cwrNfXfxHYf7yG+5lF65V4E10sKs38ZBwmj/ktPfsOsa/wfv2VkJqRFkkjGq4PzIxUV3SkgtY71GTG3ZWze+3LWER2epsNF08Lu/X9nXtFnXQd8w86RQCQuF42n5oHVqH32nllS7rnFspi+LuI5SXxmiUi+M6sp37Tnlv04WKuJc5ay5vHXMExUupkRSmQT19wfuu3lZ60IC0qcG6VY/BZeKqUfeJCQD+Eb6eRE5hGcRAicrYe5YlDj7nHpMtdVKUR4qRe+EQXEDxxYttkimDmknq6vYYNxI29avuvlEG/HLDtTRXCh+Quo4DMjEzVVw+C2nnHKmR79X2jSl2qfnDq6jeovRQ4cTCVyKkMqCE8i3djEUzZLOanIkKmR2FW58T/vzhTBeUoAtd3Ki8wPhXv4N9LH1ttaacNcEmIZ/qsBVQ00dApSqrxsrRIwvTcZzLM8u+LwdAeIDQzEzw5Hj3fB8Oo7MpKP4nFDre7+a+ahsey55RMog/dfpp4ivqn0Be8tkSesmdexQx1t5E11iwNYgOATRXTYeJ13qNgUql6DjxKyBzWGp1ObeBRSbMPfWwUQwgkuX/fD8FpLbDnRsniKPTYKV4QVbYtXiwx/JETuUbGX4UoOiYMkgnOxWIZyktkOaJ4/dzhGXcQb5xOdE1C+CyGwC0pb2S2nuGqqsl7eSd44JS3roqWgjX11LUkKhEWotiLErTRB4uTxcqB+yd/DitqQ/NVkWMxh/fU+c3Q+8Q44Aio8ptJXlB960kd7v4Rw KjX84WBI tvCQr3g/qjHHSpfnnRXG613jfqzwWoIud/FEbajMQtvAm08SLY6Ibil4O/asbeSNUdB1MVe185VlujK70nCgQMoJ/hmC1USqoxOJEYsVLhbc5R0gN8tfIoKk8bguzplyuYrYmxhg+H8b1gncXJSjoUPVT99Dv6uZXhr7POnwxw1C5bZpKaaTsK86E+Lysc8x+7wrXCI8BQQVupz5iedvwvIzHJNM3Autd4wMGGikGoWCmgf7CxkeV+8jyqXO8gVBkGD5Z4XUuj1RsAkdS1cmKx1gWfMr6pXocrcvsGkTTu9l2It80NHnQl7D6XkGTDy1kcO4lWDOIxwJ0UScp2am358U5o5nS2JKVfu2bCaKyYcPwdAHVP1hd/oFz8l2UPCXdBuLjR0/RRpHCusfQx2S1CA21aP3nl476bzNZnHGUWEF4/zuM+133Edpqs1+m4gT1g7ZjNFwwh80Nn+I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [...] > +static void test_unmerge_zero_pages(void) > +{ > + const unsigned int size = 2 * MiB; > + char *map; > + unsigned long pages_expected; > + > + ksft_print_msg("[RUN] %s\n", __func__); > + > + if (ksm_zero_pages_fd < 0) { > + ksft_test_result_skip("open(\"/sys/kernel/mm/ksm/ksm_zero_pages\") failed\n"); > + return; > + } > + if (ksm_use_zero_pages_fd < 0) { > + ksft_test_result_skip("open \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n"); > + return; > + } > + if (write(ksm_use_zero_pages_fd, "1", 1) != 1) { > + ksft_test_result_skip("write \"/sys/kernel/mm/ksm/use_zero_pages\" failed\n"); > + return; > + } I realize that this test will fail if there is any other process in the system that has KSM enabled with a suitable page filled with zeroes ... maybe instead of checking the global KSM zeropages, check the per-mm ones instead? That should be better. > + > + /* Mmap zero pages */ Maybe better: /* Let KSM deduplicate zero pages. */ > + map = mmap_and_merge_range(0x00, size, false); > + if (map == MAP_FAILED) > + return; > + > + /* Check if ksm_zero_pages can be update correctly after merging */ s/can be updated/is updated/ > + pages_expected = size / pagesize; > + if (pages_expected != get_ksm_zero_pages()) { > + ksft_test_result_fail("'ksm_zero_pages' updated after merging\n"); > + goto unmap; > + } > + > + /* try to unmerge half of the region */ > + if (madvise(map, size / 2, MADV_UNMERGEABLE)) { > + ksft_test_result_fail("MADV_UNMERGEABLE failed\n"); > + goto unmap; > + } > + > + /* Check if ksm_zero_pages can be update correctly after unmerging */ > + pages_expected /= 2; > + if (pages_expected != get_ksm_zero_pages()) { > + ksft_test_result_fail("'ksm_zero_pages' updated after unmerging\n"); > + goto unmap; > + } You could do something like the following on top (I recall you had some kind of COW tests previously, this should be a simplified version of it): diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index ea060c683c80..160675a4e3d2 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -182,6 +182,7 @@ static void test_unmerge(void) static void test_unmerge_zero_pages(void) { const unsigned int size = 2 * MiB; + unsigned int offs; char *map; unsigned long pages_expected; @@ -225,8 +226,18 @@ static void test_unmerge_zero_pages(void) goto unmap; } + /* Trigger unmerging of the other half by writing to the pages. */ + for (offs = size / 2; offs < size; offs += pagesize) + *((unsigned int *)&map[offs]) = offs; + + /* We should have no zeropages remaining. */ + if (get_ksm_zero_pages()) { + ksft_test_result_fail("'ksm_zero_pages' updated after write fault\n"); + goto unmap; + } + /* Check if ksm zero pages are really unmerged */ - ksft_test_result(!range_maps_duplicates(map, size / 2), + ksft_test_result(!range_maps_duplicates(map, size), "KSM zero pages were unmerged\n"); unmap: munmap(map, size); -- 2.40.1 You could also test manual discard (MADV_DONTNEED) and munmap(). Just a thought about which tests to add eventually later. -- Thanks, David / dhildenb