From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528BCC02194 for ; Fri, 7 Feb 2025 20:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5E9E6B0085; Fri, 7 Feb 2025 15:51:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0C26B008A; Fri, 7 Feb 2025 15:51:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 861596B0089; Fri, 7 Feb 2025 15:51:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5973A280001 for ; Fri, 7 Feb 2025 15:51:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 151221C795C for ; Fri, 7 Feb 2025 20:51:42 +0000 (UTC) X-FDA: 83094344844.13.ADCBD4B Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf22.hostedemail.com (Postfix) with ESMTP id 657C3C000A for ; Fri, 7 Feb 2025 20:51:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738961500; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RPMRMKzNZvGEgke8xV1NcDrp6sVUFJl5xryqWqwwE2c=; b=qUvvQJiNSGP0w48fJKZSUJAVMtVF429a0Y7VaBpVat4dmjmXpK3Yve6pnG0frtVPkjgDIp W2j3GhJnrX7BzJ8c3kLIfRIjY7fJfzH65ktshivkYvISlF0XjHuRIPv7NTZg0oPMLhjdss T5K+bHN6b830pQoi52Vh1+2V5BLdMRU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738961500; a=rsa-sha256; cv=none; b=qoWIRtx81yCdJKCXR828IdR/xx2w18Q5s59Y1UGwt/X9DnhcyermS9hL/a5cwAYIiCxvTn brTZsf1PtGaGV4Mji8P4VUSWxxJ58n8cFtMm/iR21yTQm87YECAiy6zOhuswJUN19CyPhe sgE2IVquS42and5twOWEJcWw15QV8jc= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tgVJR-0000000036f-22co; Fri, 07 Feb 2025 15:50:57 -0500 Message-ID: <84be5ed882141c8b407a78590f6ecbc7080c98b0.camel@surriel.com> Subject: Re: [PATCH v9 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Brendan Jackman Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Fri, 07 Feb 2025 15:50:57 -0500 In-Reply-To: References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-7-riel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 657C3C000A X-Stat-Signature: 55w9z6cuxymnjq9oywtbszgdfm78su39 X-HE-Tag: 1738961500-691680 X-HE-Meta: U2FsdGVkX1/aTWhI+090SaKVHuXMLKGu/UOsC+kxIyyBi0CdciWIVXPjEONd/shJ1aQ6Dynqf/TSb1spdxYd447f44jlksrT8jD5p8IISmlm/4iKj7MRXxlRNYEGv1+vy26HD6CZRirh+Z+0B4u4EW0wDEP1FgVSAzWs5Drf4fmY7DigO2jgtfpSXSrl97EF9Nhg0/THF956n0jFTPr4/Nc3vnyrG/g/LwK/tqCCLhX+7+Dnx17Ojt6e7b4amVYMzHNcF9aIBu74MC+QYWNkRMLy6mwTaEFvTEZSsVXxmx07R/IKdEWza/vG8JkjKzw7ZZUTJdJ5UIVri9sq7kLc59qVyIjHWx0B2L+tLqGnXce3aDYz7NtNrwrkbkN44jtHalYhX2JwBpRR3vdhbe2VN3yFNwf7QV4a5AfrJ6yyCnNPWegeak42oZYsVFwQSZ0d9ILD3u2vpXknxUGN/JZX0xL+uDXe7frC6cesgNI5+lfnzoVDKAiZ3HvDwedN8411KDKy69yhnnGNITyqgTQoyFz+/PVKYDMAuVJXBG0rLL7OswYWo+cruIVeXqBp1gKVXSCrTeSiLAeavBa+8nkunyJh0d7SosdcJkokp9QO9budsuV89zgbQFOzcL64ITJEjSyqKtapJtM7T3udUM+V5f7SuOC3yTdbgrX3dmr9rT2AwY5hK4vwRtFxuC1/DgSVRkUKSA10gL8LniaY+VN2MEm6iOgqYn3nBhosLhYCcgqx5cjwoafpkED/WYCoh81tYItCv8KOZLJlOfZdDDGnoht3027VJVO+Uu3013mx+XD2EFKihH5xPCAIFVLtDr8MhhPaWtnBH0zRBLQmwdJYNk19+EHtNjoHciSKa7N/TBvdX5gUNfGZ5MgDJds9HnrEydrPKaSwctyg6cjIZcPX5E0u7N5KnRK0A95ShTuQPrJ4R1jRHuRTpfuGLidTFRjNtX3c3k0TGsOf7Vt2tvy 1LK7G4KI cJFZo0x3X+CLsGQrPUsyKdGBQKnPeHIfLWdmrSAg1EwOsPH41SU/1Ky5RQEzp0yN+Nh/Lw+qAUMRWOZ0JGY94QlFhDjv9jEXUjRm+7X6q+XY2cysGQwQN9gdNUUUph8WjKhDc3YTf6a5o0/xkT8SM+2q/Q3+xlI1GKBaqdYrS0EYlIxdQSn+GR200FKcIOgLtb+DZW/8JhZ16Qxxqsh5twVxdzld4WG8VS9XHooq4jD+7yfsc8aiFOuVc1LlCve3Dyia4/bU0iuoxHDMJHZBk8G57P8+PuK30XQ8dO85c05rGU7057nj0lnaLx2HQ/WCsZFSKNxuMDr+yeh1yS1ZbZLGIVy67EVdNWhAs95YzBcPJC+s350/k07O24Jv7L7mRRDVH0N0x2tnLeO9FO9JupCgMcnIvVnbFjdowQBoqI0h85x8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.009601, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-07 at 17:03 +0100, Brendan Jackman wrote: > O > With !CPU_SUP_AMD and the above, broadcast_kernel_range_flush > disappears from tlb.o. (Caveat - I didn't actually read the disasm I > just made it noinline and checked the call disappeared). >=20 > It's actually more lines of code but now they're off in a boilerplate > header and it's consistent with the other flags that do this. >=20 What compiler did you use? While I like the cleanup in principle, I don't want to saddle people with older compilers with extra code they don't need. --=20 All Rights Reversed.