From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04074C0218F for ; Thu, 30 Jan 2025 15:57:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 400372802A9; Thu, 30 Jan 2025 10:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B05D2802A7; Thu, 30 Jan 2025 10:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 229B22802A9; Thu, 30 Jan 2025 10:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 046612802A7 for ; Thu, 30 Jan 2025 10:57:22 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 66EA4A0138 for ; Thu, 30 Jan 2025 15:57:02 +0000 (UTC) X-FDA: 83064571884.23.AEF7AA8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E2C5A1A0009 for ; Thu, 30 Jan 2025 15:56:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jOSLZdc6; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738252620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qM4w+1es2FaHKiaH8UoDw9Cy8vwIlmWEd0tDR6y0hSI=; b=sB2NMl9n0b5Fm8CFrC2+q7nA6hFmbs8G+7lNT6yBp6Xw2Dn/iP8R2C6kJwBM3UP97Cg/o6 RPj0XOm541UKDE+cdCi70bmB8/ykV+e6D4XDp/MHHbsLaWIQJhDNRofoXdeTBTdTje4JA1 wSq56koU/F3KVd3mXVoY1vY3642k0OQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738252620; a=rsa-sha256; cv=none; b=aOOHJ7GeWjmzkznmE/iqHP56dEdYb2dcbw80iu7UFthqRy0wicD7mO8+dbGTqN/Ss/nYuK qzgoo27wrnZauGMjkA4pztSK+aKI3kBTdC84KcP0ZKpvrh0aweChIrK7s/L7HrG8WMRZVc mcc997s9f4MSat7J2COttw69oqW4Wkg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jOSLZdc6; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738252619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qM4w+1es2FaHKiaH8UoDw9Cy8vwIlmWEd0tDR6y0hSI=; b=jOSLZdc6Ko+RRFvSNXoQ9Gg+mlLY07fVf/qGGF9ZLCisrJ04aszVAi+dlqw2HNsYQam8G+ y+YQEP5wIqhvS1MGmHQIq7tIDTM5rOcJrQiDmpL9/NdZ0GZmiuE4MOa9eDOkp1tYP1Y/gF +BL4GHRnKnrVI6N1Em3jb2xJjS8rIn8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-5qRw-SL3MmefIACFDdztvQ-1; Thu, 30 Jan 2025 10:56:58 -0500 X-MC-Unique: 5qRw-SL3MmefIACFDdztvQ-1 X-Mimecast-MFC-AGG-ID: 5qRw-SL3MmefIACFDdztvQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43619b135bcso4653215e9.1 for ; Thu, 30 Jan 2025 07:56:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738252617; x=1738857417; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qM4w+1es2FaHKiaH8UoDw9Cy8vwIlmWEd0tDR6y0hSI=; b=FIV9iId1x852cTBAzMSj5rO2+MG4nC4Mz5p+jEXgeNa2bgPuMxgEAx2x+OLZJDLiZ5 /CxyfPGM0gvGzxob44FhXesy16StN0tvldXmOk5SkgHcqWku6Syhmw2kfAbtxRYkZThX /2HdPxZe54arTwLi2KMp+/QOVA6xjcYmjbHm97HlIUl0HCQLUcXybBToQECveQI998/P lOk3u0D7p3Y13fm3LNM4EzKKNmU9NLZIdZ3tkB51gjigaDVp4rZdH7Nb/MFzj3JQt9z+ vwc/4VYpgMFgKbJST/yHiQYRx/ZjyzbmvD7v6B4V4aTDvNvUWNyTbmZE9H6IjSS0TapG tWGg== X-Forwarded-Encrypted: i=1; AJvYcCW/uq9VPzRWkTAzskwa05VqCrIoP84czqtPTzAoT1KZHQqwRoLYVwh+7sZBPVnFBSFT1lufiUwqhw==@kvack.org X-Gm-Message-State: AOJu0YzKeBkcHZeyqMSvU5QvdQhjWKQNYih/BTU725809sWwuYuo5CCw sUGqOfMBh6BLYtApRFm+e6Bi2vjnrG3hDkH4DcX3+kb0R+qYrtV2pGzsvo6DX5FM/OG3vKOwsPj TDlC2FQ+rYasFY/nk6za4FGTNERUeI0G9zOs3lywfC1SQkZf9 X-Gm-Gg: ASbGncsHxNW9RwVaUDnKMDZFF6i3oQgXEiADFjEJc/lyPme5IFgoVzj/Cv6jJjlYctw wgd+ayGxxjHMjru15cD/B/sT8b9SEi9O+n43tOrDcCqem/4aJgNP1J2VLIvsMCyo2ns4Q09YaR3 ukRQJLY45n/+W1AUvX51ir6+SZKxLzhungWCexYiVmW21uBjBu7EiwXvp/CUR3BOMcRrpv6RMbI WlrOgp+7H6K9EHtc4xzUnLXFpZA1PmWtJs/tXFi2tsDp/S05e7MMIPDeRJXqE6OomBsFjkBM2oO xwRpU1S3NmR1m6aBefDJLaS0T6HpP2/3LoooObDRN7eqkSvtAlhtaeXybmjGBw7vHlaR8qO5JU8 JBIeCttzKfth+Z5ZMrSLnO+xWfyLWXJLx X-Received: by 2002:a05:600c:154f:b0:434:a367:2bd9 with SMTP id 5b1f17b1804b1-438dc3ca79fmr78295365e9.14.1738252616875; Thu, 30 Jan 2025 07:56:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLqpKxoaB1vnd8r+/yn1qDNliwYunVoFg0sF0T9rGcNmbMw4yKk/QmEFTvnqEpMXpqQwFnhg== X-Received: by 2002:a05:600c:154f:b0:434:a367:2bd9 with SMTP id 5b1f17b1804b1-438dc3ca79fmr78295145e9.14.1738252616483; Thu, 30 Jan 2025 07:56:56 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc6dfb5sm64700345e9.31.2025.01.30.07.56.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 07:56:55 -0800 (PST) Message-ID: <84bc05e7-f47a-4941-a151-a3b2ab18ad62@redhat.com> Date: Thu, 30 Jan 2025 16:56:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/12] mm/rmap: convert make_device_exclusive_range() to make_device_exclusive() To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe References: <20250129115411.2077152-1-david@redhat.com> <20250129115411.2077152-4-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Vll3NKiNBZfM2TAqY1GUT6RHu5kt3xnuB6gchjGscvA_1738252617 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E2C5A1A0009 X-Stat-Signature: z77ia3mphkjqgih1cmyz51sr3cfmu8k9 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738252619-573034 X-HE-Meta: U2FsdGVkX1808ofOkf5a8l+NqDNNTTtnbXvi2f4nr2up/6Tm1aAoaeA7QJU7BraEJSH0M3nLMrKtT/wkEhuoTlavj0Z8haDn2Q42ChwHz8jaUjLLnrafhHMmw7b3OxaaKLmwdC48kGGgO/eluvejx72QpN6p7UzbDdUCEMiE9yubysjcA0lN6UceszUfu9m/0a5ywjQmyFZr+GHkMB6ymtFuqj1uuzHjq2MTJxT3PjpaJorXAVsi7PR4ixZB8YfdICZo8ZMK++N5yeKmF2TL563PhQQQL/cYqs+UG8m3FJcaOWpzyvUn6htLVXbfCgoUfz6xNp8xuEEAQZGDx+ssQys3aSSFet3fifXS+pZBUoskqiUxeLQPyju5g8Do9c+f1c3Qgq8VNjtNG5FzPEf18oBEWLSsOED2IcbbuGrZO9sMIkXao2G1WplRpgnXwY7tAWINsR5LNgFHOKX7IOR+2NtMgJDhcBqf3l4VZJMOM7LtbwMqMLRS9f55AC7BzV5KDvzkRGJhnf5VtT/QGwxcQ+a3eoBuwpEZfS9iXcSAxjaTvgbnt1O20JceXo11f7SitB4nNUOeP/XtCM8j6FhTptAiBT7KbNBz4UJaNRVeQoKKLX2CWl248ZJLibF12g2QvhyZ84DhJm2/qDj/VkuNDaP0J7BMzs1MuudyDxNuQJOhlAEQliY5aHTloXcS1bD/s3yyQwkRGoHojfXXkApgF5i2eQDnRm1rJuIU27Jr3HZc4Zje+D4CxP9akZVRyNSUamxr+X7C/auBD2MyhN6P2TTC/4ACIqbo0FHDtbx68z+qeZ5WfYKQ0jZUeKnKp2Wlbk7IOKEbQMTq6FD6tK4SZ81DBvCZaHIbyM5/rCV5TeVO2LyhG3PwayfbPc/FE2cued4274m/lDid8Q7QcveNnKkOvf4SPtN2flYGdTPcWBBVvhvAX8p7vMT/5tFTqid8spdizPuyzCdmqv+VcXu wwI0PPLy Rm/VHCBYgBT8MUDLEhtex4G7vYh5zMtD1QrmNpUt9U2BQoI8V0JogCt1S9MiziJBK8VMV2z9YxxkmTJNiaOXG9rOL5B34KBurx6STUVv0ZGRf9L14XQRWFvE9W8Q93J9tLozHgFTaGrXPHmAzU1VlIrHDdvd9OnpXmcNvCqHhIBiXAkYmRoWHnG4XPE/KUCS9zJ/FYM8XutxZtDvKalZoLkd4CBSDxsGnQ2jc3y3V2ny5GaRNoQg5CI8ewIepPOb0zihCw+etKjZe59WxIzXoLD2eByBWU59eLjHJfTvob4eWUF3yy8pBr0hJx40mURKEHNybL3xr02fGz1lh8PHTIls60nreWerl6KfQuLE8ujuCzAHsp/xL1g0gb2iEk1j+oayvvJCb8JAxYYIVh+10lY94p2zWp2eawi+OM8cpwU6+lq8p4oYmhYMk5WrkvkZlRy7OB/TfkuAMchdT3bJX6aI4Dg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.01.25 14:46, Simona Vetter wrote: > On Wed, Jan 29, 2025 at 12:54:01PM +0100, David Hildenbrand wrote: >> The single "real" user in the tree of make_device_exclusive_range() always >> requests making only a single address exclusive. The current implementation >> is hard to fix for properly supporting anonymous THP / large folios and >> for avoiding messing with rmap walks in weird ways. >> >> So let's always process a single address/page and return folio + page to >> minimize page -> folio lookups. This is a preparation for further >> changes. >> >> Reject any non-anonymous or hugetlb folios early, directly after GUP. >> >> Signed-off-by: David Hildenbrand > > Yeah this makes sense. Even for pmd entries I think we want to make this > very explicit with an explicit hugetlb opt-in I think. > > Acked-by: Simona Vetter Thanks, I'll fold in the following: diff --git a/mm/rmap.c b/mm/rmap.c index 676df4fba5b0..94256925682d 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2525,6 +2525,10 @@ static bool folio_make_device_exclusive(struct folio *folio, * programming is complete it should drop the page lock and reference after * which point CPU access to the page will revoke the exclusive access. * + * Note: This function always operates on individual PTEs mapping individual + * pages. PMD-sized THPs are first remapped to be mapped by PTEs before the + * conversion happens on a single PTE corresponding to @addr. + * * Returns: pointer to mapped page on success, otherwise a negative error. */ struct page *make_device_exclusive(struct mm_struct *mm, unsigned long addr, -- Cheers, David / dhildenb