From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E82EC3DA6E for ; Wed, 3 Jan 2024 08:25:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0401F6B0333; Wed, 3 Jan 2024 03:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0B5B6B0334; Wed, 3 Jan 2024 03:25:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABC28D0031; Wed, 3 Jan 2024 03:25:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C40206B0333 for ; Wed, 3 Jan 2024 03:25:15 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9DF4D14026F for ; Wed, 3 Jan 2024 08:25:15 +0000 (UTC) X-FDA: 81637314990.11.E609055 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 964DD80012 for ; Wed, 3 Jan 2024 08:25:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704270314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVA2+5Zo1k3IRAhVtiQg2Y+PvqxXKewuXqwmNMA5CE4=; b=Sf9soCw5bkJOqW6IEC7ohiVEaP0HMdcWR1TbRRDwsSN1fdGMAGhzXidhebaqSmyFIEnhiE UvZ6InIdn8aQUuJ3vxScH5mfZudE+xR5jMlhNmr20l4uPGcEzQvUZ0N+o8+Msrj3KFSz+N 9ui2ZZYRp2166gTifqcQWfB1ZH3CiJA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704270314; a=rsa-sha256; cv=none; b=25gnDdIO0rzhYbcKKSI30Cw/qiqRfHKO2a++goyvAhHignIZ455ns4/eIgazjxvVb3q9fp LEYIfVbOVilE92IiLkbG+IbIhwQWqdZuQzr4VIoWN4tdKV3143pah5yLD2dBUCnZT2RIHJ hWv7C/OuT1m4T9J+o75lfu07KkAECBw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E006C15; Wed, 3 Jan 2024 00:25:58 -0800 (PST) Received: from [10.57.74.226] (unknown [10.57.74.226]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 400E63F5A1; Wed, 3 Jan 2024 00:25:09 -0800 (PST) Message-ID: <84b43094-9b16-40a5-94e8-6dd4e859a01f@arm.com> Date: Wed, 3 Jan 2024 08:24:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info To: William Kucharski , Barry Song <21cnbao@gmail.com> Cc: Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Alistair Popple , "linux-mm@kvack.org" References: <20240102153828.1002295-1-ryan.roberts@arm.com> <29007216-8A9B-4CA2-8A87-EB33E338CBA7@oracle.com> Content-Language: en-GB From: Ryan Roberts In-Reply-To: <29007216-8A9B-4CA2-8A87-EB33E338CBA7@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 964DD80012 X-Stat-Signature: gci5iyyc865h7w7qn5fr8ky1dfbf8syp X-HE-Tag: 1704270313-3276 X-HE-Meta: U2FsdGVkX19CFVxOgleBjQaZC6Z+jrCid+mcoHYYz+q8dXSFSUTOX5jCUop8B9Iy3Bem+QzmqeQ2UGvk0JhDb8LXtsjr+BlOW5URkTrtqsFnNGUvnP7KAW/wuiQMZdcGTo2ABhLwp2YcIFsUWGxDkEmWKO6REZenJxMnhW55kOKi8vjbXoSsN89muW6WfQV5Ucj9kBk1gv1B4UiYoRCanr/MXQIPhTKK0lunlgK01E2FtS/KKw26qe5DfH7M9nW7be4H563SQ3ha/5YCY/rhzdc50UlGQo13UlqXt9kgySuELutkKU70LygvlljgsuGNRWXPfG5PwCRypbboZmS6Tms078hAFH2hKL0Ayz+DMWP8BQfKhjn7S7zSlFhMAjFWoNV67JtbQIB3w1RVwB5FKwOoVvmvchaM0Cas6MlfsWEyYo03ja0tGP31Y3EjJPZf5Kc/XE4rn1s/erOfUWEAQjpf8pmpY00UnsTisCEQ6Zj0+VqYtkbnbKfO9L/2JYV8w7uVNJ70YJKGdc47LUOKGEUMtjks32kGXM51Fb5iInBaP1LtQYxAIIj4Tj19SK5gn9uPJtZmiaxAabBUhGzTa4NAtKcO+Zm1AHoox98EgQmi2ORE9mTVIQdO7N20b4bYSCu0Sjv9e6J4DFPM0SZNxr87m6+mzlb02GkRLO6kx9TgZZAjLOZgoy6/Bg9s5IiP+T1NlDmPNtBflAgFBKHlUPcjvuNCraMQNWKD3ejXjQueN361u+Pw1CAlJ9QUbOIE/ttPL3O66+XWqXyuoTsTk749gpbQ6C5AM53sPGtR3StTgloJpeYL8Eq3OGljQUyESRkWlZk9Glk7dhHQzU00hvpVUHtzlulQj00PHI7+s6TJb91EhaEINqRJBYux01L7+cV0p+7VAVXAcvJh3PBPhq7nGMAJNmo1spbIq2HDAye2FmmzYmuxz9PEQa6HIc4S1GQ1r2gXVd8q9+DNRBa GCUsqBLb LV5F46QlTxuZlKUAM/aYMQ0wfFEjPbHIaI9x02jqVnedkNyFgcLwFDM1CQSEQPbNMZUpSfwgYN70ICfsYGfvpCc8lndFtAIikeIy/i07vX4sbosc3wQ7+afnSH5UNwcFoAsq9p0iDMTqkUwF7fG/oHNzuc5nLcDhpFGeFRy+V4dJWuj5ddkTSh05OwLAXRZ2zdVKFiKWIESxOZKQHQfrSmZRtL0/vpi/pKvhJO7zO4JIpf9kQHjJbkQ3/3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/01/2024 08:07, William Kucharski wrote: > >> On Jan 2, 2024, at 23:44, Barry Song <21cnbao@gmail.com> wrote: >> >> Hi Ryan, >> >> I ran a couple of test cases with different parameters, it seems to >> work correctly. >> just i don't understand the below, what is the meaning of 000000ce at >> the beginning of >> each line? > > It's the pid; 0xce is the specified pid, 206. Yes indeed. I added the pid to the front for the case where you are using --cgroup without --summary; in that case, each vma will be printed for each pid in the cgroup and it seemed sensible to be able to see which pid each vma belonged to. > > Perhaps the pid should be printed in decimal? I thought about printing in decimal, but every other value in the vma is in hex without a leading "0x" (I'm trying to follow the smaps convention). So I thought it could be more confusing in decimal. I'm happy to change it to decimal if that's the preference though? Although I'd like to continue to present it in a fixed width field, padded with 0s on the left so that everything lines up. > > -- William Kucharski > >> /thpmaps --pid 206 --cont 64K >> 000000ce 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 >> 00426969 /root/a.out >> 000000ce 0000aaaadbb3f000-0000aaaadbb40000 r--p 0000f000 fe:00 >> 00426969 /root/a.out >> 000000ce 0000aaaadbb40000-0000aaaadbb41000 rw-p 00010000 fe:00 >> 00426969 /root/a.out >> 000000ce 0000ffff702c0000-0000ffffb02c0000 rw-p 00000000 00:00 00000000 >> anon-thp-aligned-64kB: 473920 kB (100%) >> anon-cont-aligned-64kB: 473920 kB (100%) >> 000000ce 0000ffffb02c0000-0000ffffb044c000 r-xp 00000000 fe:00 >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 >> 000000ce 0000ffffb044c000-0000ffffb045d000 ---p 0018c000 fe:00 >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 >> 000000ce 0000ffffb045d000-0000ffffb0460000 r--p 0018d000 fe:00 >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 >> 000000ce 0000ffffb0460000-0000ffffb0462000 rw-p 00190000 fe:00 >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 >> 000000ce 0000ffffb0462000-0000ffffb046f000 rw-p 00000000 00:00 00000000 >> 000000ce 0000ffffb0477000-0000ffffb049d000 r-xp 00000000 fe:00 >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 >> 000000ce 0000ffffb04b0000-0000ffffb04b2000 rw-p 00000000 00:00 00000000 >> 000000ce 0000ffffb04b2000-0000ffffb04b4000 r--p 00000000 00:00 00000000 [vvar] >> 000000ce 0000ffffb04b4000-0000ffffb04b5000 r-xp 00000000 00:00 00000000 [vdso] >> 000000ce 0000ffffb04b5000-0000ffffb04b7000 r--p 0002e000 fe:00 >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 >> 000000ce 0000ffffb04b7000-0000ffffb04b9000 rw-p 00030000 fe:00 >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 >> 000000ce 0000ffffdaba4000-0000ffffdabc5000 rw-p 00000000 00:00 00000000 [stack] >