From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2483DC02181 for ; Wed, 22 Jan 2025 11:19:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5203E6B0089; Wed, 22 Jan 2025 06:19:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CFBF6B008A; Wed, 22 Jan 2025 06:19:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 349D96B008C; Wed, 22 Jan 2025 06:19:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C6926B0089 for ; Wed, 22 Jan 2025 06:19:47 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 969B980889 for ; Wed, 22 Jan 2025 11:19:46 +0000 (UTC) X-FDA: 83034842772.06.9F28EE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 19EB88000A for ; Wed, 22 Jan 2025 11:19:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fEsmx9/9"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737544784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VO4NxuxMnjwsU/LY1YLY8S7j1PhjomQTPI5kHZH06GU=; b=wCgwhf9N3uJZvxXSZ/wBX7pQ4NZ16C/76LQk6wwlPEbsUEBX3FtsnhWjkoroGbzHb5+Mfc 8dF7DQOtp/kzTh6ty1CcxlLOt22aX9jaFoZt8ThxxO7+3nkH/raFO87JqeQpaY4JiS4hq2 bPWpIUAAwFrNSFmJtGvyFyC7pa9XTfo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="fEsmx9/9"; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737544784; a=rsa-sha256; cv=none; b=2Sp9lddbyDqGVbWc9b0KCMreUuYck80lKBwqAEoGse27PtNXGpYA4JqCgglPQ3QlmNRKbV KJqXMiksKXnaAKs3mz4DuyiltirNJOTsdlYxKSI8sLXlAyALqf0QFgNiWvqVxloGLpa3v5 GjgQlj8SUk45yBNShOeVQwkvwYHxkEA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737544783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VO4NxuxMnjwsU/LY1YLY8S7j1PhjomQTPI5kHZH06GU=; b=fEsmx9/9JeZ17XbdAK+JMAuuiq6rwqZ8P1i1MONEPqmY3ZPfAYq5HkQu9ZJ5jpbBpaTf+v 9Rf86g1jl0Ar8T086GCyK0WF8rhkJtREAJOH4FEGLkf11wZxXq7fALKGxnoxWzZrLSaFgl Qf3pBJoLYpcOIloGPCCcrGIC6FTFUPA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-JQa0N9GzPoee69T3xSbXtA-1; Wed, 22 Jan 2025 06:19:42 -0500 X-MC-Unique: JQa0N9GzPoee69T3xSbXtA-1 X-Mimecast-MFC-AGG-ID: JQa0N9GzPoee69T3xSbXtA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361efc9dc6so36673455e9.3 for ; Wed, 22 Jan 2025 03:19:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737544781; x=1738149581; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VO4NxuxMnjwsU/LY1YLY8S7j1PhjomQTPI5kHZH06GU=; b=PXXy+rFdwhNtO06lYdPfGM288twTMgEOwYZGh8QdzHVovZARScmYxTgQ8zMA/Ldw/H snZPPGXOKZVv14ukR8pxHPnrd+YpPe2VAMRFNdRQbCb403mUR+8arY9lKQqYycagy4NJ rTrin+AGK0m3FUxMvbRUKbRCqvrYwG10lbiZIEm6gA4KTekj8m82KS+vr3gpfUTEZLbT m9B2y07YA6Rutz68EYMU4GngIxjrEEsfrbPKsviFZRZZPhz4/vjyk88B2UujyUjqwK4b 0LajTL83/WxtiEGDNA5UJ0cVAkecARl7J77cPLXqhpQsWc00W5hP046D/Qtjh3aIeCcw FwRw== X-Forwarded-Encrypted: i=1; AJvYcCXjR0OgRbhX51PV4m/14hIOVlsXEXGusPxzujIW2dN8aHSBRR/5I10rWSe82ol6N+OODfwvVRMYLA==@kvack.org X-Gm-Message-State: AOJu0Ywz05C4LpoTcPcYhcqofR48yzGXPdUT7+tAOJZbLNbkj7CZcup0 FCsJH7yA5FIzW4WgbucYsmQLmck8JM/UGDKU6Cv1qN1ha6dZaC8r/BxlkaZ0Pn+B2gRjZtG9s6Y wcArXF4FYID+wllMyMHc9ToMmQZj4EsYZO3Ngo1Bl5wOsdGsa5oYccfRWggI= X-Gm-Gg: ASbGncvaZFJdAtx8Jgj+5uQV4Q1B/jYAHhCfjOtwNdhOoKBtR6jMQzoQLxfK2Fn7ZBx nzp0NUavO3NbrYi2w+NEIGhTbbSXToOFt7S17rHA2RnRcwLdXb17EVw2y/N1AU/B5DVwLHIDgGl kf3hQTBchF02XiqA8pS4+ZUvs0meCOseGpQvy+NMhEFsQZuQLHbrbIuWrCdey+pAItB5pisTouM 3P/3f+oZWoamdRznpN6B8d71YZiup3Jn6T/UdjGJdzFrH7z2Eq++GpRY7l/N5TJGjuVFKxI9C3f qvQQD6DmKRK2QoySuv2JVlVw/Z0S9ItcRAhmjO0c1W0vXoNxreVCu48rFePOnXK2Ntc4VihLsFg EuKJo2UDT5ztSb5b6RnfFIg== X-Received: by 2002:a05:600c:4e09:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-438913e99b0mr222364835e9.14.1737544780946; Wed, 22 Jan 2025 03:19:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFzwuqixIWif15892OqVasoESU1D/ZOPZRnbUaKTUhKTDoOnikaLUJ+L76U+4gmNk+/UBKJQ== X-Received: by 2002:a05:600c:4e09:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-438913e99b0mr222364535e9.14.1737544780621; Wed, 22 Jan 2025 03:19:40 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:db00:724d:8b0c:110e:3713? (p200300cbc70bdb00724d8b0c110e3713.dip0.t-ipconnect.de. [2003:cb:c70b:db00:724d:8b0c:110e:3713]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b1ce51a6sm20029755e9.1.2025.01.22.03.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 03:19:40 -0800 (PST) Message-ID: <84ae07bf-de57-4b66-bc18-c94727a92cfe@redhat.com> Date: Wed, 22 Jan 2025 12:19:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: gup: fix infinite loop within __get_longterm_locked To: "zhaoyang.huang" , Andrew Morton , Alistair Popple , John Hubbard , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, aijun.sun@unisoc.com References: <20250122012604.3654667-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250122012604.3654667-1-zhaoyang.huang@unisoc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Sf7hmkNOH8RMt5L7FiXpnZ_QQL8tTctWihrhv6bYVn8_1737544781 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 19EB88000A X-Stat-Signature: dp6f1mi71sm9d3ak75kf5anugdj669em X-Rspam-User: X-HE-Tag: 1737544783-562921 X-HE-Meta: U2FsdGVkX181FNNcO/My2ELnMs/jd9ZkwnZe32MzUE2fvbtVDxMrdsTTk23Ea+DUJawoHvwd9+0uewo1V0gOShG7HPIRm1JQE/HGmjecCDtss9UNAXrAxJSmP870tHpVfgJOw4+jAQyFxWpPFrwrRAY+W1mQT3s3rIjXSssbLaE2aNQja+Bz4wXrmtLkO21/Jhd2ydlltQYpOx0lS9XfaR7rhq5+V9eeAksGQgvs1YE4Ob/qbr5x2FdUhb5IxR43Ue3HlB3rZzphqYKeFNgvS1U7Eo+pIa0Y3gztaCsiaGENQxzxkHlqVueUYV4CGrLDyDJgSDG+BZNP+f4Mh3YrugzMBHr/bzSbeyO/LOG25PZQw2tw6b96Hol1w4kxbWyGhtwgYRC/GHgi6N3QUkLMOhwVPeG74ILfihGMJMBhbdb3WfQ5mIIKsPb4pKWBBX1TH3vz1N1D7iZTpUdcxEkI6ZSMq1DX68rxDhAlS9NRMHqJ3wsrPwD+r7p/L5agAC+o90QVNdaYMbGjJvF8e3O17BToZm0FgKZGLbxQYEpqrq1Nt+ydXY++tDWpEf0CEzAtDnNOAZfzP/SeoKqWmg/ObaU0CvNSxqKd182/KpmvvwdJhKXjSa7vHR21WZGgwLJ47IzZFVq6VyqmCT4TtOea/3x5tKacyxC8s0m27Lsy5EU1gHnGzLr4kqZRFaFOhKnkGblVwbo13dTd8IN7ox0+6KHZqxZ9c/KxHnwHeYl3h1HnAEZR2hBnolwqZKmUHW2vJwjqKc4OLV273zFhBmq1vgfxLF2YjZfzSsVwqntgaf0L7fOWn3dhaaszeOEu08TIFNGsX0dPs7+VhARbuRxPA5GVRFwcZyLbBDBiav/5QeHz/Q3QhlZc7fwOFduC5FqiNYTo0rAn/QywbGkiRCI51U4JC1XL/iSGfGA+Br+QOg5UzkJuq8RyOYYDcrJaIZVUhhQWZQJ0n+9vXMyhNxY lSG+01ty tFx8dbaaJKebYCCop/jC4N3BxbCFiruKfbRQAn1pnBn6MPmOSVYlpQ38oizHVAhble+S38Y2aHCqYGMMnypLgBbWRdbik+RDN4wZ7MGMLNfKiAxI+RKtFx5q0wXwgmPbypvUK/Jcz7CO/59TBWNkkgKtQBw6iap9X4J8ZxIsuxOMbaknYzTRGCDW3QBDtRzt9b3S1uat39otAD9ZkMVK8AZ5eUSmpZHhB0khMi8JytBC9iXuAqesImLs9/dzzFI+S9hnv0R7evAcugUXghsP3zuA6Oay1LU7BN9HoG/AnbfgUxjrlgFRyRLd6dN2md1mx9gS5pmpi8PfZvsgnuk28jKogYgDYMHWFgzirnkk2YE8NxDpDS6rGaAFOQnFgoJ7np97ZOpyPNsPPUIreERkiaiqm3XGJUwPMW53/AozZaMd3SgGa6ct/V894c/7YNgYOxg/GjpJwjlja89s+FjYUm027tKM8ETXkEAcMq6HBk7tDfl6LSn25YaJdpR5CmD8ouoCCqPL1V+XyhSVFmdO4ufsABBYaK8bqyVOmm+1V68IPcIs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.01.25 02:26, zhaoyang.huang wrote: > From: Zhaoyang Huang > > We can run into an infinite loop in __get_longterm_locked() when > collect_longterm_unpinnable_folios() finds only folios that are isolated > from the LRU or were never added to the LRU. This can happen when all > folios to be pinned are never added to the LRU, for example when > vm_ops->fault allocated pages using cma_alloc() and never added them to > the LRU. > > Fix it by simply taking a look at the list in the single caller, to see > if anything was added. > > Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > > Reviewed-by: John Hubbard > Suggested-by: David Hildenbrand ^ you should CC all people here. "git send-email" will usually try doing that automatically. :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb