From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D22FC54798 for ; Tue, 5 Mar 2024 09:40:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1B106B008C; Tue, 5 Mar 2024 04:40:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC95E6B0092; Tue, 5 Mar 2024 04:40:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6A9F6B0093; Tue, 5 Mar 2024 04:40:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8BABB6B008C for ; Tue, 5 Mar 2024 04:40:46 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9EDC8140DA6 for ; Tue, 5 Mar 2024 09:40:45 +0000 (UTC) X-FDA: 81862490850.29.B7A142C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id BC8A2160003 for ; Tue, 5 Mar 2024 09:40:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YVHopXWy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709631643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lsD3iFmjG4YWgMgCa0qF0PcFuMKNa1xhP5HC+b5AB/0=; b=M/1/chwLOaKQUONOYDs+M5Qn8DcBo5YLJCyFDV9tbqqimw4DmCEkycELXrg2xWpQhIJ18j d6+HaaPpNYXlGpq3zYgYozjsyu8Xw/Tk1MFapHZv1i8Wef6nuULbxob62c3guUiNoWo6Cl dGwcgy1FwJ3Y0bxtPLGJn9PQ+D1BZcw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YVHopXWy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709631643; a=rsa-sha256; cv=none; b=gDNQ4FOWUk58eDzzurAT/eEsikj7v0b/IOzwEaGI9l1g4lRvlI8waQzmHo+gHmZZ7EQDjs gaJGBLdUFu0Z7Dv/Hzf8OQmOqA2VvNQuHsqPkT93MXtk04M3ZIJYR3uL+iWNPivfZNnuwf 2ob41H/CTrUGUUf6jxp2MNlG0GewFFY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709631643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lsD3iFmjG4YWgMgCa0qF0PcFuMKNa1xhP5HC+b5AB/0=; b=YVHopXWyipCAdj8PnbQexR4N33PMToHpQX+TFFq+NgriNupCOQeHiguQm0kGIplQyXPguN Md4q2n0FXxv6fE/tqrqePMackWk6HOUNbIEvu7Da2hK8k6AuJmDSrb/PAKlAEJJykakaxy cxxVO+i4hpPUnjebUmW9IzPyQfb4fks= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-XHy8K1uCPhmNrVAbcLFjGw-1; Tue, 05 Mar 2024 04:40:38 -0500 X-MC-Unique: XHy8K1uCPhmNrVAbcLFjGw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB2D0803F52; Tue, 5 Mar 2024 09:34:26 +0000 (UTC) Received: from file1-rdu.file-001.prod.rdu2.dc.redhat.com (unknown [10.11.5.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA34E200AEA0; Tue, 5 Mar 2024 09:34:26 +0000 (UTC) Received: by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix, from userid 12668) id A238C30C1B93; Tue, 5 Mar 2024 09:34:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix) with ESMTP id 9D3053FB51; Tue, 5 Mar 2024 10:34:26 +0100 (CET) Date: Tue, 5 Mar 2024 10:34:26 +0100 (CET) From: Mikulas Patocka To: Christian Brauner cc: Hugh Dickins , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR In-Reply-To: <20240305-abgas-tierzucht-1c60219b7839@brauner> Message-ID: <84acfa88-816f-50d7-50a2-92ea7a7db42@redhat.com> References: <20240305-abgas-tierzucht-1c60219b7839@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspamd-Queue-Id: BC8A2160003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 47q7p9eq1u7ojtxqkgifxseuxs5rjuam X-HE-Tag: 1709631643-142685 X-HE-Meta: U2FsdGVkX18vOuS1aktiJ9vjpKJUqL1rTka1SSW7VeE33Z1DBsiXWT6ZFWMxPJCOzd/fScMxHgVQln0xjFA670B70fkkkzz0WXCVHgZCEeZVS39KeT6+M5jdpjLrcTNa8m7sSZ5iKlIiFzrLi7U7xv9tzvTHHCbN/RyghMRHXTVRRbRt4+AQMF3GZ9oBjN3AJ9yRhG9Aul88BbMkhUXQrn8V5iORSRvJn2yKKxBjrMRSdfq8+bM/F/uHJ+84CXKHj54ubaLbfq5gKLdKcKb87YHZz8tL+s4vuwUoALg7+3TSjEeNF/a7bldkr2bqxtXm5Xl2HzWYwe2IFCwTC4omc73VxWZAs6DxG4jRmJwtBqG59oWUiwB5yXBb9GCA/6Gjw+ycSyjBsPHfUj90JgFzJeRmke7XoylMBue7sCMMG8H925317s0N+LhgWiQHS10cWlHc7QZgcOgK5GdAasu/QvRanNUmb+qO+Od5lsOelWU1sQ0CWYbepcA+wmA/e6XSO8uBpy0HDNi9h+w4aQaNGj2lIyMm70hAT2fDCvtgHaYF+ihT0aUjbZRq8a+1+eaVbBZ44MYVzyp3bsGb2szc0uQWmHj7cCgh+KjkoOvXlJF1pmu2eUwkSXWbHUgqlhVUOwPq2aX+za0C7Gmu0uHLKjSmKcmmu1u25yd3RtHrrZbhyZT802qAQ7CXN6a3EQsayDo9fqI+fpnAUnCquDK1lbbvG5BpONIWv+fHo0d8qpiFR03n9mkSL41lXkJyvan2tOSSr9cfmyU6e7Dj/0X0c2XDwQXFuwx9eTl3eO/Ed5rWHTZUqti51FrMIAnlUFoktjjyBGWDghnmbqIxInGI/PPQpW9DOXZWcWnDTSlEObd1AW+W6HFic+D0550rUgm6SsZA/ILgvw508zujLFU3+LLk0jaOHp/NvIysrTncc6hGyFPEZhSYdsCWkyBceOdGLqfgkzsntB2nIwB7f5G jLBzyIPi E5XidYp/53AVYPOy1RgTsiq/SrgnPuRo7/5V6fFW/erUA9QfE3kjjLFdz3G8eB7S9VAg9kZ696qrMzeZYImJ1QCsxqiSP1qxDxEhpig1p3wfqBZDqMTqpv8vZReuoIr+gginlxdpg1L2ZjGYfhHBGIX47R3h9f1aw3JQn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 5 Mar 2024, Christian Brauner wrote: > On Mon, Mar 04, 2024 at 07:43:39PM +0100, Mikulas Patocka wrote: > > > > Index: linux-2.6/mm/shmem.c > > =================================================================== > > --- linux-2.6.orig/mm/shmem.c 2024-01-18 19:18:31.000000000 +0100 > > +++ linux-2.6/mm/shmem.c 2024-03-04 19:05:25.000000000 +0100 > > @@ -3143,7 +3143,7 @@ static long shmem_fallocate(struct file > > * Good, the fallocate(2) manpage permits EINTR: we may have > > * been interrupted because we are using up too much memory. > > */ > > - if (signal_pending(current)) > > + if (fatal_signal_pending(current)) > > I think that's likely wrong and probably would cause regressions as > there may be users relying on this? ext4 fallocate doesn't return -EINTR. So, userspace code can't rely on it. Mikulas