From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6547C67861 for ; Fri, 5 Apr 2024 18:50:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0016F6B0089; Fri, 5 Apr 2024 14:50:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF41A6B008A; Fri, 5 Apr 2024 14:50:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC9D6B008C; Fri, 5 Apr 2024 14:50:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BD4546B0089 for ; Fri, 5 Apr 2024 14:50:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 76343C0F9C for ; Fri, 5 Apr 2024 18:50:47 +0000 (UTC) X-FDA: 81976369734.15.9B6A5DC Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf26.hostedemail.com (Postfix) with ESMTP id 79F48140020 for ; Fri, 5 Apr 2024 18:50:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=IDbjtCeJ; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712343045; a=rsa-sha256; cv=none; b=8MC1ywu2ukV37KXlRbHmRhYXLtfx8pgM2BU1u9eaOcX/N4GFQHGmmA47zz2pF2ImWxSiZh XO5RfrmED3n/s2PNjMOZngfldRVwzE0e7wrJzuwNcK/jR3PVJpvyT6v4UjfdUMyVKtUp4t PmHdCT/Wyn+sCU0rm2YZsp/8up/JduA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=IDbjtCeJ; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf26.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712343045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vp44i9Xlfeu0O10COsw98V/v7e0jo8kvUbsVGI+1kuo=; b=MWQlEucz/s6oOplRgMuDPtb/tRILVoE8iVVOsWYSj57rwbm5HvXMX5IAaeAqzp0KuB1YcJ nN9kZLCWL3csjBeO9TWnB/nLpvpsinvTMBc9QF4n0NeC/JkjzpG47K3xIZMHFPDTA+08te HpT6RaEht4JEShAWUVkXs9RBtksuJo8= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-36a125869ddso891525ab.0 for ; Fri, 05 Apr 2024 11:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712343038; x=1712947838; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vp44i9Xlfeu0O10COsw98V/v7e0jo8kvUbsVGI+1kuo=; b=IDbjtCeJWIWf+i/BxCNFEEbe4d3Yo8jJ2YwmZlLZ/EUCQTsVtD2jU5yJN0HoS3Qrrb BWSnS4tzQ9QqsYCeVjYXTnsSBlgvMFzp7//ewC1UNHYSeYFQa/v3y+GVwI1N1wd4Guw1 vgkfcdym+Etc7FfYZqnq8TnGXQizD+i8XrA4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712343038; x=1712947838; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vp44i9Xlfeu0O10COsw98V/v7e0jo8kvUbsVGI+1kuo=; b=HI6aNqbpn9QRdbDSvfIF1bqXzN6r2Y+iLn/aSmixVQDfU5XE2mRJD1JOT7VoLWJC1c dp61n/bzHzqQYSwQAKACExxCsNrpsma4Z9cC5P9xRMXkDmneKBGoTVolIQQpa7Aw8e5q WoK8XMHG6z1izeEwb7uOGcCLmW+dzSdNDARQ6SyrjmuGYbJMRJ3yOxvt3/Kq38QHUUss GhMILhP/UtnhqlYP1l7g/RSJDi10WaStxIBE8GI7ekvB7uUDTrvrFczHen/JG7938Ly9 Qita8D/MjdhIkH58swYuHWIirqoy1wJy+J+NVzwCnavgmRkHSChU7cSZ4C/q/ARxVA24 pLTQ== X-Forwarded-Encrypted: i=1; AJvYcCXyXL6xgwPVnUK0ltbMbKuu2Mjr9nwHzg+JhvwShnhHNWFgf9/INPg0N0ULc/4rbo9th9lNMa4YoSr8JUDxwSOFhw4= X-Gm-Message-State: AOJu0YypPKRk0tSxualR68hX1Mdlg0QId/0fOMHoFgTjhWOgw9gNR9tT TOx+ePYS8Jza55g0jALyT+z4+jtDJi4x9Dbcc6khQ5ba0X4dkedulpCWGgSjvHc= X-Google-Smtp-Source: AGHT+IGnMS2NKy+1HVwAPdxdmucJAIWJJEZlmMEtziDgLQxVglpyFfMG5GBRQy0N2McwE23OjduKXA== X-Received: by 2002:a6b:ec05:0:b0:7d5:bfd3:7237 with SMTP id c5-20020a6bec05000000b007d5bfd37237mr2288245ioh.0.1712343038341; Fri, 05 Apr 2024 11:50:38 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id x26-20020a02971a000000b0047ec2b62deasm724949jai.91.2024.04.05.11.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 11:50:37 -0700 (PDT) Message-ID: <84acaa6b-44b6-495a-939f-4a6e49e162c9@linuxfoundation.org> Date: Fri, 5 Apr 2024 12:50:37 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() To: Kees Cook , Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Shuah Khan References: <20240405131748.1582646-1-usama.anjum@collabora.com> <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> <202404050832.187F972C@keescook> Content-Language: en-US From: Shuah Khan In-Reply-To: <202404050832.187F972C@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 79F48140020 X-Stat-Signature: hp7utxofzghba9r491x6xg5yoid9kuat X-HE-Tag: 1712343045-638913 X-HE-Meta: U2FsdGVkX182W7CrdhJUBBfDeR28DDKk1iidIo96i04slo6IeWHCyRW5CuwXKFMtJ9j10AzsEDkXF266NAICZewI7rx8sinDxkdj1ilUrkzyL+CVrZ8JrPFQVYHKv/oJnrOYAZWwJsLq+xOV4qY8G+p+So2NbiLBFY3l+bWPDgvjPFethBJAnNtISEkoQ+BkSbr+bNpwMOs7BiXQ9bR/eAPnCQGnXSmLHRgOwIG+4+QwlmCgUZef2VHfPf8u9G81Le1dByvNPGtbMmmiHePVGvRg/BfArJ9budmTGW4I4+6w1RJP6kGpHyJwxaIrzbEAvvp3IyGlxo35bpeeVqrEzmIdR+9swBpmIo1392alShMsiUOqW7bYhol+VuoxmLBjQMuBbNPpg3W23gaoauA190+DfYCYAFzrSsEbgyOWhVaiVJDAsvQLoRAG1ihDuZR5kZwErdhemVZ6RESnPUKg7bN4ZUxVbS9ij0vwjIHHY6/zPKDXyTjVklv1/oQqlaWaS+oJ6LWAwA1n31WI2hyHDATzJA1bybb1ehgtVwShGm10ZK1DWE3HEh3zbvVRnxvO3eEX0okeCa4YPWbNAN9T/8Zy8BhVn//P5NAf3mU9b+gXpgzwYt/J+YjAUzjHvpg9o/nYkzefqAVoiAGjaHuir3pb0lWVtNnaUQL/5xEQFLHc+9S4JNMnBz2xxVTGBJFI4qloEYjjgemas9N9b0W7uyUiIoiGgpWBScWqFeHTaVjl68df3bUeaz2U46b69IwHFTFS0ktwQ8cVbLXhjvD5D0jbEwQPvFgLE9wCviU2eEX/oS/Fat1W2cjS8tA/R1QXL65fme1bNVtThx0FS5BTIy8xC1eMZtMPX4RgP1eLQFS8NWavqoMyYsdPWYZe1YR8V4E6P45m7ugjyvWmpkhDr8hhNRuYhYAJVqqKQNQks/tc2IuDZYO2Lcg5jT54dj9sFaacOApEuxz41JMy5Nk Kf5ASJi4 Vx0hfeXGt5DuvPKUwyRhXGBvj750FfsnVOUkXdeuaE3ZUdsHuAZr+K5jZ/nJZp3kThV2KvZP5RUEMrpOKknrv4KVs/NS1khRNOOZEr+Fe2Opn87arQjlP/4DD5b+I04oRK48bTXbdRMMPZ5ygq/XiJ0gFoI8ShCW8Ruk1eeNTMnkzVdLKYiIderq/5LgusIOvrP0zjx4mX4HMpMNBX2jgFPVaeUenEKHIkg0GSgJ/2TzY1o4YJG0aqk1W/+QYkarHPlzW0c7u7xajeOCuyUWbYV5AERJKB+OXBYBmBZTNeN+iOkFCpmQokfAT8EtSUmguxaA+HnpSeQxaHbOCC8DCKTQyqmJMHyHvpqilVnstz3aXAvvMdF3fb+kMxZULjvAjiluMwHV+6guyNubKI6Or4OdfaVyowzw0Pi83hrPJZ/Rf0wCMwVd0BNs+9rmTtiTX+W4J5oawWIcKU/xgnlhspyJ7GQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/5/24 09:32, Kees Cook wrote: > On Fri, Apr 05, 2024 at 08:56:31AM -0600, Shuah Khan wrote: >> On 4/5/24 07:17, Muhammad Usama Anjum wrote: >>> "Bail out! " is not descriptive. It rather should be: "Failed: " and >>> then this added prefix doesn't need to be added everywhere. Usually in >>> the logs, we are searching for "Failed" or "Error" instead of "Bail >>> out" so it must be replace. >>> >>> Remove Error/Failed prefixes from all usages as well. >>> >>> Muhammad Usama Anjum (2): >>> selftests: Replace "Bail out" with "Error" >>> selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages >>> >>> tools/testing/selftests/exec/load_address.c | 8 +- >>> .../testing/selftests/exec/recursion-depth.c | 10 +- >>> tools/testing/selftests/kselftest.h | 2 +- >>> .../selftests/mm/map_fixed_noreplace.c | 24 +-- >>> tools/testing/selftests/mm/map_populate.c | 2 +- >>> tools/testing/selftests/mm/mremap_dontunmap.c | 2 +- >>> tools/testing/selftests/mm/pagemap_ioctl.c | 166 +++++++++--------- >>> .../selftests/mm/split_huge_page_test.c | 2 +- >>> 8 files changed, 108 insertions(+), 108 deletions(-) >>> >> Usama, Please generate separate patches for each test (one for exec and one for mm) when you do this kind of work across tests in the future. I applied them this time. >> Andrew, Kees, >> >> I will apply these to linux-kselftest next as a series since these >> changes depend on change to tools/testing/selftests/kselftest.h >> and need to go together. >> >> Are you okay with that? > > Sounds good! > Thank you. Applied to linux-kselftest next for Linux 6.10-rc1. thanks, -- Shuah