From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2FCC433EF for ; Mon, 7 Mar 2022 08:25:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6725E8D0003; Mon, 7 Mar 2022 03:25:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 622CD8D0001; Mon, 7 Mar 2022 03:25:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EB448D0003; Mon, 7 Mar 2022 03:25:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 402608D0001 for ; Mon, 7 Mar 2022 03:25:06 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E133D1828BEF1 for ; Mon, 7 Mar 2022 08:25:05 +0000 (UTC) X-FDA: 79216904970.27.7974B4A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 56BBBC0004 for ; Mon, 7 Mar 2022 08:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646641504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jp8xbJXc3F2xf0wOHHnbLnk2PeJF6d1Q4COXVNu7Rm8=; b=BJCZ0mLoUxI43MDGMVPjPT1eFXQH/bPtcIdDz221o9JLRXxfN7punPRx59NKsdjaO1BW/M v/Vmz7XCcOFm41tAen+f8pnrMhVhyBDcz+gyFD67AKcKoVDswhuWeqGpz5ueyRfU2QtQNi +QM7d/CzH8tStQbanSELEgGXpgn8I7w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-G1k8GXDPMCKmDg3vRZY-sg-1; Mon, 07 Mar 2022 03:25:01 -0500 X-MC-Unique: G1k8GXDPMCKmDg3vRZY-sg-1 Received: by mail-wr1-f69.google.com with SMTP id x15-20020a5d6b4f000000b001ee6c0aa287so4261324wrw.9 for ; Mon, 07 Mar 2022 00:25:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=Jp8xbJXc3F2xf0wOHHnbLnk2PeJF6d1Q4COXVNu7Rm8=; b=l34LwYTMRfKmyRvegeKKtLi643WqEOoHND/lfPPjlNPHcGz2OnqDxmA1WSba54c5wC GfXA2piIQoyiaH5M48xXyJbe0NWFker/ajN5d8k1ViGHh9vxAg7+YHLhjGCpb7ftdKEH QjIUeg+xdtfvFqiKCvXNUdtbvhFzy9YGi+KMiRy5Zbe757Yl6STFkrw05QoJaHBbRSjP xGNFVA41OSrX6Tpqb9GpYw7TRRXj46RovW7eYnEeCHJWv2sBZUczGMHrqFKELaMvN/sB cq7hj1CpppZVJV8zgIZeGlhTt+Qsz5dRsWF0+rO13ZDSNUCGl6c4h8ZRjJg+vO7kMCU9 ZytA== X-Gm-Message-State: AOAM532sJaKNmbEkZUddnU0/mbvfoEuSRhwpbssOz2k7mKlLHBaAF/1V xtGnXa6X6pn/QpqsGdIKa4hPyx3W8qsDY+ZHndLbmPXmmQjJb0mc1QMUzEaTohnP9FyKLalx1xu BBSRlQv7xi0o= X-Received: by 2002:a5d:4992:0:b0:1f0:68bd:4c34 with SMTP id r18-20020a5d4992000000b001f068bd4c34mr7633603wrq.670.1646641500044; Mon, 07 Mar 2022 00:25:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXMKXq8Pic3/bEs4X9zXY/UJ/munTO9d4a7KdGL1+a0vKhRumDwQZuZusyk2ldq7j4udF4mA== X-Received: by 2002:a5d:4992:0:b0:1f0:68bd:4c34 with SMTP id r18-20020a5d4992000000b001f068bd4c34mr7633589wrq.670.1646641499742; Mon, 07 Mar 2022 00:24:59 -0800 (PST) Received: from ?IPV6:2003:cb:c705:1e00:8d67:f75a:a8ae:dc02? (p200300cbc7051e008d67f75aa8aedc02.dip0.t-ipconnect.de. [2003:cb:c705:1e00:8d67:f75a:a8ae:dc02]) by smtp.gmail.com with ESMTPSA id f186-20020a1c38c3000000b00382a9b91515sm16784987wma.37.2022.03.07.00.24.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 00:24:59 -0800 (PST) Message-ID: <84a6c9c1-d18f-6955-2666-0a2d7bce6094@redhat.com> Date: Mon, 7 Mar 2022 09:24:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Andrew Morton Cc: Yang Shi , Andrea Arcangeli , Hugh Dickins , "Kirill A. Shutemov" , Linux Kernel Mailing List , Linux MM , Matthew Wilcox References: <20220303222014.517033-1-shy828301@gmail.com> <13ad4ba1-2a88-9459-3995-70af36aba33e@redhat.com> <20220306180718.6d4e6233130b94fdad98df88@linux-foundation.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] mm: thp: don't have to lock page anymore when splitting PMD In-Reply-To: <20220306180718.6d4e6233130b94fdad98df88@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 56BBBC0004 X-Stat-Signature: w64he8otrwbj8dod6oez7iifb1fgodfe Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BJCZ0mLo; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646641505-207684 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.03.22 03:07, Andrew Morton wrote: > On Fri, 4 Mar 2022 19:50:08 +0100 David Hildenbrand wrote: > >> @Andrew, the last mail I received was >> >> + mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch >> added to -mm tree >> >> The patch shows up in mmotm as >> >> #[merged]mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch >> >> ... which shouldn't be true. > > I guess I mislabelled the reason for dropping it. Should have been to-be-updated, > due to https://lkml.kernel.org/r/CAHbLzkpbnQyHRckoRtbZoaLvANu92MY4kEsbKudaQ8MDUA3nVg@mail.gmail.com > Let me clarify. 1. I sent [1] (9 patches) 2. You queued the 9 patches E.g., in "mmotm 2022-02-15-20-22 uploaded" * mm-optimize-do_wp_page-for-exclusive-pages-in-the-swapcache.patch * mm-optimize-do_wp_page-for-fresh-pages-in-local-lru-pagevecs.patch * mm-slightly-clarify-ksm-logic-in-do_swap_page.patch * mm-streamline-cow-logic-in-do_swap_page.patch * mm-huge_memory-streamline-cow-logic-in-do_huge_pmd_wp_page.patch * mm-khugepaged-remove-reuse_swap_page-usage.patch * mm-swapfile-remove-stale-reuse_swap_page.patch * mm-huge_memory-remove-stale-page_trans_huge_mapcount.patch * mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch 3. The last patch in the series was dropped. What remains are 8 patches. E.g., in "mmotm 2022-02-24-22-38 uploaded" * mm-optimize-do_wp_page-for-exclusive-pages-in-the-swapcache.patch * mm-optimize-do_wp_page-for-fresh-pages-in-local-lru-pagevecs.patch * mm-slightly-clarify-ksm-logic-in-do_swap_page.patch * mm-streamline-cow-logic-in-do_swap_page.patch * mm-huge_memory-streamline-cow-logic-in-do_huge_pmd_wp_page.patch * mm-khugepaged-remove-reuse_swap_page-usage.patch * mm-swapfile-remove-stale-reuse_swap_page.patch * mm-huge_memory-remove-stale-page_trans_huge_mapcount.patch 4. Yang Shi sent his patch (the one we're replying to) 5. You picked his patch and dropped it again due to [2] I'm wondering why 3 happened and why https://www.ozlabs.org/~akpm/mmotm/series contains: mm-optimize-do_wp_page-for-exclusive-pages-in-the-swapcache.patch mm-optimize-do_wp_page-for-fresh-pages-in-local-lru-pagevecs.patch mm-slightly-clarify-ksm-logic-in-do_swap_page.patch mm-streamline-cow-logic-in-do_swap_page.patch mm-huge_memory-streamline-cow-logic-in-do_huge_pmd_wp_page.patch mm-khugepaged-remove-reuse_swap_page-usage.patch mm-swapfile-remove-stale-reuse_swap_page.patch mm-huge_memory-remove-stale-page_trans_huge_mapcount.patch ... #[merged]mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch [1] https://lore.kernel.org/linux-mm/20220131162940.210846-1-david@redhat.com/ [2] https://lkml.kernel.org/r/CAHbLzkpbnQyHRckoRtbZoaLvANu92MY4kEsbKudaQ8MDUA3nVg@mail.gmail.com -- Thanks, David / dhildenb