From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4213C25B76 for ; Wed, 5 Jun 2024 06:15:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AF3F6B008C; Wed, 5 Jun 2024 02:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45D7F6B0092; Wed, 5 Jun 2024 02:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34D806B0093; Wed, 5 Jun 2024 02:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 182716B008C for ; Wed, 5 Jun 2024 02:15:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F5A4120E9D for ; Wed, 5 Jun 2024 06:15:23 +0000 (UTC) X-FDA: 82195822926.22.17C76FE Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf27.hostedemail.com (Postfix) with ESMTP id DC7FC40018 for ; Wed, 5 Jun 2024 06:15:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717568121; a=rsa-sha256; cv=none; b=Ys5pdSxRjAvj1sIdko4XBvPV3H8iSO3V46+cEy+jEDAkAU5IihL4hejk4FM65Akme1xcJw U/5J3TRvlWHXGf/xBHcxm4NSsVwzmxVM9ETP4TERhDK4Urmrmi8nBCs8rtLuzM45SjbHJ0 dgN3ghQlmOAI59fWrmK3ybRefTznpOE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717568121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jl7UQKvoZFJEtti75pILuMfUAnSIVBH5Iu9jEF31Xlo=; b=XgtBfNUmXM+LCYB9vQDQo20FIwU/QQOdGkIQbm5ANEEvMA9qI5xpQCSFvyO+ClmsWtkZld ZoCmqGhlr0+6pK2vsRWDNyDc0omLu06vkOJ1wK8S6VPVnt9QpsTV3OZvn66vwZ3ysEvsJA OqOrDSv+3iCs3UvZt9jZCTo6kyN6VGI= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4VvHCn6NvWz1S63h; Wed, 5 Jun 2024 14:11:33 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 74C6C1A0188; Wed, 5 Jun 2024 14:15:15 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Jun 2024 14:15:15 +0800 Message-ID: <84a65024-d96c-3fa5-c015-98130ee82ccb@huawei.com> Date: Wed, 5 Jun 2024 14:15:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template Content-Language: en-US To: Dan Carpenter , , , CC: , , , References: <87bca9ca-0c3e-449a-b121-eee7b84dc2ed@moroto.mountain> From: xiujianfeng In-Reply-To: <87bca9ca-0c3e-449a-b121-eee7b84dc2ed@moroto.mountain> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Queue-Id: DC7FC40018 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: em7xe5teaup9ne3apyirsqjj6jnpxpho X-HE-Tag: 1717568119-19693 X-HE-Meta: U2FsdGVkX1/yFIuxlZe38WScGD3tYSZjF01HogDqsRD/MRuHOTkOzllq5amuIuSg84g2aRo6XbxHW9515ZXJf1wvOuZrUGl7RxbHYSlDfd7PgjfZiVQ+bPfo1bDQ681xnIp3rwMk2MX12e+k99GhEl9x1ZdOr3RB7l2WWwHoH/kiqiq0ZprfoCGqSi2jLIGHNdVMVxv2XXnHVf/K7jbK6EXgfZaGOVhNhPEV50UDl3/OavwHl4/kuSyFMCRWbhPn4zxPUhnuBrixllXATlXX99il7SMclTUPJP9iW/Oz73TQO6r6lgPRoG1I+Ro94OSBQTYVfc5BNZoTvZP9Mn9ypSMbH9UPbfuPOHu984swX0QKhPtWqTHUw0/QvOUd2dh0mddA5DHEiqkGK1isD+sSrOjsSn6jlUYIKK8uzmLhNt9td2Cv6ur2fNXl3KsifsyPCuD+bjdCWEXD69am2j1/sPMjo2iY1nS6q0CypVgzKalH+NOUs9ijeCgQ8VSqmg/GOAUHDncPUn6bf0Y1sqV1n1xpnaCvhIWgogHfpO3+2KTU2CbjBsfr/56sC+TYWu0l9Y6aUrhduSovSejAQ03d70ZsH/5YPp7r8guo+MsUyPGj+/OlpnrVkBEYc50KedfSx84unB762swYtmou1ypP5ESBdKRtg7xxhyrG6fWPPC51G0DnLmHwkid6qz9JIAYgEYWR8NDFPCX5kA+R34PGleX1jik0apBbwaWJAue/tHevvtu1F9S6yILcWKVi0W2wb+nkT3U7urmy3LrxpAedSldSrjXRGQrUzFOQx9ULnnux17aZb5xYCn6jxwzNDEzBHrUBaEeVq6w2ILyUO4BgmTYKDoYXjkwMsy6TZJCgCdSBgCpfWrKqXZ2yYkkzFVX1WKPyz+offGB7/eHPFpC8Hz+lVoc8OwWwWf+90tV3NwieyxCXA16JllrwuhmgUwSIIWkf5B2sSPZd5tltu66 1s9M8Ybu 0iXkAxwTsWDCeVcsdHEZdsNAnX2qmjf4SbZxTjYMjjctANXPc6M9xNGY/zkNIljRiW5DJ+PKhOy/laBIXHX1wORYVVzbTdBi2SWa6gRBBRI7oK4zMDPfzoghD/o/ku9wZy6Z36nuHJfc/kWwDSCYhdPEafZ810dXrD7CqbEbSXE3rXvRo42SCTUEljuGh5oYs7jD+PllxhKvuGNLMKHrJYhalcTct+1pBnvg/Ky7+Mp731I5iEGIw/ywV9SWeeHYJNfIdGYoLYtsZLYTXhEbiTjsM6gf/e+vTmbqZWNuph00achcWFwfyc1sMMDw89Adkd31snXOFIMQc1Kp88m3+iVF7+GAJOFcsd4LvRUrxgQI2c/9aoR3h+9feUXD3peDlbpELKaFS6q2cZqu3trgxoMIFJy3xgH3nGUBLYfQC2Prtgpw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/5 13:24, Dan Carpenter wrote: > Hi Xiu, > > kernel test robot noticed the following build warnings: > > url: https://github.com/intel-lab-lkp/linux/commits/Xiu-Jianfeng/mm-hugetlb_cgroup-identify-the-legacy-using-cgroup_subsys_on_dfl/20240603-201513 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20240603120506.1837322-3-xiujianfeng%40huawei.com > patch subject: [PATCH -next 2/3] mm/hugetlb_cgroup: prepare cftypes based on template > config: i386-randconfig-r071-20240604 (https://download.01.org/0day-ci/archive/20240605/202406050210.OWthxCFt-lkp@intel.com/config) > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202406050210.OWthxCFt-lkp@intel.com/ > > smatch warnings: > mm/hugetlb_cgroup.c:828 hugetlb_cgroup_cfttypes_init() warn: this array is probably non-NULL. 'tmpl->name' > > vim +828 mm/hugetlb_cgroup.c > > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 815 static void __init > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 816 hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 817 struct cftype *tmpl, int tmpl_size) > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 818 { > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 819 char buf[32]; > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 820 int i, idx = hstate_index(h); > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 821 > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 822 /* format the size */ > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 823 mem_fmt(buf, sizeof(buf), huge_page_size(h)); > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 824 > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 825 for (i = 0; i < tmpl_size; cft++, tmpl++, i++) { > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 826 *cft = *tmpl; > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 827 /* rebuild the name */ > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 @828 if (tmpl->name) > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 829 snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name); > > tmpl->name is an array so it's non-NULL. Just do the snprintf(). No > need for the if statement. Hi Dan, Thanks for you review, will fix in the next version. > > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 830 /* rebuild the private */ > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 831 if (tmpl->private) > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 832 cft->private = MEMFILE_PRIVATE(idx, tmpl->private); > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 833 /* rebuild the file_offset */ > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 834 if (tmpl->file_offset) { > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 835 unsigned int offset = tmpl->file_offset; > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 836 > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 837 cft->file_offset = MEMFILE_OFFSET0(offset) + > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 838 MEMFILE_FIELD_SIZE(offset) * idx; > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 839 } > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 840 } > 66bcc9ace99241 Xiu Jianfeng 2024-06-03 841 } >