From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74585D11708 for ; Fri, 25 Oct 2024 07:06:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC5AB6B0082; Fri, 25 Oct 2024 03:06:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E76066B0083; Fri, 25 Oct 2024 03:06:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEEA26B0085; Fri, 25 Oct 2024 03:06:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4CF46B0082 for ; Fri, 25 Oct 2024 03:06:21 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 180FAA064C for ; Fri, 25 Oct 2024 07:05:46 +0000 (UTC) X-FDA: 82711239618.17.DC82C61 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id DBFFE20016 for ; Fri, 25 Oct 2024 07:05:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HzSABeMS; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Qz03ClBN; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729839925; a=rsa-sha256; cv=pass; b=Pptdz940sxCZ9Uop5P1bBoucIH9b0j4BOm11JQLZDLLV/p67N80bKnqX5KzZVZvvrj8Lfz fYAqIAlLBEkLoi2y0POmLrHFakFYQ/b7JkRe6UaTUii0VzkKkQCouvpJhNLafPI4jwAbnD xK5bGwoZ/T28o8/8Adj3rstoiEst4RE= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=HzSABeMS; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Qz03ClBN; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf13.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729839925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TNs7W8zUcetjE4hIVdVBXvx9pfCwxYIJk7B7EqWXuNk=; b=DEV52NCg9isxCvB54xo3YU/CdwWMOZJb88u7qS1lXrs/4PHpCUyxcFKuk8MEcfOMnHHg3s 7clo8nenPw4nfCChXl4qO8q9u3quhYMasglQn3NwL3RuGreb9ERpGFyHlXP8rPnkSbqFHd ZslGaoGle5hGOWTpYCt47o89gBX5PAE= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P2fddD001222; Fri, 25 Oct 2024 07:06:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=TNs7W8zUcetjE4hIVd VBXvx9pfCwxYIJk7B7EqWXuNk=; b=HzSABeMSOYOjsIz7NN5wfONlbLe0ce6hbN KgX+VzIMEpPRqLxFlrKXISHubAQo43amwK872tb8o9S+F8Cs1d2WHyB/XVreGGf6 4+1eeFzrb7XvOEEzIR04EEm07kus/3+UpLuQdC2neyIqOaEn8eF/bQR/6rE5M/Am GboHQ6zmEGxhu9/FaBzqiFGtOXevKAz2wkkzwjmSy6ZVfTLyitulER2PKSxj1j6I e4Ns6QMbtEVhWt4dvfW0WvqJBBZ6YT4HRHNMcX7nzIuLvXqVryiIBR3bnNaUcLw6 UzvAIYGfFriFG/FWnVPPp8z9A3dDIpK+hrdu0a6ZOc6/3oGPmYdg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c55em6q0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 07:06:13 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P5Afln036015; Fri, 25 Oct 2024 07:06:13 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emh4ypfr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 07:06:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ERQcpEvrJdgr17g0ZZKwy96pWCPAzYDkco02DeL9ZXfBGQgKoshc5Dn7F/MVI2xwVSolNlNerZ93GG0uUMchl5MSb1Yl6dIr1tns+8YRimCWEd3Rw/TKfLEN9t8cXJrufDvmuLbbIb3QYVGvUBVoWch/BPeuAvGC7YXTOWQbkU6lQgWGK8guYHs/uesMFKqlEumwxnFDR4fVmqpVHm/gVB0TOH5L4LMeWmEmh8D8N3kNTMDgLLVNoIbDkTh8gCsRIMVpywTSYK4gueEbXwFJAjFkavr5VL6Pbpo8qgHslETjDi1rKA2ChSfHEIHNDb2s6T/3k82crRUHj6/PFWPJlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TNs7W8zUcetjE4hIVdVBXvx9pfCwxYIJk7B7EqWXuNk=; b=Tw4ihbm01BgxdJtdtcPc2lZggH5gTclK/ewf7tfYUd/9K+p2xNbPWh1+7aEM1vPww0/Gx/s4R8mB1eV9b434QnU8ahohWPdy70SeEfc/ZvvnQQ1ltsF0bZPQIBtHfl0K7AiKXNrrv5WG6cdmrTijLv77dBigi240tASsgqbIr5DAYDZL1bFYQ6imx8ilVVQgkxwq9GC2WfD1iB8p4jSuTxXcDO8wuzN55DNHWkFmS/zBawFF1ppiQL8wRHvdeMmUbiaKX4aI3LGVYCBmNAEPF9qf3EMejBG8zqLlvgDoevY3GPS371ZLnnq/M5dyYZNwDA/H6R3SgRTt4XJgT1Zgtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TNs7W8zUcetjE4hIVdVBXvx9pfCwxYIJk7B7EqWXuNk=; b=Qz03ClBNGHrkQ+FjF7W8Nmmy+lvAfzDBvd5+CxCeXNyo2zqCyNWL6rDrHeCbzHv2p+B91Tmml2AzJ574jaK2bm9CuwlFMFJHiR9q5UknfV7wCFyMM3pZNqqC+0tUMEA5c6uzIlFqOJclneg6UlElVTseAGhbUODs3ajpBtAMegw= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CO6PR10MB5789.namprd10.prod.outlook.com (2603:10b6:303:140::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.20; Fri, 25 Oct 2024 07:06:10 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 07:06:10 +0000 Date: Fri, 25 Oct 2024 08:06:06 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025031847.6274-2-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P123CA0583.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::13) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CO6PR10MB5789:EE_ X-MS-Office365-Filtering-Correlation-Id: 4af3d88b-20ee-4bd1-9e36-08dcf4c380dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S178ThB7cnbn3d1+LwcheBzZlt0cUvx3Gj0YNKygSoSHiwKFlhrm/csoY0fB?= =?us-ascii?Q?ddqrqidO0HjYFT7KohGAiN3bCndPILQW5n3aXt3S7S5iz6crWR1NdhWD6U6r?= =?us-ascii?Q?uzE+oWk1GyF1WZwGgGCKrUoYfVzkfbypoxG7EwyUUyAZDaFeSFB0dVoV35g1?= =?us-ascii?Q?hrNFhsrl02hneS9tNQQcM8pgH11c84Tls9/QmHdz5SuC6+k+7XKDhrZi9xxi?= =?us-ascii?Q?7cJoIMrLlRiPKHjxa/AqDXpKIa8BblSt6wN4a2YBFegBNmJUgFgES+nB45aI?= =?us-ascii?Q?FPDhfumbfhXZ/aYQFwoGKoXdIZqfMzzp2X5R+L4o3W8ew90iaiPJtstNBKto?= =?us-ascii?Q?yGer6NadAMSR2LSIgBsxoxsCo3HxLKvWhAbSsn55IH6WBTJBflgIbbSSE6M0?= =?us-ascii?Q?RMB6G2YBLiu6TTiurDqxlx2XkLpUkcoQeFViaqdrnP/wr9ry4LEh+rCF/iqO?= =?us-ascii?Q?Bo/P/d8kOXljm4iiRDB+0sXhqdgncY/dKqYI5276O8Jt228k/8uSEODLCRuD?= =?us-ascii?Q?D9hZSsg3+GepHuEv+FH9rsJ65FaWDlTRsYKKEkpLOeS/vPoaGU8T8EMzoofi?= =?us-ascii?Q?aPTXoOYyhXvnOwbVdhoP7buBXQbUiPZC8wvdvUPjHTIqDrv8P8SnTkFlT+60?= =?us-ascii?Q?fDoSVk+v0AoNx2feWfkU4x4l8m+3Vrr98NyLH3yMd+L0Gra2l6dnV8FP5fXd?= =?us-ascii?Q?Bi+G9YaBhPwGJA9V0YZLZ2n6pQ71EWLgMmKFUTlYxdXer/FTBIBYpn+/fMWD?= =?us-ascii?Q?1kAkmgRCwuwtgjFeTUe4uwi2Hl5E5pYvIdYJZYROKdSKfY3mPPyQJaLUrdSE?= =?us-ascii?Q?JV+jGOuHh/LZkTn9WPWDxZitoqI37wAO1BtUrwaDHEJDiyRW3U9al2G2KnkV?= =?us-ascii?Q?pUWOZ3F+v3jMOwsBUd4i9m8RUysBakyvFTJZn+EwQeeHSHHLBiWoxEl0dTty?= =?us-ascii?Q?YSZRHdvfpfxZ9DZKkffXYl9RBMIVBuOlMq8ov6eUwxhOVso6HZRVUwkyF9e1?= =?us-ascii?Q?WrFd9V6iUDkYS8Uu6i0e3KYFWoSAJS5hL9c8bpipFVJCPnkIx7fq0LU3Yeyb?= =?us-ascii?Q?FhE5zQESjFIyLMLXAZJQ9Zmok4JIarhHGuF6Mzgh2C/6xywKDgOjvf1OaqeW?= =?us-ascii?Q?JC6+4F7k4JcdupF+iIV84bu2trY9WqOI7eBI9bNAUlcM/kEa6r5EHAELlpVx?= =?us-ascii?Q?vmeWiAR22LlBcGdd4H/chHCU+4BGCOF7hEHKzNvjvULHGzFu/juNU9wVo9l7?= =?us-ascii?Q?+Lq/xMl5PITz8Py6ab45DYWryOn9qB/qdyyCb6CLTheT1F0AMlG/MUeygpbg?= =?us-ascii?Q?NcQLdTrQHrrE5t6hnqIsOjl+?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WWcfQv21wOWwAN5el2MF78+c/5MIAldmNI+Ny4IVhS/WlfmI7cZQfwCJr/YJ?= =?us-ascii?Q?pqAWdYKXSmzlUnxjlADb8t09JTWvkloxor3AEWUXGErTl/3PzEwpTMQLgOTO?= =?us-ascii?Q?RAsdJh7Sx3YAGE274CjViRA73v11qtFsw8kiZ7UKHmvZoavp7yOJQ79Hfeuo?= =?us-ascii?Q?ljMm/YetJdJNb1oIgpmLTh3rfvYOPyvMRGFfsPfL+WJMMEj1ynfFRSkDNjnv?= =?us-ascii?Q?N3fsMq4otMIE9nqaHe6M2Ujs3YYLqu9BC95Y2EqNampVsfEnVPwkgJXrdabL?= =?us-ascii?Q?8Vt5dD1VK2NfGILaKAdJFMGpLQSG478ZpPdbhcGn3jseJTSVLLBryvIGrVTm?= =?us-ascii?Q?gDKpyTdtkzQfRETobe0ARZdFRGkdq2dkA6W9AvySgk+JRY4y+Urm/b3KbKNw?= =?us-ascii?Q?rGfdFKsti2z6TX3hlASStyvtlxJganpwryrdXjLrrrhKZy/jBAPpIOnP7tkB?= =?us-ascii?Q?+lLgcN1fPlLfcSlPqxNFiidXiK0nsi/RFqRxCBid3HJd+g93Yv9pKxPZar7v?= =?us-ascii?Q?JYPDG7M2goYi339eEmzkwjSUpJEoRVX3sd0up0MjcXc1++cC9v+nyvXg0+KM?= =?us-ascii?Q?46btSfDnWmKDm5t2jcu8N8izWSzqHCt6yrfWD6VrChDgHhpTdABE6NPcMq+v?= =?us-ascii?Q?nUIfGID9qIAOUa3QwjDlToC9504VxUBZhfbPuUhUt3AdwQI2GBgSFuqOJsGb?= =?us-ascii?Q?WQ1MiDhWpGuZ40/kUX0KExWvrAu76ehvZhcPfkuyQsxwodkq5af0HRLS/14C?= =?us-ascii?Q?wt+aTGmCEcVGePcn0PCo9btpCugrR7vno7vTBqWFkanMqh46jFs4xF+W988j?= =?us-ascii?Q?k7BJt/XhH+ca07Je9nw0QSVznExmvZJ1+OHnHV/g3nFTqR+uNagERD7TsgEg?= =?us-ascii?Q?IYwgSnAtDv4xfxtX/Zp9M3iM3q2IUgq3Dt+6i1gCcCeFetVxN4MSV8MQmNOc?= =?us-ascii?Q?h1KfY4GcQPpSlgFRK/QynbM+EWz7Sfnqi/7k7O7KjhRJUlTxvAf5JDtKJoFV?= =?us-ascii?Q?uq1WOlzUCkL7aEdxM9nnWiQQz6O6BqCcHnjUDnodGzzBcosbcxYNV5ccENju?= =?us-ascii?Q?hP15HBX+I6bZCwIppZ9lyrDUZDXffub2M4Oqg9Zub/a59PKsfivLifnY5Lcm?= =?us-ascii?Q?+tN3j5N0RDoTBpHFy2PJfcgsKTE4oVHcVnzTq/zdpz1/IsS0Q6cEPnuFLuKu?= =?us-ascii?Q?ZEFOacX5emy6bDyeuMYV2uVmz5hhChqa0vweq+MklV4hqOzLdgQiHpgNIWfH?= =?us-ascii?Q?K0Rm2qq2Gp3TIcS5tlbbOAVcfpPs5ee7KNXfqyhMTfnRESpi6oanNl589Gkz?= =?us-ascii?Q?IUKbrby56KJlw2Bt1JYSuRjgSnuryeoOPdtLXBhBGChnMWxDS0KyBr9yN8rp?= =?us-ascii?Q?xrMS3cGyGFONJfhQPigHdaEzpZgiW7CBo1dlF0Mb2QvanmcftpAzG+Iqke9q?= =?us-ascii?Q?whEEhzHIRZfVfzXr4WyFuqCz8gkccCx9kYt0JzQYMGN482lnGdjp1uEqnIyp?= =?us-ascii?Q?/i5YZ/cL5BblL17qBjsAgUQ4OlOIxWTaJ2QS51F42FWi9D6z4X6KK+yNI1gn?= =?us-ascii?Q?oUDXZkdWcfZVqcVHum4ybR0Upe3lU9nOFpWZJkhZGfthi92KauEeu+gliBsp?= =?us-ascii?Q?53tEkpd02ZPJBdnLfxT3MUYnBn39Q9JF7lX43k7cMndATASumKrWDIh98+gO?= =?us-ascii?Q?IZ6RRA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SJHGtWcOeYqtWpBTMuWwW8fPTHvFx6t9fSom2nHJBcHV5VOG6H2Ofj+sXV5b9TUFhEFusIPmBLOlXhgGENqQFCjdvuArkp1n4hs5f9JGcRuIautA5opwxVz24I0L28llJ5C7Dw+/Xf+p7EBrqBzhvR6tvUVgPGN5BUv8MTWyJCmvN4hsClYtuagmpIzZGPjAZPI+wekPA/a0HhtFQJ7s1DUQ/cTU6LhZNERyrZI3cO1IS9OdExqtfG1rwH3nU8joCPbd5Zw7dpycuCGVvmyC4E8oypUqFUpNzvLuwxfyunLRTWM+1eMdwSHpAHQdtbkb90Vn3XUsfcio6sA9PwOcYcHzPFnQXclzcJbeQcvRWlv9y+jKjG+xm7Ygxa1V3cWuG6zKvapf6K16wxMZFtiX6lOf1bh+LnNNQb/LvXoGZzX1V2ez+gdtXR12V5ffOTl85XLYaL9PBnSMr2yNK7A2yNJ/GKOEsi3E3nbFu6V17yrXP7/2utThpI9LW8IaW4qDQI64urzua7CM4i0yfaOlW75cKywAX4gMdOAvYqWAbHQnfxjhRPDMxbGI+hL2WSH8sYp/1imZONkwKCQz3974cfKnq8jVOlupSWTZTgq2HNg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4af3d88b-20ee-4bd1-9e36-08dcf4c380dc X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 07:06:09.9901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P2Y57B95U1WbOCYyZC6lA2IRmY+trKPOJPhFw65ExaeA2CCPqQzV4/vBkaAf+7mxInBEQKFIDYTnIJxbQwOe8T08kmwp5rR4HHyl40Onqlw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5789 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250053 X-Proofpoint-ORIG-GUID: 3LreaL25QhU2QukippmZdNZRnSST6bGs X-Proofpoint-GUID: 3LreaL25QhU2QukippmZdNZRnSST6bGs X-Rspam-User: X-Rspamd-Queue-Id: DBFFE20016 X-Rspamd-Server: rspam01 X-Stat-Signature: dqc9mh4gxemdwu95oe535r7fos1r6ucj X-HE-Tag: 1729839957-937592 X-HE-Meta: U2FsdGVkX1+2f3De5p3GgXi2DRrHOEHr/YJB2gIxZe/neJ5Cu18tTqvD7q/AjaQzlt+qeFfBFj4CBtGjHKVb+kXQFc68WOEaSEnyiK31RFGyD+ObKZopTcLzZnVjoZMh42U0h7pnyOjWBpwBJWD1CVi3BTPIzh2pE8ZeFLqfdeQrDwfQNBqg+CRDdi2GHeYtOLfQQYcMb+FKztA16VY/NC3CBl4PDZBK46Qsi9iL/qWDdBxoHObtybXl/tEvNS1ZvMn+2YQlrvRn4TUBbBRWw7Y15HgHpap5QbZoBOFjmvQoM3eEU1DbXZmcn6rxDphKuGcRHnVp9B/Lf4tXFuaFk6RkQSqpNd8kK6HWJKYw4hT26+RrR/E91QWggmPCWDF0tAUzoFE6URXaR/5YWmH3ybMYiZBOBSctNvwsLuaIKBAPFNUh6Q/cIIOIoLWpQRCu/2+bhwi9cZ4MqX8yT1m8cg/9kS5PDGbiTPdCsJYAv7CibiLEx7FJAzNRs3rBjN2ZvXmtsOkwh1D2o+Kp4JwllKCkYp5Gzc98Gku9XGZyqhHifQGjughNPGKH7wOekzJs6INaD5T669BdOjT22G0IVxyogkOQC64uqh/ZujzQCor6VJzQI/7ov7DArIVvVHg0APhEMKS35jdTxjXyOXCtkJjMrQIkIYH66JZKtPMzfL23Syk53QEodfIfE5EmSjHIEQz1tR5EM4Br+nb+8hpjV3IvHq376XNVZrxMmP0lA6hOoZ7JfZ4IVTTqY0HBbjcuX0OsfA+Zsk+YzHvnnnMrQXazNl0HPiwxKQm/jWc4Vc5fVxDoYxqIqMjBgBgHm0oMxlMcHH0eZ2s5Cn01LReuUyNgt/OGeT+j3+ik2v+LrML0nyT/AOLr5h6n6+e+IrrnggdFOWSn50voEnQwl2bwjBRI1bG2CB8gtbKuVxsGDfozLhh5RxcGlOjX1phrW0XilkmD7Wtv7hFC7MosFJ8 htEeo3sl aFcurD9zpoFpe6FJLvKeS+YBtE2XFVxK/PU928OKcw7eCcLxGu718zKytY0BV6H/Ju38N7gJ84IU7DZb4zb6T1sww+pAUMP4YY5OzEXl1DsOPnvA+M7U5Dql2MaJagdRewdOjZLgR/Fc7D55Y6xM7e+4J/gYtD4EBowrSPo9Dat/NxmXfBZxSimvCBimswiD3JBon2++kbFSUzKzs5EnY5f3nt6+N3OuumbYiDPqnDH4NKNs7KRyrguuHjX6sbi4H0MiTo8XB3//i1nhDravaTTXvl/7LvDHv+iDr369RXtmNszvXf56ZC3ppUAcDeH4b2EDpSs92m5VS4ESAVp08J0sHh7+rJFSXGkwFB5OFlrGUBHVkmiClVSdGOkkMXv1wvmCieefzGG+cf1MC04JsBEfoNV8wCc0/hh8ffZKYjJ5Ae8KGjyRFbTus1sdqwmmlFIvwZEhSO0cLdyXAxM+L/q8NWNJ8/1TN0H6oBQ07dbxeoyIPzuFUY6HjiRQznscLycMfjKLN9egkpDeRvFo0uPtLKLHX3CwVv2jSo8rIqQyle4KuRrQ2XlyBBCRIEA8qroWbZSfkpgTp12uFkoowBMikTAcZbX+iLD3npNh+p93ypio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 03:18:45AM +0000, Wei Yang wrote: > On expansion failure, we try to restore vmg state, but we missed to > restore vmi.index. The reason is we have reset vmg->vma before checking. > So let's put the operation before reset vmg->vma. > > Also we don't need to do the restore if there is no mergeable adjacent > VMA. Let's take it out to skip the unnecessary operations. > > Signed-off-by: Wei Yang > CC: Lorenzo Stoakes > --- > mm/vma.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/vma.c b/mm/vma.c > index fb4f1863f88e..c94d953d453c 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -954,23 +954,27 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > vma_prev(vmg->vmi); /* Equivalent to going to the previous range */ > } > > + /* No mergeable adjacent VMA, return */ > + if (!vmg->vma) > + return NULL; > + Kind of a pet peeve of mine is throwing in a random refactoring thats not mentioned in the commit message. Please don't do that. I think it's fine as it is. > /* > * Now try to expand adjacent VMA(s). This takes care of removing the > * following VMA if we have VMAs on both sides. > */ > - if (vmg->vma && !vma_expand(vmg)) { > + if (!vma_expand(vmg)) { > khugepaged_enter_vma(vmg->vma, vmg->flags); > vmg->state = VMA_MERGE_SUCCESS; > return vmg->vma; > } > > /* If expansion failed, reset state. Allows us to retry merge later. */ > + if (vmg->vma == prev) > + vma_iter_set(vmg->vmi, start); Good spot in that we've stupidly been setting the vma NULL each time before comparing... (doh and mea culpa!), but this actually accidentally proves we don't need to bother resetting this at all :) The only case where we care about a reset is mmap_region(), and there we reset the iterator _anyway_. > vmg->vma = NULL; > vmg->start = start; > vmg->end = end; > vmg->pgoff = pgoff; > - if (vmg->vma == prev) > - vma_iter_set(vmg->vmi, start); So please replace this whole series with a patch that just removes these lines, thanks! Also what tree are you making this change against? All mm changes should be against akpm's tree in the mm-unstable branch. This change looks like it's against another tree, as the code for this function has changed. > > return NULL; > } > -- > 2.34.1 > >