From: Andreas Larsson <andreas@gaisler.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>,
richard.weiyang@gmail.com, will@kernel.org, peterz@infradead.org,
aneesh.kumar@kernel.org, npiggin@gmail.com, dev.jain@arm.com,
ioworker0@gmail.com, linmag7@gmail.com,
akpm@linux-foundation.org
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-alpha@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-um@lists.infradead.org,
sparclinux@vger.kernel.org, Qi Zheng <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v4 7/8] mm: convert __HAVE_ARCH_TLB_REMOVE_TABLE to CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE config
Date: Fri, 6 Feb 2026 14:33:24 +0100 [thread overview]
Message-ID: <847afd79-e8f8-4547-8167-0125809de055@gaisler.com> (raw)
In-Reply-To: <c24c32bd-085d-460a-833a-a982eb5becaa@kernel.org>
On 2026-02-06 13:59, David Hildenbrand (Arm) wrote:
> On 2/6/26 12:58, Qi Zheng wrote:
>>
>>
>> On 2/6/26 7:45 PM, David Hildenbrand (Arm) wrote:
>>> On 2/6/26 12:13, Qi Zheng wrote:
>>>>
>>>>
>>>>
>>>> Ah, It's just simply aligned with the MMU_GATHER_RCU_TABLE_FREE above.
>>>
>>> But does that work as expected for !SMP?
>>
>> In the case of !SMP, tlb_remove_table() will not be called:
>>
>> static inline void pgtable_free_tlb(struct mmu_gather *tlb, void *table, bool is_page)
>> {
>> pgtable_free(table, is_page);
>> }
>
> Ah, okay. Confusing stuff. Would have been nice to document/mention that in the patch description.
>
> So if it compiles, all good
>
> Acked-by: David Hildenbrand (Arm) <david@kernel.org>
>
It looks a bit weird, but it is actually more logically correct than
before the patch. Before this in the !SMP sparc64 case
__HAVE_ARCH_TLB_REMOVE_TABLE was defined even with no actual
__tlb_remove_table() present. But it did not matter in practice.
But I agree that a mention would not hurt.
Tested both with SMP and !SMP
Tested-by: Andreas Larsson <andreas@gaisler.com> #sparc
Acked-by: Andreas Larsson <andreas@gaisler.com> #sparc
Cheers,
Andreas
next prev parent reply other threads:[~2026-02-06 13:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 12:12 [PATCH v4 0/8] enable PT_RECLAIM on more 64-bit architectures Qi Zheng
2026-01-27 12:12 ` [PATCH v4 1/8] mm: change mm/pt_reclaim.c to use asm/tlb.h instead of asm-generic/tlb.h Qi Zheng
2026-01-27 12:12 ` [PATCH v4 2/8] alpha: mm: enable MMU_GATHER_RCU_TABLE_FREE Qi Zheng
2026-02-01 22:01 ` Magnus Lindholm
2026-01-27 12:12 ` [PATCH v4 3/8] LoongArch: " Qi Zheng
2026-01-27 12:12 ` [PATCH v4 4/8] mips: " Qi Zheng
2026-01-27 12:12 ` [PATCH v4 5/8] parisc: " Qi Zheng
2026-02-07 2:34 ` Helge Deller
2026-01-27 12:12 ` [PATCH v4 6/8] um: " Qi Zheng
2026-01-27 12:13 ` [PATCH v4 7/8] mm: convert __HAVE_ARCH_TLB_REMOVE_TABLE to CONFIG_HAVE_ARCH_TLB_REMOVE_TABLE config Qi Zheng
2026-02-06 11:06 ` David Hildenbrand (Arm)
2026-02-06 11:13 ` Qi Zheng
2026-02-06 11:45 ` David Hildenbrand (Arm)
2026-02-06 11:58 ` Qi Zheng
2026-02-06 12:59 ` David Hildenbrand (Arm)
2026-02-06 13:33 ` Andreas Larsson [this message]
2026-01-27 12:13 ` [PATCH v4 8/8] mm: make PT_RECLAIM depends on MMU_GATHER_RCU_TABLE_FREE Qi Zheng
2026-01-27 20:46 ` [PATCH v4 0/8] enable PT_RECLAIM on more 64-bit architectures Andrew Morton
2026-01-28 2:07 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=847afd79-e8f8-4547-8167-0125809de055@gaisler.com \
--to=andreas@gaisler.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=ioworker0@gmail.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=qi.zheng@linux.dev \
--cc=richard.weiyang@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=will@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox