From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEED9C282DE for ; Wed, 5 Mar 2025 19:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 468B028001A; Wed, 5 Mar 2025 14:04:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F5D6280016; Wed, 5 Mar 2025 14:04:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FA8628001A; Wed, 5 Mar 2025 14:04:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E02EF280016 for ; Wed, 5 Mar 2025 14:04:12 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57476C040A for ; Wed, 5 Mar 2025 10:46:48 +0000 (UTC) X-FDA: 83187169296.21.9E3ED56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 0049C1C000D for ; Wed, 5 Mar 2025 10:46:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RgxtDRZb; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741171606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9Hek7yRq/wtSkEAPYnA2mnc2+UFmv96A3d5UMG6XuPg=; b=MVS9JDG1hAAFhc7bZUR/j8ulve3eQvUyp38ch6mb7I4AYZOwm4EmbqaW7uqliO3eev6pFa 2aT/izc5+wLvNlg6mumkwQ6hxNhyJim9OcKLAXZsZXVnnppCLHoD6E4owSBL4ax8323xnN PtBc0LBcpEX6XMiBPBUUYCcAi4Pij7w= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RgxtDRZb; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741171606; a=rsa-sha256; cv=none; b=28qWYocU27QvTvQeoN7OQSrLAspXYEIlsxoo1GcnzSaLv/6qJUlI/Ma/p0LrFqyDVWPNGp rTNarR4jDlZ5pNEjmSfSa3Hhp6cgtyRGQKHz63q9KGcRxKs/HZ2+uKre+vmjzEi3w8x3Qz YWt6GkvyVxxLIa1LbbdnrjTgY6z+HSs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741171605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9Hek7yRq/wtSkEAPYnA2mnc2+UFmv96A3d5UMG6XuPg=; b=RgxtDRZbmWSTAvx3XUxEqu5hpqt7h1J1uYhsqWZPQHLg9lOcxfnbTB/t+y7AT0XSHDAi5/ TRUGg4bUL3UzmL7b4YMrCLArja/Tmln6rP5ttvUon82uhAsxPjCbYHDlKDQEhJhzvvYmpJ kCDnNK9cMqnv7XcyqdACRARa5jYqid8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-AkSD2JYIMWi60sMOOsj1MQ-1; Wed, 05 Mar 2025 05:46:44 -0500 X-MC-Unique: AkSD2JYIMWi60sMOOsj1MQ-1 X-Mimecast-MFC-AGG-ID: AkSD2JYIMWi60sMOOsj1MQ_1741171603 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43947a0919aso58817945e9.0 for ; Wed, 05 Mar 2025 02:46:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741171603; x=1741776403; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9Hek7yRq/wtSkEAPYnA2mnc2+UFmv96A3d5UMG6XuPg=; b=D7YO/i6EV83acURW0GzU2HPCrxc5/kFFLiS0sWe/HtVZB3dzvfrubTpStHu0zoJhnx eLtMzsnwYK0xEct+zzbtxE8uxu0Yn8rWti96YjNof14K1Wh6x/kMLigxZb8L5cZg4Ynt 1aeyIHTI8xLoFNg5P9CwoPkHRUBO7fY2hO+A9GptfM5ZzbDuYEHJZ+FimWv1H5mW72qT cFEvkhGDLCzKaGKiwNf6fbdOjmwIbr7PoWF3Zad+zJZxHYVoRuz5GsDlkPNKkKUXkBdU NvdEoTncNHYb0oVlNMf+AdIomSRPRq7P01L5YyTvF6ydIh75i8StKivgJ5YtLhu9kMv5 Ly5A== X-Forwarded-Encrypted: i=1; AJvYcCVsTdkwvY6HFFC28zxKde7903d/gbEPvqaKETSmcj3+ibydbSCWsKUfz1wqCj1r58WrejS4TU8TXA==@kvack.org X-Gm-Message-State: AOJu0YwXwDL2lTqCylYJG8mtgrRvYW9ivZyMnQw7eEC39SwAl2nESMws i7GtOhU0/qwZLxBkqAaUFT2NtYVBzSeC/oxHoUw28Un5nTBmmcuD17f1gfzE2Z2p7f8TyDHIRHv /Ozi1EUWj/1i7a0Z8+nk0c+8n+X1vbSj9LlJuVJjqKauZ4s6z X-Gm-Gg: ASbGnctGprI8B4pPXRBsrIImhInEZ7dKKMZ3v/2iEXdVmX6eWMec60g8+o19h8UotFn 1ymeA83ZShsVcJ0+a6CmeB0wKRqZKrwnBil2eYZ4OjMwyxcJip+Dl9dCDRuRs5RVjg+PTSjqvHc 7I++pQ9IcZ/oqJKx98pwubrB5EDWDNUyevb6jlWiVcO3QifcXFBwTIkKIvBUQ5gOfv+Vm+y7szE 9WiYJL/TETeYJB93vx2worBCKRS/LRx1eeKAe4/iC5gF/E5p4WBsbNwLhnYvBzoTv5HFPKw1PWD FxfL4c0+7BZIN5H+WUfxH14ACxz2meLZtsWs1hBFYiIIwl3I/w== X-Received: by 2002:a05:600c:35c2:b0:43b:a397:345f with SMTP id 5b1f17b1804b1-43bd2945a39mr23478505e9.11.1741171602851; Wed, 05 Mar 2025 02:46:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4OByu7oNh1SiBnLSXKDtowyLNgdmoAfAoBaNi7Vsjjg9e0WLIW7/7B54Ml/f2Jk3+UOp3WQ== X-Received: by 2002:a05:600c:35c2:b0:43b:a397:345f with SMTP id 5b1f17b1804b1-43bd2945a39mr23478135e9.11.1741171602363; Wed, 05 Mar 2025 02:46:42 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd91338cesm96095e9.7.2025.03.05.02.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 02:46:41 -0800 (PST) Message-ID: <8477d9ec-b9ce-4a3d-b61f-1bd44d3360a5@redhat.com> Date: Wed, 5 Mar 2025 11:46:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] Plain dereference and READ_ONCE() in fault handler To: Dev Jain , willy@infradead.org, ziy@nvidia.com, hughd@google.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250305102159.96420-1-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250305102159.96420-1-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZBSoJ7HT5_G_GkbvdLN4-4NafdUQBKn_h1woPhnbpFA_1741171603 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0049C1C000D X-Rspamd-Server: rspam09 X-Stat-Signature: hrs8x433mxqwqzxt55h3e6xbr9yx8yrz X-HE-Tag: 1741171605-74337 X-HE-Meta: U2FsdGVkX1+Y5853JyiikWGmSx11fMpiQbMK2BgNdq9DNolW7VmZ5AIAyQ5WtvEpHdtcEZWnbwVj6Lr3cMMmck1BgJmjJAsZ4CiiqQUq55bXayJ8IgfbcCtGV/vtA2VY6RFpErWw3qeIK6tLaLimFabhLlYa0QgJV0CqGMeuThoV+HW5zSC/9EYzGAkIbor0PPZXhgoOhzlyrf3dOlJk7EtKhJZbG9mF1B1fKi0zdU5rSzvUtaBAV93Wu3fKdIgFz4gLeHrCLGENb/dMUf4mjoffQhcFBOZ0F3PTk4TG05cCWFiaJCZFH/1oxhMcrbk233obWYbpCkBWYG4GQojUqJwf4XmaxT3HKWxfp/eLg7mYM3bLtddia4DYeggDUlJk9ArqOLvB7Uq8jfDoDs2svVrD4E9bgqpmg7NtLPuzN2rJXd1/JOUAg40u9L6fNvKa461sMXgHpiKYPHtVAumaRpv463PRfnauRDM75acLVlvsD/E/CLcHL4YYddeKE/QkrhxyQM85eOg8bDhDXLMjZaE1uXaziPbP8XgzIgUBp8mNkYiIRh3ZJlly7ECCddKJPA1XmDpeT7rndUlf7e9y8lwl6v+MI93t7wQzT4mphVCOewdVPZexdy1C8Gc5FYqA3eUo/yL0Kn9duyg9w+GKuZTSrTQmAcWXa+MpircwdAog9Gq8yxZUS8jps9NNOkzFbXlE3+Ls/01xpvXSneEB10gg72bs1m1IG/0FR18knGB5Eg/kFBRUOxaGqE2CN2pMf1brqOuvvRrpSD8uLDvVGfSofOsN/bblztpOmfO3lYZ71qOMZiM0DGpBzVgIrx64+YnrBkpZnSYqCjBJ4qY20m1a5UwbSbVotTtdKr7KnKmd8aj98LvByuCTr3jG8vjskjXpD3bAwg5odeKGKvvzE6o5We0a3+vPIz2JdWzSpueB752o73AArR3pE8ULINn9Wsp3gCW5xXvdR2EMJOi ga2rXLge C0SREfYvpqr7yXZe7zFelYWsZxHrsNbUHYn7dzec1peBdYmHSuTSPNRsKXcx/ezW9DAWoY0I4PB4BD3Lu9woUCuaszJZeX22/G/+XdezM5UUxB7sV5nXm1Fs514HR+p97NsUZu+neQJZ9t8B+lZm21tUb54WXI9FO7xDrRoQ8OZ4XDPYt1wBRrjvKoR7kLPrzTSj4INPzw6H/+I4kIcOSWrQzf35wWUYetgsKu9gTOOxwGVKUh7fPf2/Fvcqctomlh4dpVvHrH2ceSytGJpQHFDFtEYdB4D6WY67yYeqxBCHb9nra4Bctnguvb+7OCQMsCaQXmnLcBOqkSeBeuI2ktqD5qJZbGh2rgXuR5NOLefxZmyCUjdNkbzjZ0s2yGNywI8nBUzrmUBfz5YMIxmjwTTIyp79vvWruuBBwN9zblJUxJ0Et9GDIPJnbH2dOQKldzuuMfKXXBLCQeRioRex9fP/v1X4J18vOemJi0LTNW3qyFKMSTHxKqD74Qzu+HwMGP5Q7sXJbaBAkUFWEEbWtgdkl2PUvGuGOBT7kqb+ilw5Wd8qmovCBoI3oNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.03.25 11:21, Dev Jain wrote: > In __handle_mm_fault(), > > 1. Why is there a barrier() for the PUD logic? Good question. It was added in commit a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 Author: Matthew Wilcox Date: Fri Feb 24 14:57:02 2017 -0800 mm, x86: add support for PUD-sized transparent hugepages Maybe it was an alternative to performing a READ_ONCE(*vmf.pud). Maybe it was done that way, because pudp_get_lockless() does not exist. And it would likely not be required, because on architectures where ptep_get_lockless() does some magic (see below, mostly 32bit), PUD THP are not applicable. > 2. For the PMD logic, in the if block, we use *vmf.pmd, and in the else block > we use pmdp_get_lockless(); what if someone changes the pmd just when we > have begun processing the conditions in the if block, fail in the if block > and then the else block operates on a different pmd value. Shouldn't we cache > the value of the pmd and operate on a single consistent value until we take the > lock and then finally check using pxd_same() and friends? The pmd_none(*vmf.pmd) is fine. create_huge_pmd() must be able to deal with races, because we are not holding any locks. We only have to use pmdp_get_lockless() when we want to effectively perform a READ_ONCE(), and make sure that we read something "reasonable" that we can operate on, even with concurrent changes. (e.g., not read a garbage PFN just because of some concurrent changes) We'll store the value in vmf.orig_pmd, on which we'll operate and try to detect later changes using pmd_same(). So we really want something consistent in there. See the description above ptep_get_lockless(), why we cannot simply do a READ_ONCE on architectures where a PTE cannot be read atomically (e.g., 8 byte PTEs on 32bit architecture). -- Cheers, David / dhildenb