From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB8CCA0EDC for ; Fri, 30 Aug 2024 16:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB3CE6B019A; Fri, 30 Aug 2024 12:43:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3CD86B019B; Fri, 30 Aug 2024 12:43:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD6E6B019C; Fri, 30 Aug 2024 12:43:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 96DE56B019A for ; Fri, 30 Aug 2024 12:43:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EC66F120170 for ; Fri, 30 Aug 2024 16:43:00 +0000 (UTC) X-FDA: 82509481320.18.D7D22BD Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf01.hostedemail.com (Postfix) with ESMTP id 887AC4001C for ; Fri, 30 Aug 2024 16:42:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf01.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725036078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUek8Uem+47R1tW+fCnWb29ggJEbB3q9+dDSyzytSTU=; b=8De1sku3Xa7s/+2G6K8E1N3FxqUPRFuaAd0ybm/L5B7VjRqagM2QTnnr0QCPew0wXR1i3q St1SP4HqIeekfMbYn9f0zZJEpoQX1XxJb6y5jO9lPBTYOR1WtECKSdhu6nrmJhH3wc6MZ/ 5hWzS5fcHOp+nBEep9uJYz/ceWPenZk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725036078; a=rsa-sha256; cv=none; b=SjFsY6w9VWw14ryGH4EwsK0Ea/wwnRarafZ9LYY8VaoBIZbtFkMAgaE6qpOB3KLWXDKsLC PHcOSRWst4N/5aXuef2+AN8Uu+9wvwBuDgz/IEiUXpotJgUIIceAKmc1cBtFaWp5IPvoQq RYD2OMxZ3nCorDec47KeuyOhdy5SIy4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf01.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4WwP8c465gz9sS8; Fri, 30 Aug 2024 18:42:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6brwcfcnvqln; Fri, 30 Aug 2024 18:42:56 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4WwP8c3CYvz9sS7; Fri, 30 Aug 2024 18:42:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 59C838B794; Fri, 30 Aug 2024 18:42:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id spbTDoYI002a; Fri, 30 Aug 2024 18:42:56 +0200 (CEST) Received: from [192.168.234.133] (unknown [192.168.234.133]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 74A238B764; Fri, 30 Aug 2024 18:42:55 +0200 (CEST) Message-ID: <84682299-8cbe-4b66-9c26-17786e73af55@csgroup.eu> Date: Fri, 30 Aug 2024 18:42:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32 To: "Jason A. Donenfeld" Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao References: Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 887AC4001C X-Stat-Signature: 5ggzh8yr3wtate8kbpmp8hemke1e31md X-Rspam-User: X-HE-Tag: 1725036178-406090 X-HE-Meta: U2FsdGVkX1/pkR/FX2wZPKYJyRdYGyQQxm0Ri1e+n3s4XgFoR5iuV65BAhbk3rGdcYQSz+eEhG6LDsnD7q8dPU1cIP23hXzWpMYFOOZXzQZi7lrjWWJTJUSGKPGMZUQckFjeX7T/ox0UpYknMgCw8+sMZIz/gidh102x8EFWLUAZf8851pPp/ljEydRQHUpcAaOR0APoLS3KaYwmETzbQZAuUd5FJHqUqN6IUG2Hp9OOO02sKlxxHnqZU3SoQXDebDLck+0TNIM9T7fzRCLXtY4Xcf+y06yomLHs7eW4brx6AbvemfPFZ8PVwCF/bE6pC3IbuRdaNASjOp0wAyIKzW8PlRvw66oq7nBr7FS90GcP1Zt65kcoYDdUIW5fyhf6onGFBC+i3nDlJmhiat4XJ9neo3yKE3KUUXp3U4LYNEUgQgjio+ct8Ki05s8ZrJ1vxTaYQgESLg7ZGZ62Ov6j5QdYineU06oNyEAwceUqT0usU8uyYe4FaPCZVg1zIHyPncwa8SDROFuVGO1rYJRLLSbejLUjiBIie2+xAcjV9Dk+dhoUeInuqP6dwYBHNfnyYzbrNYsQbwSJ/w1R44tgs7H0hJHyZlt4/tP/AjCevaZM5OEsON9Jae3DECV+bY3Rnl3ECzbF4b5kkjA5IDPC29BEJW/FsS3KAjBJ+swOKIuZtlers1TnmBYPKwGXSUQ8LmFR4UvHhyN8XiNkywYPN/PjyKRg4LK3DwKD+wpnmB4HI9gyObBxS33oET39IMvyiwpeYrXhMk+ZOhGF3MMfojh+BcLKz3koI4GqjtoZlQsoA72Xge+0cDWG0KYU5e83NfidDR+et95FON8YtKPoDDszKF1Tlpdl8lHmoh3YBHCTxe/gY3QnXBCKgkJ+/kMtgmvPCToRwxhnz1oTdq1wDfxybTBcQFoYZDRiR6h9N7Yp9tli955WsAYQgSvyLXeNvKXfilcBiPsvX1UgWKZ K25Dx8GG CGTPfQqQjb3WueKbRVk4Ox0uVl3ujlSfBCeBDDQcH1vq7mS8vDNgJpuCiC+LpIjuuzIG6lwelgqiJA1j+LxSQZHFJ4mQzRhR4LfzfCyymu+KYF34XcUA8lhMWLRSk7M5fOtravTW89ixkCuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 30/08/2024 à 18:14, Jason A. Donenfeld a écrit : > On Fri, Aug 30, 2024 at 05:57:08PM +0200, Christophe Leroy wrote: >> + * r5: 8-byte counter input/output (saved on stack) >> + * >> + * r14-r15: counter >> + */ >> +SYM_FUNC_START(__arch_chacha20_blocks_nostack) >> + stwu r1, -96(r1) >> + stw r5, 20(r1) >> + stmw r14, 24(r1) >> + li r31, 4 >> + LWZX_LE r14, 0, r5 >> + LWZX_LE r15, r31, r5 > > Why swap endian on the counter? Unlike the keys, the counter is passed to the function as an u8*, not as a u64*, so I thought it was raw data in little endian order, same as when using Sodium. Is it wrong ? Christophe