From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Xi Ruoyao <xry111@xry111.site>
Subject: Re: [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32
Date: Fri, 30 Aug 2024 18:42:55 +0200 [thread overview]
Message-ID: <84682299-8cbe-4b66-9c26-17786e73af55@csgroup.eu> (raw)
In-Reply-To: <ZtHv9R8b7qwWKR2b@zx2c4.com>
Le 30/08/2024 à 18:14, Jason A. Donenfeld a écrit :
> On Fri, Aug 30, 2024 at 05:57:08PM +0200, Christophe Leroy wrote:
>> + * r5: 8-byte counter input/output (saved on stack)
>> + *
>> + * r14-r15: counter
>> + */
>> +SYM_FUNC_START(__arch_chacha20_blocks_nostack)
>> + stwu r1, -96(r1)
>> + stw r5, 20(r1)
>> + stmw r14, 24(r1)
>> + li r31, 4
>> + LWZX_LE r14, 0, r5
>> + LWZX_LE r15, r31, r5
>
> Why swap endian on the counter?
Unlike the keys, the counter is passed to the function as an u8*, not as
a u64*, so I thought it was raw data in little endian order, same as
when using Sodium. Is it wrong ?
Christophe
next prev parent reply other threads:[~2024-08-30 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 15:57 [PATCH v3 0/5] Wire up getrandom() vDSO implementation on powerpc Christophe Leroy
2024-08-30 15:57 ` [PATCH v3 1/5] mm: Define VM_DROPPABLE for powerpc/32 Christophe Leroy
2024-09-01 11:17 ` Michael Ellerman
2024-08-30 15:57 ` [PATCH v3 2/5] powerpc/vdso32: Add crtsavres Christophe Leroy
2024-08-30 15:57 ` [PATCH v3 3/5] powerpc/vdso: Refactor CFLAGS for CVDSO build Christophe Leroy
2024-08-30 15:57 ` [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32 Christophe Leroy
2024-08-30 16:14 ` Jason A. Donenfeld
2024-08-30 16:42 ` Christophe Leroy [this message]
2024-08-30 17:23 ` Christophe Leroy
2024-08-30 16:17 ` Jason A. Donenfeld
2024-08-30 18:52 ` Christophe Leroy
2024-08-30 15:57 ` [PATCH v3 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84682299-8cbe-4b66-9c26-17786e73af55@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=justinstitt@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=naveen@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox