From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC39AC4829A for ; Tue, 13 Feb 2024 12:01:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 125508D000F; Tue, 13 Feb 2024 07:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5E78D000E; Tue, 13 Feb 2024 07:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB7F08D000F; Tue, 13 Feb 2024 07:01:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D87C38D000E for ; Tue, 13 Feb 2024 07:01:23 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6583F80B96 for ; Tue, 13 Feb 2024 12:01:23 +0000 (UTC) X-FDA: 81786640446.11.6E1AC3D Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf27.hostedemail.com (Postfix) with ESMTP id 1B40E40034 for ; Tue, 13 Feb 2024 12:01:20 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ED8n357y; spf=pass (imf27.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707825681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OG1r0NtLTO7Nq37a+qBaAqxHHKm+oftf3Z3AGoZnsYQ=; b=RxSbWZDiyqd6u2YjgP/E7wt+AM43xmN05t479R73gwsufjjRvifbiNmr5zw8BKMIXnp1Q+ 9mEd8iUAtWON2Cs5OfesBdlB/gPA32gTqny5vWdsrq7YwbP723wBlTWZ4AzxKohtbUHnQ7 htcix8N9J3jVSeP4EiTx1gdWrJT2HNI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707825681; a=rsa-sha256; cv=none; b=DFKfEaQOFv/k+7c6ZEZQWcEpjZ8jufJvgm31TJ0EkOCK5Pa2nQZVRTQsv5Ie8T/aSOm6M3 SZHpHJnlOA8s2TWV4y0ZcFjLVZu4exHD+kNMv39ij0bdz13W4PPJidDPY6gT2s9vHV6i8m y2WFZ7zCccjCmmyimvAMopAVaQrni7A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ED8n357y; spf=pass (imf27.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a2a17f3217aso550911966b.2 for ; Tue, 13 Feb 2024 04:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707825679; x=1708430479; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=OG1r0NtLTO7Nq37a+qBaAqxHHKm+oftf3Z3AGoZnsYQ=; b=ED8n357ynfFWp+XGVGz6uCHShpFlz41Fwlo5aI1Bo4APJGLJPO4EzjWUSfHyW5cgpM /vi7llTMUfWJiFdzFCGclSTbDh76sAPK+b6VP3Q+3IgcEro88+nF0C37dL6N8+1W4I8p V01qXH74GKX5XJ4Spl4dwm+uzZaHKFoLzkI99YYSuXaNkTxa776J6DgDqggMenPV9Ghz RpjYqwza4IjKblSCt0Qy0d0vjlyxF+tAs0rcLmRIhH/6lPVPR1UD8zsepD1G5MtSPKjy r58Syi3AYWDEDzaROIrQxLgw8nL7jsUFzVaSSJVEI+JhoHDDDxpeyxKJJQFJhKCrtJBI 5GYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707825679; x=1708430479; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OG1r0NtLTO7Nq37a+qBaAqxHHKm+oftf3Z3AGoZnsYQ=; b=YZmP9RS6cSYG6gZrvcmp1X25wdJQDh7kA1lNtr5vonXdQ1M2+UDhFef3WAUdyziz7o pfwUWZRTTH5QJWj1BXY0sElP/eTzOaPtSCfW72Od03J6tMiEBNjo+pWuhFWFezCUBEfL +7Y8lEXpRp113pWLFC2sSASeKYzi6EX86FhITZLmqSdNdLIfaE0mEQlDZOodHARACvFg PiMprI11/6KpakMlAl9x9yLGyT9TnLdhwLO65L4TEntuMCpCYTRDVHkA9OHIwR2RSwFg iELz35uzk/aZLal4vL6xj5eLC3sHqXLLGbyPqYTrRjEhVKLHqdGGz84MD9nDL1EW3e69 wo9Q== X-Forwarded-Encrypted: i=1; AJvYcCXVzmK9d+v7BfgZOtPGU1EVNQIWa9hU3rQ3tAJR4xKtarFKun/A7SrzolQOvsKr97dJXgaQPLNVXeBl4I2l7QWWuK0= X-Gm-Message-State: AOJu0YwjfnEO0hrgAtdd142yL7pIUl3XWmOJpry+opZjoLwkW4svMRV0 sMl4J7KiEd56/ShSalLIjcb3mmqxHADBW++Fo7UTIw6MI+0i09Dr X-Google-Smtp-Source: AGHT+IGVq/FGBVTOMmd5u4Bo+rLXidfbF6tQJXQNKFoq1kNboQ4ummkLLalYQL6X5h1LYBkvBX/Ltg== X-Received: by 2002:a17:906:488:b0:a38:107a:94f6 with SMTP id f8-20020a170906048800b00a38107a94f6mr864045eja.71.1707825679173; Tue, 13 Feb 2024 04:01:19 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUUvdWZXM74bJB4Rm9is6EK8VXw0yMKJKBtt86Ip5QfFLyeVGqzL55Ok3sdvvtBmkJwVD+J43coQurJBxoVyoVJ1XDVZ10V5U7TBi2JREafSU/a1gF+aT30mEOa3PDoV2R+2pP3CqkykOxsBd9NQ/we9Rkqns0S2yMVji4vNuLHOxlGb2sq61KySZByPq0s2iS5jcFFhUyVpZmfPHc4tvWfOJntk1E3wy7EAB52UdvpbF8QDi7djjomjhba+WUcLPIxYfYt7K3eDLL+p8HccfjJQQJ0Vw1Cupin+Qyy8qpVY550VFLZn2026t8EP+zQ3157j6oOqwJwA5GqqIgcv8MOk5eoCAJwoMVbXEpwBwqhYpHT4mnjP4ZpGA== Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id gz3-20020a170906f2c300b00a3793959b4asm1216026ejb.134.2024.02.13.04.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 04:01:18 -0800 (PST) Message-ID: <845fb766bbe90865e2859af347ace76593e42c66.camel@gmail.com> Subject: Re: [PATCH v2 bpf-next 09/20] bpf: Recognize cast_kern/user instructions in the verifier. From: Eduard Zingerman To: Alexei Starovoitov Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Tejun Heo , Barret Rhoden , Johannes Weiner , Lorenzo Stoakes , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-mm , Kernel Team Date: Tue, 13 Feb 2024 14:01:18 +0200 In-Reply-To: References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-10-alexei.starovoitov@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Rspamd-Queue-Id: 1B40E40034 X-Rspam-User: X-Stat-Signature: y363jz49pjej99nn6b56ndiqga1opk41 X-Rspamd-Server: rspam03 X-HE-Tag: 1707825680-903938 X-HE-Meta: U2FsdGVkX19fVO9ZotYuAt8ZJnMweB78t3jOThWESrXFjNT+I+rEUwhUGHR5j00WuWks1W6EYSDnTqswjrGJmD+oO5qH8+bGQ9ivJB0af9FJF0dSu3luYEKR4IFFy4+ixDEHv/StvhTZJfF88g6p92oOBDToWCR2u9S6ZLu5uwRefsxnsyBjpJzqOnUmsbbQJremLGRLLdXJBbUmmGxpbQ1u28XmM/o+LJAaiHeoPOyZ6zRbM8pvHX8F9o9KpIbIPQukG5JfioTSGvhRXRr0JtBZct5rsZt0dPb1FkDESfWYzFTTMu8wMFbrlVpeYFykPqY0bP+/5M9ym0giUxEceol2RDpxY0ABV2DcO2O6a4x2C3VbYZj5jyXlYyCrg6bMPXg7qTd9yYY3TzaisM3dQRcjLFt1Kv+wmP3nG6wh1zC1l+FA6MvgVxjgzLto1Vn8NuKNyBsAsIIqC4wffJ/wL75dzLxaC1Sft8BrltCGPNGdwbCW7BVvgbte4GkeQG4r0U88+x4grM6HtbCC7ECNe9/w9cetFUbeNvoK0VwM92GOUSwmP9xZabgAqaoaExFCMEctF+E+BqImy6FJoP5wHSSVg4Kmn+/LJm7xQVhBl3YxVWmKwLD8WI95nS9KXEufQcoKfxzWWZV/eWm/lV5fTvKHECEWtUF3ksVybh66hZo9K1D4CRySkLTCa1QjNxhnlkCQkFdsSXHnERvYrmmUYTETBbFMcc4v0hLwFkAKnu5LkA2t5zPLKCJvYDmoYUfnuYQuaJErFk+koQNMc6CAqdPpb5rO+OpCivPbfw/5sn7ilS8UB1a4zebWuypWuY2aOWI7uaraEz5TyHZ8aswCa0o5U1yTDuBPGNuktvsqld9M/Mh7VrT+dlitC3E2ntP3QoDu4FwfnQpXcBxSu0dTGRpo9WjuFPxBEEasUeQv71cwhHxP5QPepi4233P/Dlkd0h0fKU/yeJ9KGF68w02 ZG8ca64Z 3wNto7OEZzYBIwutNU4cWjXYZ9Xd7OCRZJm1N8HACCNn/8DmtbJRUXmkH4QEGkZJEwyIDzm7aQj36op9zDeC29s3kZh8ofhi/xRIaR5pkAmNoDDwTzJ5H4Dz2Mkniqby+8EAaSFOMH1NJmzRd6BKm8kqpE6/xDVZxlN9N8Q4stbAbNZca86Z8OtdkfXNMX8d7bx63sc7cUFh9FMowpn3WrCKx20QOdKJXR1m1RaBZiB3yd/X+iOeCH31F2rCDqnF3QdtURUiR183F0EXcwG+IPb7lm3Ffx6t7BNrqZFfdYcmlrcDQ0TDunVd+8CKAtpZknM+RsHXydMk1bD3Sd2lI5zh1utM/QVmAj3rfk4ovPJ3ySW8B4YX415AuK9ZCEiSkmTybdt0tNY/A2jBH2AQHvR3ZtzWQKXFYblgPRUvv9EOVWhX9pSZOdmp9H9rODCIQWKLZ7utqwfavxMPbZtcswq23wg1k0uVAsuUwqiEP0liGhmCFyF2eO5qZLiOcFgYvXNX1wdsJAT6uFstg68y8uFlqpzwwQIkrTQehTDHyOw54qS0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2024-02-12 at 18:58 -0800, Alexei Starovoitov wrote: [...] > Yes. Casting anything is fine. > I don't think we need to enforce anything. > Those insns will be llvm generated. If src_reg is somehow ptr_to_ctx > or something it's likely llvm bug or crazy manual type cast > by the user, but if they do so let them experience debug pains. > The kernel won't crash. Ok, makes sense. [...] > > > @@ -18235,6 +18272,31 @@ static int resolve_pseudo_ldimm64(struct bpf= _verifier_env *env) > > > fdput(f); > > > return -EBUSY; > > > } > > > + if (map->map_type =3D=3D BPF_MAP_TYPE_ARENA) { > > > + if (env->prog->aux->arena) { > >=20 > > Does this have to be (env->prog->aux->arena && env->prog->aux->arena != =3D map) ? >=20 > No. all maps in used_maps[] are unique. > Adding "env->prog->aux->arena !=3D map" won't make any difference. > It will only be confusing. Right, sorry, I missed the loop above that checks if map had been already seen.