From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Question about vmalloc(GFP_NOFS)
Date: Tue, 19 Nov 2024 17:41:35 +0800 [thread overview]
Message-ID: <84510487-9a1e-4431-9443-3dae91d34048@virtuozzo.com> (raw)
In-Reply-To: <ZzxMW-AzPY7C27_L@tiehlicka>
On 11/19/24 16:29, Michal Hocko wrote:
> On Tue 19-11-24 15:24:03, Pavel Tikhomirov wrote:
> [...]
>> In commit 451769ebb7e79 ("mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc") we
>> add implicit memalloc_noXX_save/memalloc_noXX_restore at this code path:
>>
>> +->kvmalloc
>> +-> ...
>> +-> __kvmalloc_node_noprof
>> +-> __vmalloc_node_range_noprof
>> +-> __vmalloc_area_node
>>
>> So kvmalloc should be safe now with GFP_NOIO.
>
> Correct.
>
>> Should we correct the documentation?
>
> Yes, please. I think it would be useful to explicitly name the above
> commit because pre 5.17 kernels or those who haven't backported it are
> still in same position and that could get dangerous if they try to
> backport [k]vmalloc GFP_NOFS patches. Thanks!
>
Done
https://lore.kernel.org/lkml/20241119093922.567138-1-ptikhomirov@virtuozzo.com/.
Thank you for confirming!
--
Best regards, Tikhomirov Pavel
Senior Software Developer, Virtuozzo.
prev parent reply other threads:[~2024-11-19 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 5:48 Pavel Tikhomirov
2024-11-19 7:24 ` Pavel Tikhomirov
2024-11-19 8:29 ` Michal Hocko
2024-11-19 9:41 ` Pavel Tikhomirov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84510487-9a1e-4431-9443-3dae91d34048@virtuozzo.com \
--to=ptikhomirov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox