From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1506AC4167B for ; Wed, 29 Nov 2023 03:58:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A07636B03A9; Tue, 28 Nov 2023 22:58:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B7C06B03AA; Tue, 28 Nov 2023 22:58:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8800B6B03AB; Tue, 28 Nov 2023 22:58:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7A4A26B03A9 for ; Tue, 28 Nov 2023 22:58:06 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4A86F40475 for ; Wed, 29 Nov 2023 03:58:06 +0000 (UTC) X-FDA: 81509633772.06.EFA8F9C Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf09.hostedemail.com (Postfix) with ESMTP id B04C7140008 for ; Wed, 29 Nov 2023 03:58:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701230284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gylRB3zDeRjoP2wXb4Jc3mKfRNYjUK/0q343Sn6Q2Gc=; b=y4kH0q4ExdhqW+S8YQyzZPb672WYnYidoYQrE0c1ssxbr7KvZtC2rW3MIVews3p2PuCGHj Db5wfvWxrkVCiwDzpPl3jnwyRLaUtD3PT5TCH64W+5ESVl3N6NiX5N5efYeQgShfJTp/Ct hfa6a+RYGWwzAIU6R9FCOHFTMaEPDPw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701230284; a=rsa-sha256; cv=none; b=FJb57pdAoHSc6qCWMDUizYzwMBmO4PVZ+4sedyq7hc2b2tJ5qKOibYVqJAC2U/8G8VhLkO WfqJGLzAhqNN8LmYAurJ5IlAz/yY10WfLh05b1kG9L5J48C+p8g9sufXhx08/pFpbM2gb1 Isnaq7VLSMshWcBqCMWt1uZ9Bu/t89g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Sg4pX5BXSzvRBc; Wed, 29 Nov 2023 11:40:20 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 29 Nov 2023 11:40:51 +0800 Subject: Re: [PATCH net-next v4 3/4] skbuff: Add a function to check if a page belongs to page_pool To: Liang Chen , , , , , , CC: , References: <20231129031201.32014-1-liangchen.linux@gmail.com> <20231129031201.32014-4-liangchen.linux@gmail.com> From: Yunsheng Lin Message-ID: <844dc02a-3559-5a53-943d-28f772670879@huawei.com> Date: Wed, 29 Nov 2023 11:40:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231129031201.32014-4-liangchen.linux@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B04C7140008 X-Rspam-User: X-Stat-Signature: nsemxi4gyxhpdze3ir5rjifqkb3xnfo7 X-Rspamd-Server: rspam03 X-HE-Tag: 1701230283-271188 X-HE-Meta: U2FsdGVkX1/N/T+brK339WOLvpSdroHrsRJBDlAGUFL9GvMCaNHiESkK4ecqdl6l40NSCRMyXxr/uJ88/9GmpmZ4XYdCucw7//lCHI7haYSJEL+MKTS025CXNPCq4/7OaAHosQf1mxZiRwJ/KzX/QdTK3Wy7Vc9u0Wq154c1QamgvSaGKpZiZfP/9IG9Fw2M4SGVyCYireMIXkWdKpUxWb3r6ZMttearn65Oz/ma7SjXKl0h96vj2eTK5XHWcYuto2Ha2e0UZ4tKME0gJJsctn8gh0Bh5XJRbDvb4tAVm80cFy1cxfEL4NQua2xC6w/HSrbqBWomQPHk9RybIoNc8J2FATCW8XpUmjOhxIvz82YDdgSPsFRyWiaWYE4fRjB/CwOML3cFPX622sjb7BOtnP4Db8o6K9MUSMGzjZ79h0Drio4m4F60nmFP4F9g/M/ecrXSDm+xQ9/nptkNYltdBaw2+0kG8TIznaMoGJTC+mY3AxfXlNl7BInJlFejCT9fxRtMBRWnKsoo4etieJhUMahYIvbxzBkkKNcfee0MtBqIH4T9YLf5tAnOu7PSOyOSp5MHmlEArCyD/DRpmOeh9I096mxFB2GVpJaVntCUEaxzIu6BhTx2b+l+3FoIyoBmBTDTZJmMN025aU64DiI1HqMkPJCocba4PQm9/BQhPV5YSVtrs/Hq4d7xytLDAhOH2eNErH79TOTHKRTDcatpUnVs+fIAfS1HyMe0nxBBnBeQ6Ug3eppOLBbyymLiFapQQgnr8YN8OqAXKDdeAS+yIpzgTLO0A74y0FP93t9Clr1OAhWlQNDc1XoLZ4LGOhA7VVYX/lEWmCZMtPDu6Sz1BcCmOv5FIjaWaJ4RhBsSREwrXPJJvJCYZgPf/FyzKrHVIkhpwyrVZ2h/C+YDpArUK4qpcq97G9MiBT5AD5pKuTI/9OZBYp8rMpWt2HBtNQkT1/MMZcxMu8Y4sCFfsGY t7Z/0ZP7 y0lTma2j1a2YSimgUPft0etDQ/Ru+V0Gjr6Ivfd/qXHLjwoFSILuLAEW8r9H3cmwz3giR8DZ87oZyRzV84HysBxfmk1Rei7Bnjf2r5D4wctneuOmYW2LKHeIjKaWkjiD7PQg3Xl0Fn2zIHTJHToJydb3Oa2HbBvLsy4jb9dFQ8ndfghiZNbapipjnr4EjkCTifDuTgF6100E4kpMJqHz7hSm6UA6rRnyAdsR7B5JdLo5jNxhhRtvN9mTm1P+2ouu/vFJvNrgNRFqdkCfn2t8edQj5FN8mo1r+M4sDUhlacIA/kp/UwVtAJZMvolyfmrsCEe9Lu2zpyn8+HErPLHOpGVYN/ANFzVs3Vn1Q/ZC9J6mibas= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/11/29 11:12, Liang Chen wrote: > Wrap code for checking if a page is a page_pool page into a > function for better readability and ease of reuse. > > Signed-off-by: Liang Chen > --- > net/core/skbuff.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index b157efea5dea..310207389f51 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -890,6 +890,11 @@ static void skb_clone_fraglist(struct sk_buff *skb) > skb_get(list); > } > > +static inline bool skb_frag_is_pp_page(struct page *page) I am not sure about the 'skb_frag' part, But I am not able to come up with a better name too:) Also, Generally, 'inline' is not really encouraged in c file in the networking unless there is a clear justification as the compiler can make better decision about whether inlining most of the time. Other than the 'inlining' part, LGTM. Reviewed-by: Yunsheng Lin > +{ > + return (page->pp_magic & ~0x3UL) == PP_SIGNATURE; > +} > + > #if IS_ENABLED(CONFIG_PAGE_POOL) > bool napi_pp_put_page(struct page *page, bool napi_safe) > { > @@ -905,7 +910,7 @@ bool napi_pp_put_page(struct page *page, bool napi_safe) > * and page_is_pfmemalloc() is checked in __page_pool_put_page() > * to avoid recycling the pfmemalloc page. > */ > - if (unlikely((page->pp_magic & ~0x3UL) != PP_SIGNATURE)) > + if (unlikely(!skb_frag_is_pp_page(page))) > return false; > > pp = page->pp; >