From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B31E77180 for ; Mon, 16 Dec 2024 10:13:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B2AE6B0085; Mon, 16 Dec 2024 05:13:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7611C6B0088; Mon, 16 Dec 2024 05:13:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6283C6B0089; Mon, 16 Dec 2024 05:13:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 493726B0085 for ; Mon, 16 Dec 2024 05:13:48 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EFB41120AC0 for ; Mon, 16 Dec 2024 10:13:47 +0000 (UTC) X-FDA: 82900408836.17.A560E7D Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf29.hostedemail.com (Postfix) with ESMTP id 23F04120008 for ; Mon, 16 Dec 2024 10:13:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IQEOFIlJ; spf=pass (imf29.hostedemail.com: domain of akiyks@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=akiyks@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734344003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V9ZM1VYLJhmWw0JXWXrNZw/asAR3qnp4u24wAg0Zo6s=; b=rhjTp16RMOGrwkkaSzYhUORsTxwvB4dO1FQDuwPb4g65Ib1VhwnQmkR3LJm58zt1wmaMXq AaHI1GKtZDoclzjbIIDclKpin6MKTqezziKauQ9MOFcGHTIdkKUfbQCKN8cKVdiTi4E/jQ /KBQ6W6KGthcJsHGOACIckKHEEStWRQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IQEOFIlJ; spf=pass (imf29.hostedemail.com: domain of akiyks@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=akiyks@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734344003; a=rsa-sha256; cv=none; b=tp5RLeeBnF73lJRW/7gi79fNam/C26V5IamLzdYSQwOIeyclpzz/YCzOfa31aLAgQB0ySi T89+bLkLluxGb7rj3BHdDNcvVM/Lj09nOnR2ZIMjSByIMEGwO0/7xUwoCg6hfIr/8EYmBy SvUAjoEEni9PvyahKAWuxmrXxure0w0= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-725ecc42d43so3283646b3a.3 for ; Mon, 16 Dec 2024 02:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734344025; x=1734948825; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V9ZM1VYLJhmWw0JXWXrNZw/asAR3qnp4u24wAg0Zo6s=; b=IQEOFIlJsIKvWdKX+eGMNBzWRTPXPX1Ik6gFZAzDC9Pbcqjt/Dl1ZKOJm7T+rp9TD6 TZua+kulZu54z/6yw2abnBy17HV0RBWnUInZN1NDITfMZT9SzUINNSBa5qAhV59DADaq 3ACxbBzyaVYiB9XE1IxpIsf5RDS5XihxJY9w07PHsyYXDJ7Kxu+rJYD2GQK0wO96Rswi 6+/xsVSY5CIJa7SbY5y5oBnGWloXyn13OUK3/Evw6ySVYaNN4jw17OIS5O+YgnYSTCZu dqLvRbuEfn+2mky60xuMdWJAjQqrLkaq3Ml+oIwAF7sS9j1k3/H9ERMmLOxyiHQ/3l6a VzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734344025; x=1734948825; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V9ZM1VYLJhmWw0JXWXrNZw/asAR3qnp4u24wAg0Zo6s=; b=hTGfUij4wVvR614EQwKCVTh+7CW1ml6nRYin8ArHAXxsyBTzMGA49AYc6r6H10zQ1Q iIcLjx+oyVFU0CKHeljxNz15QoaCDK+yqPGDOkICPIQMcAihF97I60ZRn6WRvz0RX+FV AFXVNEVuN8Hs0A9LWCxqPr40nQLPuc79F3HoPEkOi6KaX9FOOiq9VLWgusgUTl1/8uWh H3CuijRQVH5kD9jryjVi2mEOLPhiOlggl0ssxrmkdNr80D5cn1i0MZH0+XBaREs1b3hX kst3rjZdUZkfRujmdc01bGzd2gz4rVSEme2VBctTSFD8ePTh1wK+/MPayWn6f5xHxBR0 0yUw== X-Forwarded-Encrypted: i=1; AJvYcCVedVeHwsDB19Zo5avw4hE9qH1NlgSCV7eSdLO8aPMXkgxyGI7Ody1IdhG2pICY8tzxst7fjvjPfw==@kvack.org X-Gm-Message-State: AOJu0YxIzckETJbabgA4oMapqQO4hjlNSCHqpo/i+XzwFBgCQMFtYUWg uthz3FWkimTz45xUX0JzZ0jEprBKhLEtHXkU9P2URCKZKRFxpwSL X-Gm-Gg: ASbGncsGudsi13vVGw4nUhDITCBGKc1KknrT9h0Jwc91S5Hnr0aJdik+NFjpCCiy2gQ XA2HotmdF2lfgXtD/sBat3iLshAPAhOKxRj5oVgh0Kp+YMtlzi6nxDUrs4gEzCzOl4k3YeEUq7M m6aHvstELWxydRsQ+/lbl5/5g/OwRgyfs5wmV8kMxIHjtQXBGMBDdI2XqINFoByvSmE6UTC3ebK c0jFkNcqzJdS86rVFRYgSOJinZfGeZ01BWOuooEPjotgEYW07vQTHImay9TvZcd75rJ9IeHjNqQ HSEAH8spv/OX/DQhBEnR0ME= X-Google-Smtp-Source: AGHT+IFq3zJyvoXfAV7XVBdCiDQC4vaO/7xLrUwixiOvu21RBmLw5wfgxXzoYw8zU6Yia4k+KM7puQ== X-Received: by 2002:a05:6a20:4304:b0:1e1:bdae:e045 with SMTP id adf61e73a8af0-1e1dfd91980mr18130458637.23.1734344023005; Mon, 16 Dec 2024 02:13:43 -0800 (PST) Received: from [10.0.2.15] (KD106167137155.ppp-bb.dion.ne.jp. [106.167.137.155]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72918bce39csm4517791b3a.189.2024.12.16.02.13.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 02:13:42 -0800 (PST) Message-ID: <843f5270-d715-4c98-b191-1c271eb418c5@gmail.com> Date: Mon, 16 Dec 2024 19:13:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/10] netfs: Remove redundant use of smp_rmb() To: David Howells , Christian Brauner Cc: Max Kellermann , Ilya Dryomov , Xiubo Li , Trond Myklebust , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zilin Guan , Akira Yokosawa References: <20241213135013.2964079-1-dhowells@redhat.com> <20241213135013.2964079-7-dhowells@redhat.com> Content-Language: en-US From: Akira Yokosawa In-Reply-To: <20241213135013.2964079-7-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 23F04120008 X-Rspamd-Server: rspam12 X-Stat-Signature: h3hoyyb1n9nax9sbjqjy9jq1es58twft X-Rspam-User: X-HE-Tag: 1734343984-415013 X-HE-Meta: U2FsdGVkX19zwNe4bHJjmiEXrI1bbEcp4A5wO2tKcNCZbU9lkpF36wCEhMOW6GGAmfeFb2prmOL98rD36O8Dr7DMzNwJAK8jhfqUypvsJ0qY7F6nGnN1eT+tZpkpbFWfXwCdsvd9vHhsYV98N5xjMP56JbKUg8JRMyOdsANLDk6HEjfREMhkBVpXpAkHylKNdZqR2JDeCpBBn8zMNJRXCJAbhvMY3kDOZayEGSqlN8ki6rhmOQO5hM4kVVA3BlRHFE4Z38W+UcG7/29OzfnajukhpVZ936CiO5r/k4z9v1BQSvGl7cbDFmGbhkZGj1tSNhMvlsdzweCToy540WEDM7NdFN2baAG5P0JBjHy0J9VcVVG5dYdgGvedOTtNyfQwR728wiaZSs6pJh1CIirYS1i3cMf+3Fip3MOTcSaoP3GEy/QJbRp4XsxocWzVDVGMeWQ3FLXxDP4fYcch5bLbyZR8VCK0T+Lv9Lhxd5KQBsTN9I4WFScGrVsMrrK+2QIk2WnYJ4oFQ7KNGJOKSGOSKeoTctMjKz0y7QY7TycHMmDTxHlhejbBy6cahHUBaEFrjW5hUWbeAA2MKDp6ES9XEQsHbuAf25Mq99ocapWWKf6H9gATq1oge9zmomHuIGaNnRuzDbHEcuhQzs0Ex6k+yHTe48rgjWwqbEs3+mz8ZOZzf6TShfCBRPlk62PXc4eETu3A627MrWkpepdL+w0Yx31tQWVlYqhspg4Gsb4RGnPQxMoU8gULrXBMwe2469VTTX21Mg1TRt02NLjpwyyzWY4XOP7rcUorzEvzDwrUbDWZsvvK4WOd8mqQbD6INcKoQmxtgJxfSvKns8DZde/vowgk6uCkLJCtQeHgvfXa0Q+OJR35PaoLqYq0RzJgmtnyy5QkKYF+V5Xo1fM4qAHWzoWbI3AJF7Fg02o6TubL2RfST25vURZwSp2a7AJJvjt187Sca0BOfJs474nBqt0 Fzu4oEQJ 5bUBv+XlrdRxwcreVhVfyzWJBnoNedBGHKzFxvbmV3tO6iPyk5/KRRx6Y6dzIIOCC3QymJ5isqI8ikwS89/20FEQjqP9upqto9fHFq+/6Hap6oM1r8chRAig3C5D8R0MUU467SKn+zE084z8UPgudqjXVwEnmlbHYQZKIfKyLizcSv2y7hdE2hS7IZE6e6pNEKdm1TbsUO9K0o09ALZFvV8ruhRQdn1kp6wHAfEdoHMHmVPPud2d3xS0XAfTXuK8m7LmL2ZmBtBc7k4KtUmXwQdoxn+WfJ8WT9cX1+4112QNdMQ2U+ipgUHiB0lHAijVe069AhqFm/eM8iksQhgy4g6IpOepn3VT+R+ioCWoXyvGaYQOvfbMLbbBPwznGqeEybz1Ub2q3hKpzHYnKz23fwrT1cZbmmepdVw44abpOAzCmiHUXFWfMI/5CPq+uANucx6gUi7r1zk7lYcaior/2ZVYrUYZWP6WWAztLN7yXFkRX99KU2/DjdmZG2SmZz8biGlqg2mfeDnR699c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.363008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote: > From: Zilin Guan > > The function netfs_unbuffered_write_iter_locked() in > fs/netfs/direct_write.c contains an unnecessary smp_rmb() call after > wait_on_bit(). Since wait_on_bit() already incorporates a memory barrier > that ensures the flag update is visible before the function returns, the > smp_rmb() provides no additional benefit and incurs unnecessary overhead. > > This patch removes the redundant barrier to simplify and optimize the code. > > Signed-off-by: Zilin Guan > Signed-off-by: David Howells > cc: Akira Yokosawa Reviewed-by: Akira Yokosawa > cc: Jeff Layton > cc: netfs@lists.linux.dev > cc: linux-fsdevel@vger.kernel.org > Link: https://lore.kernel.org/r/20241207021952.2978530-1-zilin@seu.edu.cn/ > --- > fs/netfs/direct_write.c | 1 - > 1 file changed, 1 deletion(-) >