From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CAEE77197 for ; Thu, 9 Jan 2025 17:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91C5D8D0001; Thu, 9 Jan 2025 12:48:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4336B00B0; Thu, 9 Jan 2025 12:48:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745488D0001; Thu, 9 Jan 2025 12:48:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4D6696B00AE for ; Thu, 9 Jan 2025 12:48:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E5E308032F for ; Thu, 9 Jan 2025 17:48:53 +0000 (UTC) X-FDA: 82988648946.14.6A589D3 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by imf08.hostedemail.com (Postfix) with ESMTP id D552516001C for ; Thu, 9 Jan 2025 17:48:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=cjlAjR8f; spf=pass (imf08.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736444932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7pSLBT5GTiy8l8cA8ZgCQNESRaMTsNJdWXHMYVnXF/Y=; b=TXz8gRyDpCxzN2PXKsnyGGtdsvQ3G6a5ZRloCTdygRAghGBg3U7CBGZKbpLi+UHwNHB+ok 4hp+9pGwCWps0YSXO2aHxT8hI89EhZSr/TYsQTcKWyTAo27ROIzIMmc+60rUkOx0ce/k4q g0zH0QVFeUBvjKRsNRdZ2jlsznz2aSA= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=cjlAjR8f; spf=pass (imf08.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.188.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass (policy=none) header.from=collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736444932; a=rsa-sha256; cv=pass; b=gnqPDJayDZ3F2W0luRVtUg+yvgodxJ5pUey8UGfkvDKjhv85F6Ch8NlOexDh9QGTlD1GBq 9PrrnnotKm4FX88C+npunuP7bCWYZYBOlmSy0QEIdb2ABryz3kIcWEFln3AZnS8gAKXJkr uVwr2ZX9U24OEkE/a5X3VNpRMgcbc1Q= ARC-Seal: i=1; a=rsa-sha256; t=1736444916; cv=none; d=zohomail.com; s=zohoarc; b=P0pxul2Nk8AjHyXJTKzJ9pxTFYhdycvBx244/JO0nBB+Gil3OnyEfRZtW8HQrWLtvAMWO29+oSFACZg/tj2NIfCmGzAVDciQ4eUbdeGq+tTGiDqJw9vWEIn9mwew2l+JM+9oAvsHu+OoZqUXD0CD6CTUrAkMCs4w1NUJD6BV5eU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1736444916; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7pSLBT5GTiy8l8cA8ZgCQNESRaMTsNJdWXHMYVnXF/Y=; b=IW6UHXr8pNwy3n07zwj58IVPs0ydsSh+iQnbU88bnoGRyC/h+kD2nJEGREHcYYlZjuN5vwXjmRZtwQWxx46zccH6Dy28qtCIRBa65Rj5gEnPZEuwXN3muYXtydfg5Tz7kmY448RhZJFTJhhAekgnByOA7PoVZIgu48+A555qRGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1736444916; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=7pSLBT5GTiy8l8cA8ZgCQNESRaMTsNJdWXHMYVnXF/Y=; b=cjlAjR8fgoxftjFZbW4V6qC2jyJxh7dM1OMeJ9sQTSXZkB1iNwm07PoixJCSySto tLVSPPv1yGK6vqL2xtCcGixkcnKsf5K9tton21SKmHHk+lXGfJZu8PTdKZO3HyCpzqi EGnb4DwsfxfPBNPECLur2YIdYxomMDQgtA5bv+vI= Received: by mx.zohomail.com with SMTPS id 1736444914002678.3576966097946; Thu, 9 Jan 2025 09:48:34 -0800 (PST) Message-ID: <843bf743-4005-47bc-9e39-8ea49255b152@collabora.com> Date: Thu, 9 Jan 2025 22:48:52 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Andy Lutomirski , Will Drewry , Shuah Khan , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters To: Kees Cook References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> <202501090941.5289E7444B@keescook> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <202501090941.5289E7444B@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D552516001C X-Rspam-User: X-Stat-Signature: 85iwop9tdi757f8d4beu4uwa44k867is X-HE-Tag: 1736444931-572311 X-HE-Meta: U2FsdGVkX18TSI0spk0fzyfREIb5DVs4lBNlQT3QCpolIl3nAXvEZgNjBvn5qY1y/00N50JC4cvsZXE1RnAmYWDbTCmI6Ras7i64RE5I6XmqJNkyFcw6BIPM9VqZgE00jeno6AQWA17Wq5rQN1E0682LsMriH0qKPb6l2bm//oybenvLUFIDds33vJcKA5KOtWfX+lilf+u7IvkzrmsnER9hYHRNBP96eOLLO93SuTlEl2XTBze54BM1rT6trsMx7ZM5GRvlkmq/6rioGG3ilyjnQGTcDEqcrRHcs8SykSrdgZNyIqXLN1Ts2X/3sWruIymEDFD+7KqvEotQvalh+Ow4frXTDesUx057QBM06pPpZe7l3jBTsDWlAoTKfu2O7h86eJZHvYTHOwbzKNgVkIVg1kMOsjutU+rc2r4zXp9TT3NtYLyn+u8DKSII9heoaAHJya6kI9y17JxVB0tGKzAqI2lNq8odVyzHG6GJWbzxA5rqu8YqdRsNlQKdB0AsvW5loqY8id5bb4vrYf1V+47/pjCur2QsjgN/PpdNC/EbVaxk66395AGXn7Xes9lgH3Vm4gq6as3RLovJ30GVcV13jjPgAzfaziHytXa/sKIaPzdp3YPNacYwEMg1h/DZNYykF8k18dO17s6Mv/hcK11fAyULje51JEacLG/v8CuT0mY5f9LBJJjSvjZpN5Rp4A4kRfr80doXXv6iHA8A9+LM91dtAoVjDZM8dw0zEW/xzwvfF2gGIJTxFhatxF0HffYUKkFXyJuclQJL6ddk3DpI4zR8+b5m7zycDyXhAbpIQ0HVbsnHk0UYtDe+9P4eqWNh+J+pGmsBMqIMjrhzFBQjuFufgSmhkMkrbzjDIwJxIlPY3Z57gKgS11RzoFrT1RkuM1pCqYJFj6+pvq6YWZB7J9afDPD5i69fnSxDJrVb8vR4YZqAbyrntogtjhaURhmhjXZLT5naU4HV/ix 5pAA0RJ/ +6sZE0IbdsbopxnF/VjmP20+f398AKvQ7RcVKd6XrFc65bM9SH2yZskPbvSEqK5OS2bDJ0xtpWCwr6+6/aGnwFDLEjiZhSwQqpqp/TrAk9UYVTozwnvbjr1ct98os23KBVEzB8sYmfPchTRJVHTFjj4G8ZyesYKuYtDvqaCHWDH7n+EyXa23/LBOdltKA32IWpWJiirRXpQ3mDCE1ShMioeyX3OLzY8aWhBaCti7iNswsEbexbCQecCpIp7fsocfn7nVR9wNu38xjvV26DejVq+CJJzPSYWQ7R2iVFbPbtUUsQMaNIx6gJu1gkAGzWzgSmWmLgk5BXOmHYSEWq61mns2PS56xXs/zPf8153kTT+2UtvE19O6YXqHIIX6OHRWDyUyvChdEQAV8YAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/9/25 10:42 PM, Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: >> Remove the following warnings by removing unused argc and argv >> parameters: >> In function ‘main’: >> warning: unused parameter ‘argc’ [-Wunused-parameter] >> 158 | int main(int argc, char *argv[]) >> | ~~~~^~~~ >> warning: unused parameter ‘argv’ [-Wunused-parameter] >> 158 | int main(int argc, char *argv[]) >> | ~~~~~~^~~~~~ >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> tools/testing/selftests/mm/compaction_test.c | 2 +- >> tools/testing/selftests/mm/cow.c | 2 +- >> tools/testing/selftests/mm/droppable.c | 2 +- >> tools/testing/selftests/mm/gup_longterm.c | 2 +- >> tools/testing/selftests/mm/hugepage-vmemmap.c | 2 +- >> tools/testing/selftests/mm/hugetlb-madvise.c | 2 +- >> tools/testing/selftests/mm/hugetlb-soft-offline.c | 2 +- >> tools/testing/selftests/mm/madv_populate.c | 2 +- >> tools/testing/selftests/mm/map_populate.c | 2 +- >> tools/testing/selftests/mm/memfd_secret.c | 2 +- >> tools/testing/selftests/mm/mlock-random-test.c | 2 +- >> tools/testing/selftests/mm/mlock2-tests.c | 2 +- >> tools/testing/selftests/mm/on-fault-limit.c | 2 +- >> tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +- >> tools/testing/selftests/mm/soft-dirty.c | 2 +- >> tools/testing/selftests/mm/uffd-wp-mremap.c | 2 +- >> tools/testing/selftests/mm/virtual_address_range.c | 2 +- >> 17 files changed, 17 insertions(+), 17 deletions(-) >> >> diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c >> index 2c3a0eb6b22d3..8d23b698ce9db 100644 >> --- a/tools/testing/selftests/mm/compaction_test.c >> +++ b/tools/testing/selftests/mm/compaction_test.c >> @@ -194,7 +194,7 @@ int set_zero_hugepages(unsigned long *initial_nr_hugepages) >> return ret; >> } >> >> -int main(int argc, char **argv) >> +int main(void) >> { >> struct rlimit lim; >> struct map_list *list = NULL, *entry; >> diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c >> index 1238e1c5aae15..ea00c85c76caa 100644 >> --- a/tools/testing/selftests/mm/cow.c >> +++ b/tools/testing/selftests/mm/cow.c >> @@ -1769,7 +1769,7 @@ static int tests_per_non_anon_test_case(void) >> return tests; >> } >> >> -int main(int argc, char **argv) >> +int main(void) >> { >> int err; >> struct thp_settings default_settings; >> diff --git a/tools/testing/selftests/mm/droppable.c b/tools/testing/selftests/mm/droppable.c >> index f3d9ecf96890a..90ea6377810c5 100644 >> --- a/tools/testing/selftests/mm/droppable.c >> +++ b/tools/testing/selftests/mm/droppable.c >> @@ -15,7 +15,7 @@ >> >> #include "../kselftest.h" >> >> -int main(int argc, char *argv[]) >> +int main(void) >> { >> size_t alloc_size = 134217728; >> size_t page_size = getpagesize(); >> diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c >> index 9423ad439a614..03a31dcb57577 100644 >> --- a/tools/testing/selftests/mm/gup_longterm.c >> +++ b/tools/testing/selftests/mm/gup_longterm.c >> @@ -444,7 +444,7 @@ static int tests_per_test_case(void) >> return 3 + nr_hugetlbsizes; >> } >> >> -int main(int argc, char **argv) >> +int main(void) >> { >> int i, err; >> >> diff --git a/tools/testing/selftests/mm/hugepage-vmemmap.c b/tools/testing/selftests/mm/hugepage-vmemmap.c >> index df366a4d1b92d..23e97e552057d 100644 >> --- a/tools/testing/selftests/mm/hugepage-vmemmap.c >> +++ b/tools/testing/selftests/mm/hugepage-vmemmap.c >> @@ -87,7 +87,7 @@ static int check_page_flags(unsigned long pfn) >> return 0; >> } >> >> -int main(int argc, char **argv) >> +int main(void) >> { >> void *addr; >> unsigned long pfn; >> diff --git a/tools/testing/selftests/mm/hugetlb-madvise.c b/tools/testing/selftests/mm/hugetlb-madvise.c >> index e74107185324f..43f16c12c8e9a 100644 >> --- a/tools/testing/selftests/mm/hugetlb-madvise.c >> +++ b/tools/testing/selftests/mm/hugetlb-madvise.c >> @@ -58,7 +58,7 @@ void read_fault_pages(void *addr, unsigned long nr_pages) >> } >> } >> >> -int main(int argc, char **argv) >> +int main(int __attribute__((unused)) argc, char **argv) > > Can we add a macro in kselftest.h for "__unused" like the kernel already > does? It can be done. But as there kselftest patches aren't regulated as much as other kernel patches, people may still not use this macro and use the gcc attribute directly. Let's see what others have to say. > Then instead of removing args, we can just mark them, like you're > doing here. In this case, argv is being used while argc isn't being used. I didn't find a way to keep argv and remove argc. Hence I marked argc as unused. For the all other case, why should we keep argv/argc and mark them unused as well when they aren't being used? -- BR, Muhammad Usama Anjum