From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADC0C47DD3 for ; Mon, 22 Jan 2024 09:51:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D9296B0087; Mon, 22 Jan 2024 04:51:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 489316B0088; Mon, 22 Jan 2024 04:51:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 377A36B0089; Mon, 22 Jan 2024 04:51:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 256B16B0087 for ; Mon, 22 Jan 2024 04:51:10 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 03DC3140596 for ; Mon, 22 Jan 2024 09:51:09 +0000 (UTC) X-FDA: 81706478700.14.01ABA71 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf10.hostedemail.com (Postfix) with ESMTP id 2A3E1C0012 for ; Mon, 22 Jan 2024 09:51:06 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Yk8ugVUB; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705917068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wuYC06RX3OtM9f7oUAxUdtkdP4RrZ1CoNtn1dGQVcuw=; b=eYMiKSPGTgftuzX+6siuEsbzTbkMUXKdURTYBE9wkWXd7PUkv5WAk0Lgi+stXS6iLL1RYb X3Bu6e36eWoEU3bCuuEQiHV5sdt7SblGkFA3ruwST/VVJWzBw4vhlLeBdVKeO2H0mr5P02 RQFAd8gCiLpmlrTTEXXhNa9USLq/zRc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705917068; a=rsa-sha256; cv=none; b=7ifDnvv+EmoHpywhF6F7HMO76Jb/Yr2aZtg97Wqea7FEvlDCC7krk0Mo/4a5vd5W2FBjLG DRpzNSLEepl+2bIs7fEw+IUtbnV2v73LIziktILLUOsmrhiaVFp6/UO6e7AQjb8QtwvDec xeWTl3Z7yn9FmjfjZXi5PXmLuWhCIp4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Yk8ugVUB; spf=pass (imf10.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705917065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuYC06RX3OtM9f7oUAxUdtkdP4RrZ1CoNtn1dGQVcuw=; b=Yk8ugVUBfKEAMZ0SoNd9vUrDnjdTkUXZ3EdpoOmDf9zJcVu76WkfDSXoDfd9p2C1620yZh QkHajUAFf5P8I7HJ5vuvu6uqRpvePsmntng+NB8tRw8R9pE78BDgFFbsyMH80uBQj0Qm2j bWZG3e2tiWPC814YXlaDIS9AjbU8TOA= Mime-Version: 1.0 Subject: Re: [PATCH v4 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Mon, 22 Jan 2024 17:50:26 +0800 Cc: David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen , Linux-MM , LKML , ligang.bdlg@bytedance.com Content-Transfer-Encoding: quoted-printable Message-Id: <84380389-0922-4073-B4C7-DBF9F865E162@linux.dev> References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-5-gang.li@linux.dev> To: Gang Li X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 2A3E1C0012 X-Rspam-User: X-Stat-Signature: 6jxnf3q4gtjkb6nkx4x4ktqrr9escpim X-Rspamd-Server: rspam03 X-HE-Tag: 1705917066-382464 X-HE-Meta: U2FsdGVkX1+4vBncOmEGODbUbESiuWWFj0OxqIEzc9pxTZjVMHtJCSxrPvR6X9LZLgcuMcZqMuT0434urs20on65NVFYE6WjX/iTpkNDUJxDZ0cJCKgoZ3v8RVSWQiQ3/icbJLZRQbo+zc0gqy7csbN3NMeE/THG9i73IwG2gAH5xRWeurDvVFxO3r3deAl8FiSxJuyc/MZYFMo5aOB+oBkTSKVThO5FZNwQfp5+rqz6CpyNRQFqxto0oC0qCGhf356e7VvufZnUEui9ZeXDncJwMTnwpEQzrCMReQIy0gZHu55J0ecJ2J0uMXIOeqCu2uKF8T9DbGdhyixmXvb4GpaMB3yU7Fs6fx3AZ9wCw/czWKu/JyR8HUYRip/DI1PKikIXxTC7CzNW5AbqEd6l/aU9Wz/S6rACqD9HV+0MdgJM2XBaPmmRrXtALpHoNy2XjQUltYRwAMhhGNw2fino+Br9ohvzjMhSOXpCii2dehyyd5wn4xTvDtG2ediN4Q/nx46EgmuZxeqV1GqWCZyO7xqQlyvohsXXmx2U3iEoGei6JyLH01lWkuQRVoHXFyPYpLrVzdiNbOEjoNr/gIrPXb90epiZtJHxoZ0GUJFrjhtqIriwhGN/KnbLVP+ernT9+vEeWOHNnQIQf5eezF1AkWbDbIzvi+Sbnf3FkqEarX3yn5sFRCrSKAym6on6DT4uimP9ePdGMP1/0UbI9YkRcuaB5VBj3Ivt+4ti90QGmryvH2nPy9gW41CjTvbcSfpsU4kRuNCn7mQEWbGEZ1oxTaapfUutF3CdB5zZbM1rolIeehYHm1I7gyLmGnB3P27xLKnlkyQ/ICC2NhpJ6+v2Qcq5fsh5Dz5Jh9ffCJr4pwjDy/snlWch3GvdaIo4q4ctMDyICEHpizXIsCOQT5EUvdaUlsreV9TRYQEVuTTXEcnVkTOPsfedogFYV82cSyngyEI3sWTcoqWeuIPw4dg W/Y1U9Rx MKXNKL7egi67yPrsFw5kjGKj2jA2qWV4CoqSm76PBtiJfXSca6KagCXVyE63W7qa9NgnkBBayMgjLXbiNRGtodFfulPRK5xJ8J58ip/W/fVY7JA777Vh+TfrK7lu8V+urJPG2i6OL4Ybnl/R7c60PH9VTUEabpeZW+eu0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jan 22, 2024, at 17:14, Gang Li wrote: >=20 > On 2024/1/22 14:16, Muchun Song wrote: >> On 2024/1/18 20:39, Gang Li wrote: >>> static struct folio *alloc_pool_huge_folio(struct hstate *h, >>> nodemask_t *nodes_allowed, >>> - nodemask_t *node_alloc_noretry) >>> + nodemask_t *node_alloc_noretry, >>> + int *next_node) >>> { >>> gfp_t gfp_mask =3D htlb_alloc_mask(h) | __GFP_THISNODE; >>> int nr_nodes, node; >>> - for_each_node_mask_to_alloc(h, nr_nodes, node, nodes_allowed) { >>> + for_each_node_mask_to_alloc(next_node, nr_nodes, node, = nodes_allowed) { >> A small question here, why not pass h->next_nid_to_alloc to >> for_each_node_mask_to_alloc()? What's the purpose of the third >> parameter of alloc_pool_huge_folio()? >> Thanks. >=20 > In hugetlb_alloc_node->alloc_pool_huge_folio, hugetlb is initialized = in > parallel at boot time, then it needs each thread to have its own > next_nid, and can't use the global h->next_nid_to_alloc. so an extra = parameter is added. Yes. When I read your patch 6, I realized this. >=20 > And h->next_nid_to_alloc in set_max_huge_pages->alloc_pool_huge_folio > can not be removed. Because if the user calls set_max_huge_pages > frequently and only adds 1 page at a time, that would result in each > request being made on the same node if local variables are used.