From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E52C7EE25 for ; Mon, 12 Jun 2023 09:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5A666B0072; Mon, 12 Jun 2023 05:44:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0A6E6B0074; Mon, 12 Jun 2023 05:44:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD10B6B0075; Mon, 12 Jun 2023 05:44:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AE4DE6B0072 for ; Mon, 12 Jun 2023 05:44:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 547CA1A0172 for ; Mon, 12 Jun 2023 09:44:44 +0000 (UTC) X-FDA: 80893611288.23.A1D8745 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf17.hostedemail.com (Postfix) with ESMTP id 151AD40023 for ; Mon, 12 Jun 2023 09:44:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AfY1NP/Z"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u5qYZVGz; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686563081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Emr8M0/RctObEKZRro6J+KUvO1Jejbj0oVC9sdgo18=; b=NUV8zPV7Y9MF1h+Mt4XpuHdDUyzG5WOoLcfhPWqSYRHT7A7sqGEeyJaKC6EfORGt8igiKI zHVGxw4HRSGhjtPIjKg5U/H+YPm+kyGdIi8rf/CegJjgJdlILGaopxtQpGciM6g04Lh8kx 2oGIXouWfBolHt9hyBsNt6G9mzl6Adc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="AfY1NP/Z"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=u5qYZVGz; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686563081; a=rsa-sha256; cv=none; b=mscCw3DKCr1Wor40eNwupfUC9thtY8keIFd5nELTs98k2Wo6BNjh+pGW0koOJiX98c9Yfj JDMCmlapzsGLfoQoxXFFE8c38aYvjdD4JR/67M3yDHqq0CTUQWFLs0bP/5DMMAxn/XOSRr 2GFM6BMZXrcdT1c64SKHwzOLBtABjQ4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6FB5322807; Mon, 12 Jun 2023 09:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686563079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Emr8M0/RctObEKZRro6J+KUvO1Jejbj0oVC9sdgo18=; b=AfY1NP/Z0L5vDzsPzh2dXfKQPZg/c3D/aXYWYht0BwakIwQwDRIHIQaHhxgvaIb0luiXcP styc8uoqUJtTHTXuwCqJHqVYPjJBLF54NRV4Zr8M6jS4qLy/gFDvjHvujY6RbSgKhSLLaT 2Mh1BrphZETRWhxe/4WbnT83IFG4wjs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686563079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Emr8M0/RctObEKZRro6J+KUvO1Jejbj0oVC9sdgo18=; b=u5qYZVGzTsyIez8we60vnEQWNtD7lamS6oIVZZqutIuHQ/VCiWPZnT1SXCLPL4fKPhWPoO esOMLgs+Nz3ur7Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4602F1357F; Mon, 12 Jun 2023 09:44:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bOldEAfphmRtFQAAMHmgww (envelope-from ); Mon, 12 Jun 2023 09:44:39 +0000 Message-ID: <8427ebb5-61d0-f0ad-3bfa-6aaf575427e4@suse.cz> Date: Mon, 12 Jun 2023 11:44:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v4 0/3] page_owner: print stacks and their counter Content-Language: en-US To: Andrew Morton , Oscar Salvador Cc: Alexander Potapenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Eric Dumazet , Waiman Long , Suren Baghdasaryan , Marco Elver , Andrey Konovalov References: <20230421101415.5734-1-osalvador@suse.de> <7718244879ff2b696ea9cbb744cb3805@suse.de> <20230609145505.dc30b7712779d990aba64372@linux-foundation.org> From: Vlastimil Babka In-Reply-To: <20230609145505.dc30b7712779d990aba64372@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: cpqzpg1phr4abtxu1jgekx38mzx5mwnm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 151AD40023 X-HE-Tag: 1686563080-748078 X-HE-Meta: U2FsdGVkX18LJV7Fka5dkQW2/qoqxImDXKuQ9zGz5gFsxMccAjRppvNjX+FDB3J18WDl5oaidLEEMTJuP/ursBuJKs35X9W/54AiJZjD4HXj76TlFuSG8J9ef2MC8ixkzdH6p5iH5qQlNgDVoMe4WD/Zs3l+TobZFj8aGyhVhTL1qFNWGJehaKQCkkVLBNxmmvDOs2RTwKIL5Fs+iJBqxj7W3qphxs+nJ9ZLpZy69SxSCTt2glwUMYbHk1IsE9qDWp14T8d5OGCG5chYuPIWWpCdAbfPOHEasyfKOe0XevDebhlaO5XUoiP9sn9mnqWriu3lsc65PBqE1MeepHCF8gG9f0o9dQ+XACA9F4/oImBNQlnlXEYtcoPOyHCHrm9mVpDoWGaeHDPbNdTDSmbiNDZ9Ci1KtU3mZ5Q2WeSTVLnlYwfL+nYZzGe9Jv50Q98rZZy8etEf7B91AOAX+KlPFq4A9IMB0XMHrFee55OdX7g8LoL039ZpHUot3icsVG33yMWKcQvvSZjWqdPFEEKLltFtMA7eUHGejR/VwB+UAO8kMuEp0MFv742DfBhttp4/lVwMG/O4o4noy2VfFi4O+2l8/L8otZqYIbsfRU+qs0DMp488UEqR4rPD3bl1JfZwGE5aZmwHizwDwfO8L2B9FrhD3qK7dpD2qi4JlasycLkIuJUYNwwI3xCVzQH9Pnq0+4d0InIPPdUEPxxcgmHk9s1aJoyUmZXv4dT8U0ZTogZVGe6EM86Ih8rje8q0i4J/J2i5BlO+htsox0GMiTzTBb1pO1f2PnlHia8W5x1zzlgCqsG4sVYyEbH31QODpmZUTjvvt6Ll4RLa4Z/G/syehQ2QENjgb9EOLYZ8bXyla1Dae8StApeZocfLxZGAHua9Yzx9hrq481juTtahlbMAhIEiPqdNhTA08wQOaEZERfwg+d8vzETEsl65eGnQ2h932WNIXmz/aTiGLSaAqzf Ml/eZpRO iVGauJuMfs7at9ZceVHhkI4zHCQWs87B8yLIFIrvn4SsvW8xg9R146mCwKJouKtJHSfc7Uq56XCEkoXPIkVhL0qwQ2tl6QNlaQ5z5Zk87IazCYvoCkErajAIDOYyJK7E78gmdMqoyKncWBqBe78RcWnlAF5yhH6IpDk3Yw3JWyGSUnDzAhM7kDTK+cDnGkfxwUZw7YWOygd2qq2WCKIWdzsvVYGGooFOdvfuuffKy1rCDGC6LTJ8G5DhTkKTm78qRMq8UkknTbfNl4+Jhk4ohyYfXAwOgwHQAWfvcgZm/r6mT4MIdAnmaZosSuEdcThylsmmyy7MQAiPRY0g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/23 23:55, Andrew Morton wrote: > On Mon, 24 Apr 2023 05:54:59 +0200 Oscar Salvador wrote: > >> > Given that no other stackdepot user needs these counters, maybe it >> > should be cleaner to store an opaque struct along with the stack, >> > passing its size to stack_depot_save(), and letting users access it >> > directly using the stackdepot handler. >> > >> > I am also wondering if a separate hashtable mapping handlers to >> > counters would solve the problem for you? >> >> Let us see first if with the changes from above the code gets to a more >> generic and clean stage, if not we can explore further options. > > Alexander, does this approach sound reasonable to you? Note this is a v4 thread; there was (and the version in mm-unstable is) v5, where the latest was Alexander requesting further changes: https://lore.kernel.org/all/CAG_fn%3DUJgnLFGgpkXbMeD6axZN_ifEPHvWpy2_oiPyG1a6PXng@mail.gmail.com/ > The overall feature seems useful, although I'm not seeing any positive > reviewer feedback.