From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB00C433ED for ; Thu, 15 Apr 2021 12:45:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 174FC61249 for ; Thu, 15 Apr 2021 12:45:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 174FC61249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B30F6B0036; Thu, 15 Apr 2021 08:45:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A026B006C; Thu, 15 Apr 2021 08:45:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82C5D6B0070; Thu, 15 Apr 2021 08:45:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 66D516B0036 for ; Thu, 15 Apr 2021 08:45:17 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 18C9A181F24D2 for ; Thu, 15 Apr 2021 12:45:17 +0000 (UTC) X-FDA: 78034571874.39.37A2C98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E602E90009F3 for ; Thu, 15 Apr 2021 12:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618490716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZqHGFCvK29UwMdI5PwYAwX9JWMxR/Nky/E74KukpUQs=; b=eKurz9MSXiVPxcCS5Le/IOqrkZ6Xmd/K48a7VA29iytQh+zmnZmRn1d4E/6JAY9yEEBwYl yGCF1lZ25TjM8hy679Vf8eKAYKCfchzTahpA3PY0UAXsNhbL5BTc3Kxq1iSrG0dOjOB6xv oMYgmErBtJsZJiPMyn+gjy+ORz19twQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-XYM0Ff6ENTOIaoEDUn2f1Q-1; Thu, 15 Apr 2021 08:45:13 -0400 X-MC-Unique: XYM0Ff6ENTOIaoEDUn2f1Q-1 Received: by mail-wr1-f69.google.com with SMTP id 91-20020adf92e40000b029010470a9ebc4so1633351wrn.14 for ; Thu, 15 Apr 2021 05:45:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZqHGFCvK29UwMdI5PwYAwX9JWMxR/Nky/E74KukpUQs=; b=iODVNzxOzKaWu0TJ8mcFtF8LVp4nr79x+mIyQhlPFO3MnVD7/4LkoDj/3UOHfEgi+Q EHwRgPCmoysLPg3da1UIh02qRXnp5VmzMT6QygLYOoHkEtioX0Foe6q8XjeM2xEXzvRB 56SyzsTZ6SsdsyLwqBWotjpd0X57wYpoIRIZcSxLWxzPFtCFZ7ounS7HFI9381So/Vp4 nvIU2U1QPDP3psAxg76kaDbf9tX74xPrm/xu1cCC9Dv4CHvgceMM0Ih+XKCDIS0D5AfZ UckuupzYmpSuT5AWpalaSoTKoNUZ2cZby5p8QZRRyVv5QwKGOHxBgkfrLIlsj6xGWhFh VZ1Q== X-Gm-Message-State: AOAM530y6tApSwlGCLeHSEw5vWPga2oQYsSDeSbnwaqmWDTfvhqwdFdz 2cDCe3qpaXjWcO61sr1231EZ9VGXzZVGOG/FdNRZY7KB1hSXLs7IMKzQS8FehRUZl2ArxFaRSDx rtRSL43Kn860= X-Received: by 2002:a5d:63c9:: with SMTP id c9mr3359372wrw.425.1618490712139; Thu, 15 Apr 2021 05:45:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMaAmTfm/cuiA0oqyYDs9Eyq2Ea+4iqwmTuqJrN3WSA1Zy0Qpi7vwNSaCPUWitC79QjKiNDg== X-Received: by 2002:a5d:63c9:: with SMTP id c9mr3359351wrw.425.1618490711936; Thu, 15 Apr 2021 05:45:11 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6392.dip0.t-ipconnect.de. [91.12.99.146]) by smtp.gmail.com with ESMTPSA id u2sm3028556wmm.5.2021.04.15.05.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 05:45:11 -0700 (PDT) Subject: Re: [PATCH v8 5/7] mm: Make alloc_contig_range handle free hugetlb pages To: Oscar Salvador , Andrew Morton Cc: Mike Kravetz , Vlastimil Babka , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko References: <20210415103544.6791-1-osalvador@suse.de> <20210415103544.6791-6-osalvador@suse.de> From: David Hildenbrand Organization: Red Hat Message-ID: <84268789-379e-2b45-1637-1877652cd6c9@redhat.com> Date: Thu, 15 Apr 2021 14:45:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210415103544.6791-6-osalvador@suse.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E602E90009F3 X-Stat-Signature: i9ts99f7wpkdnrheoc8nxqdoqbkd1f97 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618490699-106029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + if (PageHuge(page) && cc->alloc_contig) { > + ret = isolate_or_dissolve_huge_page(page); > + > + /* > + * Fail isolation in case isolate_or_dissolve_huge_page() > + * reports an error. In case of -ENOMEM, abort right away. > + */ > + if (ret < 0) { > + /* > + * Do not report -EBUSY down the chain. > + */ Nit: can fit this into a single line. > + if (ret != -ENOMEM) > + ret = 0; Nit: I wonder if ret == -EBUSY would be clearer. > + low_pfn += (1UL << compound_order(page)) - 1; > + goto isolate_fail; > + } > + > + /* > + * Ok, the hugepage was dissolved. Now these pages are > + * Buddy and cannot be re-allocated because they are > + * isolated. Fall-through as the check below handles > + * Buddy pages. > + */ > + } > + [...] > +/* > + * alloc_and_dissolve_huge_page - Allocate a new page and dissolve the old one > + * @h: struct hstate old page belongs to > + * @old_page: Old page to dissolve > + * Returns 0 on success, otherwise negated error. > + */ > + nit: remove that line Acked-by: David Hildenbrand -- Thanks, David / dhildenb