From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26926C43334 for ; Thu, 7 Jul 2022 03:08:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91E616B0072; Wed, 6 Jul 2022 23:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CE336B0073; Wed, 6 Jul 2022 23:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BCED6B0074; Wed, 6 Jul 2022 23:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6C24B6B0072 for ; Wed, 6 Jul 2022 23:08:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45DC133B07 for ; Thu, 7 Jul 2022 03:08:11 +0000 (UTC) X-FDA: 79658819982.15.86E3010 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf19.hostedemail.com (Postfix) with ESMTP id A5C251A0057 for ; Thu, 7 Jul 2022 03:08:09 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LdhBJ1XdFzcmyV; Thu, 7 Jul 2022 11:06:00 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 7 Jul 2022 11:08:02 +0800 Subject: Re: [mm-unstable PATCH v4 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Naoya Horiguchi , "linux-mm@kvack.org" , Andrew Morton , David Hildenbrand , Mike Kravetz , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , "linux-kernel@vger.kernel.org" References: <20220704013312.2415700-1-naoya.horiguchi@linux.dev> <20220704013312.2415700-6-naoya.horiguchi@linux.dev> <9aba706c-b38f-f887-486e-b60c0025d9d8@huawei.com> <20220706230627.GB2560241@hori.linux.bs1.fc.nec.co.jp> <20220707013500.GA2578896@hori.linux.bs1.fc.nec.co.jp> From: Miaohe Lin Message-ID: <84243531-8c37-1bed-bfd9-36ed0ad0b809@huawei.com> Date: Thu, 7 Jul 2022 11:08:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220707013500.GA2578896@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657163291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UowzuKeDwiYefMTy6HIcmmPCcMx69Y5Vj7aJqgBXEgk=; b=IAyhuDhr3P5zA4yoBlFalv0/9fvmwFDs3rCAaNPpffLDWrbvQgoTzE2hdoYqxYvevZiBr2 IEzdT3pl/EYH9TUj+KkFYdK8sCp13T9ElxwbNGFMYBmWbUB8XJLo1yCSeD9udGHn7gLo5O wE1MlblHy2bQkC5QTP0iGk7DMEO8/wA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657163291; a=rsa-sha256; cv=none; b=KutGudJ4AUE9laYnafzNqC/WfkUmVqlyEhCpJLryMiFgf21+rI5N158XKIc75+DpguGhZ/ Ey5dHRaZr8DP2G3Vicdbq6m8L3OYY6399nJh69If8dbdbAbBCVqPHOFMkmpPtA69ABihjf AO3PwYqrxpF2gMrE5Jhte/SXsLSy8H8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A5C251A0057 X-Stat-Signature: s4dqx5bhxaow4uy3ydqn3z5r5d4gq7ht X-HE-Tag: 1657163289-839438 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/7 9:35, HORIGUCHI NAOYA(堀口 直也) wrote: > On Wed, Jul 06, 2022 at 11:06:28PM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: >> On Wed, Jul 06, 2022 at 10:58:53AM +0800, Miaohe Lin wrote: >>> On 2022/7/4 9:33, Naoya Horiguchi wrote: >>>> From: Naoya Horiguchi >>>> >>>> Raw error info list needs to be removed when hwpoisoned hugetlb is >>>> unpoisoned. And unpoison handler needs to know how many errors there >>>> are in the target hugepage. So add them. >>>> >>>> Signed-off-by: Naoya Horiguchi >>>> --- >>>> @@ -2287,6 +2301,7 @@ int unpoison_memory(unsigned long pfn) >>> >>> Is it safe to unpoison hugepage when HPageRawHwpUnreliable? I'm afraid because >>> some raw error info is missing.. >> >> Ah, right. We need prevent it. I'll fix it by inserting the check. >> >> static inline long free_raw_hwp_pages(struct page *hpage, bool move_flag) >> { >> struct llist_head *head; >> struct llist_node *t, *tnode; >> long count = 0; >> >> + if (!HPageRawHwpUnreliable(hpage)) >> + return 0; IIUC, even if we return 0 here, the caller will still do TestClearPageHWPoison(please see below code diff) and succeeds to unpoison the page. Or am I miss something? @@ -2334,6 +2349,8 @@ int unpoison_memory(unsigned long pfn) ret = get_hwpoison_page(p, MF_UNPOISON); if (!ret) { + if (PageHuge(p)) + count = free_raw_hwp_pages(page, false); ret = TestClearPageHWPoison(page) ? 0 : -EBUSY; } else if (ret < 0) { if (ret == -EHWPOISON) { > > No, I meant "if (HPageRawHwpUnreliable(hpage))", sorry for the noise :( No, thanks for your hard work! > > - Naoya Horiguchi Thanks. >