From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9714ECD98F5 for ; Wed, 11 Oct 2023 07:01:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 326BD8D00EC; Wed, 11 Oct 2023 03:01:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7EA8D0002; Wed, 11 Oct 2023 03:01:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19E468D00EC; Wed, 11 Oct 2023 03:01:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B4558D0002 for ; Wed, 11 Oct 2023 03:01:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BB6FC1401B4 for ; Wed, 11 Oct 2023 07:01:21 +0000 (UTC) X-FDA: 81332284362.24.741A64A Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 74F3240011 for ; Wed, 11 Oct 2023 07:01:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=none (imf11.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697007679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpAHabltl5NdzNxi3rJcru+SqIFteujeseixTkrPCWQ=; b=H7t7fIhgY+9W4XbQGAcJcfg9GCcNnKyM+oLxJEIUunoOuliu1jrSfJltzJiUVYBJsBvMPe 3xk4dGiTAnr8NsddVDhmiuetvzeHzymMTWf1/cO418/RGBt2vjAawSTNotNh0Oax9VHmai FyYsqL4xwua4skcfbuO32SK/2RPKK1A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697007679; a=rsa-sha256; cv=none; b=KbWxr9Ybs3UGs17JtefuTRIkE4cFWsFeUX4H+keut8HxJoBF5QT3edhtK5wrpD0YnwQKog JMmLXuDuGlN8mwRo0iD56tpqFWy6w3RXnxploaHDbtX3TlIAGhM44uyiqQcmk+YjlD0shC HP4qJPl5bRH2q/LNEMiA59WLsHfUCPY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=none (imf11.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4S537N2GyHz4f3jqV for ; Wed, 11 Oct 2023 14:40:48 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP3 (Coremail) with SMTP id _Ch0CgDXGztuQyZl34QNCg--.7060S2; Wed, 11 Oct 2023 14:40:49 +0800 (CST) Subject: Re: [PATCH bpf-next 4/6] bpf: Move the declaration of __bpf_obj_drop_impl() to internal.h To: Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , houtao1@huawei.com, Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton References: <20231007135106.3031284-1-houtao@huaweicloud.com> <20231007135106.3031284-5-houtao@huaweicloud.com> <20231009165642.vhxucl2nqnolspnw@MacBook-Pro-49.local> From: Hou Tao Message-ID: <84184a18-f73b-3f21-ad22-327d452713d9@huaweicloud.com> Date: Wed, 11 Oct 2023 14:40:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20231009165642.vhxucl2nqnolspnw@MacBook-Pro-49.local> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID:_Ch0CgDXGztuQyZl34QNCg--.7060S2 X-Coremail-Antispam: 1UD129KBjvJXoW7GrWUWw4UCw1xCr1xur15Arb_yoW8JrykpF s8KFW0yr4jqF9rC347Zr4Ika45Xw4UGr1UK3WkXryYv3W2gF9Fgw1ktw13WFyftrW8KF40 vr4YgFWFk34UZ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvSb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7IU1rMa5UUUUU== X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 74F3240011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8shy5jp79nmfmiy7i66cw4ppmh9jad5c X-HE-Tag: 1697007676-964010 X-HE-Meta: U2FsdGVkX19BEJY/wnfdYnB6TUlO5d6JiPC0Kv9bX4CDfbRqSqo0FNq/NYoqQwwiHocRGB7PuQ4h9e6zRSMM4pGHu44S+im+y255F8YDR+j9xfTpb+WYZiGhfUIvYAY0sLpY07tJBDH4tnXE9Lay2542Ljivfb/dO8Ifm+Lxkfu3duTUQcHAAThg/660huHSRoPn/ueFKdl2y4BUEqtWvVgfMenY6siu3oziwVgO2Vh30VgQexUSDta97LEQzGZy6MDvmwO4Om2W4wUhPXQlkNucvXDN4YffNqzxUIthR9V074+Q5pcdgCH31uQsVs/p5LgkrO1NmwF1E61r534mBB5LJLqqI3+6BNbWedxeKR9gEAP2FxM79+vm4Fs38jl0PTEJp0CahcaLcEoCDxhOgXe+yntYGWoU3VNcNUz5dC7qo94hZEmCAfcnJjZggx+A8DTZcXlV7YsrY7Q/Szoq7a8QrEVxfAbMRE/yiFSOGGcYs75u7O34AmvKW6bVvQeSJn3jaGUP24KcSZnRO1Ld46KF+0FSG8diaMXFFpvs2ZnuruuXHE4CQDWmYx4UabNs9gsP6hbrqbYrp4+km4KEu87qH5AGJZB8+/EWrxrRTw8yfR9bJX0/KCeGJYfRyhrPM1A4wjA6xR5EGAAFra2us8eVLTJMfPHmAgcs0W3qf5QO5+SKY+iTESJkG4PLGTfJnIgihr6xTVayEzKl/8fbTUMyvk3fikXdiqulqkQevicKtKZ6d7RCd4ZcH39rik27wEJATYs7sys/TIFt7hHOqhCXWcrH9rXVy5QF5eWlwmHFOKPqO//B5L3bPV8yHiNaD65I6JmpXCh6MEXHgYZKxkCHOJuXW+t+uYawmsvoqkAJzOtg4IcWxJO9xA75lcGJ1pgb7VnA72anVzjijfIqHQMlKxSEvqqKU0G0uGE9mtN/7pvMjvO3Ysk3tEZEJkcOPrnT6qqr7DSbVokXAG4 51BeE9WN zvQgUDAF0kehLFpCwo8/B7+RJY8SjrafjA3J9cdWPWW2C4Tk+xwvi1QQ52SnBSY+RPgwJVAKWSqMFY7wVX26+TyBjav9FDX5Y2mrzXTrA9wvVT4zsNe9cIJzO9/y6rfvzCWVWwdjD0bJY/tapF2AMuk9KaI62tUWvAry3Xpvb8+KsczQy+b/RC+BZqVrlMCiTIGEpm71JJUy/4ST/lOkF2FBQgi4tIkYyVDTX7sVd6UGk2AhFwpTyxrsDnN3wjmI5fKx+U7Vy6OJn8A1n10x6WRqsgLbKykQeGSm4X5NS7moh2jKGyj3sH2zs+RkQ2UxCi5v2aFUqWEfGztoAPHLMer4jdln3gfrqmIbkBjVX3Y9dgyQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 10/10/2023 12:56 AM, Alexei Starovoitov wrote: > On Sat, Oct 07, 2023 at 09:51:04PM +0800, Hou Tao wrote: >> From: Hou Tao >> >> both syscall.c and helpers.c have the declaration of >> __bpf_obj_drop_impl(), so just move it to a common header file. >> >> Signed-off-by: Hou Tao >> --- >> kernel/bpf/helpers.c | 3 +-- >> kernel/bpf/internal.h | 11 +++++++++++ >> kernel/bpf/syscall.c | 4 ++-- >> 3 files changed, 14 insertions(+), 4 deletions(-) >> create mode 100644 kernel/bpf/internal.h >> >> diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c >> index dd1c69ee3375..07f49f8831c0 100644 >> --- a/kernel/bpf/helpers.c >> +++ b/kernel/bpf/helpers.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> >> +#include "internal.h" > Pls use one of the existing headers. No need for new one. Do you mean one of header files in include/linux, right ? Because there is no proper header files under kernel/bpf. The best fit is include/linux/bpf.h, but after modify bpf.h, multiple files need to be rebuild: (e.g. under net/, kernel, drivers/net, block/, fs/). Maybe it is time to break bpf.h into multiple independent files ?