From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 9F71F6B004D for ; Thu, 22 Oct 2009 10:42:03 -0400 (EDT) Received: by qyk14 with SMTP id 14so5317054qyk.11 for ; Thu, 22 Oct 2009 07:41:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1256221356-26049-2-git-send-email-mel@csn.ul.ie> References: <1256221356-26049-1-git-send-email-mel@csn.ul.ie> <1256221356-26049-2-git-send-email-mel@csn.ul.ie> Date: Thu, 22 Oct 2009 17:41:53 +0300 Message-ID: <84144f020910220741o51c7e3dajcfd7b78d6dbbc4eb@mail.gmail.com> Subject: Re: [PATCH 1/5] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , "Rafael J. Wysocki" , David Miller , Reinette Chatre , Kalle Valo , David Rientjes , KOSAKI Motohiro , Mohamed Abbas , Jens Axboe , "John W. Linville" , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Stephan von Krawczynski , Kernel Testers List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-mm@kvack.org\"" List-ID: On Thu, Oct 22, 2009 at 5:22 PM, Mel Gorman wrote: > If a direct reclaim makes no forward progress, it considers whether it > should go OOM or not. Whether OOM is triggered or not, it may retry the > application afterwards. In times past, this would always wake kswapd as w= ell > but currently, kswapd is not woken up after direct reclaim fails. For ord= er-0 > allocations, this makes little difference but if there is a heavy mix of > higher-order allocations that direct reclaim is failing for, it might mea= n > that kswapd is not rewoken for higher orders as much as it did previously= . > > This patch wakes up kswapd when an allocation is being retried after a di= rect > reclaim failure. It would be expected that kswapd is already awake, but > this has the effect of telling kswapd to reclaim at the higher order as w= ell. > > Signed-off-by: Mel Gorman You seem to have dropped the Reviewed-by tags from me and Christoph for this patch. > =A0mm/page_alloc.c | =A0 =A02 +- > =A01 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index bf72055..dfa4362 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1817,9 +1817,9 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int= order, > =A0 =A0 =A0 =A0if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) =3D=3D GFP_THI= SNODE) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto nopage; > > +restart: > =A0 =A0 =A0 =A0wake_all_kswapd(order, zonelist, high_zoneidx); > > -restart: > =A0 =A0 =A0 =A0/* > =A0 =A0 =A0 =A0 * OK, we're below the kswapd watermark and have kicked ba= ckground > =A0 =A0 =A0 =A0 * reclaim. Now things get more complex, so set up alloc_f= lags according > -- > 1.6.3.3 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. =A0For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org