From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: paulmck@linux.vnet.ibm.com, Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, jdb@comx.dk
Subject: Re: [PATCH RFC] fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b
Date: Tue, 30 Jun 2009 17:26:39 +0300 [thread overview]
Message-ID: <84144f020906300726n4978d59ale5c8a3c076a1501a@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0906301014060.6124@gentwo.org>
Hi Christoph,
On Tue, 30 Jun 2009, Pekka Enberg wrote:
>> I don't even claim to understand all the RCU details here but I don't
>> see why we should care about _kmem_cache_destroy()_ performance at
>> this level. Christoph, hmmm?
On Tue, Jun 30, 2009 at 5:20 PM, Christoph
Lameter<cl@linux-foundation.org> wrote:
> Well it was surprising to me that kmem_cache_destroy() would perform rcu
> actions in the first place. RCU is usually handled externally and not
> within the slab allocator. The only reason that SLAB_DESTROY_BY_RCU exists
> is because the user cannot otherwise control the final release of memory
> to the page allocator.
Right. A quick grep for git logs reveals that it's been like that in
mm/slab.c at least since 2.6.12-rc2 so I think we should consider it
as part of the slab API and Paul's patch is an obvious bugfix to it.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-06-30 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 19:31 Paul E. McKenney
2009-06-25 21:27 ` Matt Mackall
2009-06-25 22:08 ` Paul E. McKenney
2009-06-26 8:45 ` Pekka Enberg
2009-06-26 9:03 ` Nick Piggin
2009-06-26 9:11 ` Pekka Enberg
2009-06-29 22:30 ` Christoph Lameter
2009-06-29 22:45 ` Matt Mackall
2009-06-29 23:19 ` Christoph Lameter
2009-06-30 0:06 ` Matt Mackall
2009-06-30 6:00 ` Paul E. McKenney
2009-06-30 6:58 ` Pekka Enberg
2009-06-30 14:20 ` Christoph Lameter
2009-06-30 14:26 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020906300726n4978d59ale5c8a3c076a1501a@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=jdb@comx.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox