From: Pekka Enberg <penberg@cs.helsinki.fi>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, hannes@cmpxchg.org,
torvalds@linux-foundation.org, yinghai@kernel.org,
Balbir Singh <balbir@linux.vnet.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [BUGFIX][PATCH] memcg: fix page_cgroup fatal error in FLATMEM (Was Re: boot panic with memcg enabled
Date: Fri, 12 Jun 2009 09:21:52 +0300 [thread overview]
Message-ID: <84144f020906112321x9912476sb42b5d811741e646@mail.gmail.com> (raw)
In-Reply-To: <20090612143429.76ef2357.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, Jun 12, 2009 at 8:34 AM, KAMEZAWA
Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, SLAB is configured in very early stage and it can be used in
> init routine now.
>
> But replacing alloc_bootmem() in FLAT/DISCONTIGMEM's page_cgroup()
> initialization breaks the allocation, now.
> (Works well in SPARSEMEM case...it supports MEMORY_HOTPLUG and
> Size of page_cgroup is in reasonable size (< 1 << MAX_ORDER.)
>
> This patch revive FLATMEM+memory cgroup by using alloc_bootmem.
>
> In future,
> We stop to support FLATMEM (if no users) or rewrite codes for flatmem
> completely. But this will adds more messy codes and (big) overheads.
>
> Reported-by: Li Zefan <lizf@cn.fujitsu.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Looks good to me!
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Do you want me to push this to Linus or will you take care of it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-12 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0906110820170.2258@melkki.cs.Helsinki.FI>
2009-06-12 2:50 ` boot panic with memcg enabled (Was [PATCH 3/4] memcg: don't use bootmem allocator in setup code) Li Zefan
2009-06-12 2:55 ` KAMEZAWA Hiroyuki
2009-06-12 3:44 ` KAMEZAWA Hiroyuki
2009-06-12 4:01 ` Li Zefan
2009-06-12 5:34 ` [BUGFIX][PATCH] memcg: fix page_cgroup fatal error in FLATMEM (Was Re: boot panic with memcg enabled KAMEZAWA Hiroyuki
2009-06-12 6:01 ` Li Zefan
2009-06-12 6:21 ` Pekka Enberg [this message]
2009-06-12 6:29 ` [BUGFIX][PATCH] memcg: fix page_cgroup fatal error in FLATMEM v2 KAMEZAWA Hiroyuki
2009-06-12 15:15 ` Balbir Singh
2009-06-15 11:10 ` Pekka Enberg
2009-06-12 15:02 ` boot panic with memcg enabled (Was [PATCH 3/4] memcg: don't use bootmem allocator in setup code) Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020906112321x9912476sb42b5d811741e646@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox