From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by wa-out-1112.google.com with SMTP id j37so1746833waf.22 for ; Wed, 22 Oct 2008 14:12:02 -0700 (PDT) Message-ID: <84144f020810221412uae54f1eudafa4c8fefea9753@mail.gmail.com> Date: Thu, 23 Oct 2008 00:12:02 +0300 From: "Pekka Enberg" Subject: Re: SLUB defrag pull request? In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1223883004.31587.15.camel@penberg-laptop> <84144f020810221348j536f0d84vca039ff32676e2cc@mail.gmail.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Miklos Szeredi Cc: cl@linux-foundation.org, nickpiggin@yahoo.com.au, hugh@veritas.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org List-ID: Hi Miklos, On Thu, Oct 23, 2008 at 12:04 AM, Miklos Szeredi wrote: >> Actually, when debugging is enabled, it's customary to poison the >> object, for example (see free_debug_processing() in mm/slub.c). So we >> really can't "easily ensure" that in the allocator unless we by-pass >> all the current debugging code. > > Thank you, that does actually answer my question. I would still think > it's a good sacrifice to no let the dentries be poisoned for the sake > of a simpler dentry defragmenter. To be honest, I haven't paid enough attention to the discussion to see how much simpler it would be. But I don't like the idea of forcibly disabling debugging for slab caches because of a new core feature in the allocator. Keep in mind that it's not just dentries we're talking about here, we're defragmenting inodes as well. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org