Re: [PATCH 3/3] slab: account leaks to caller version of kmalloc_node

["Pekka Enberg" <penberg@cs.helsinki.fi>]

On 8/4/06, Christoph Hellwig <hch@lst.de> wrote:
> +#ifndef CONFIG_DEBUG_SLAB
> +void *__kmalloc_node(size_t size, gfp_t flags, int node)
> +{
> +       return __do_kmalloc_node(size, flags, node,
> +                       __builtin_return_address(0));
> +}
> +EXPORT_SYMBOL(__kmalloc_node);
> +
> +void *__kmalloc_node_track_caller(size_t size, gfp_t flags,
> +               int node, void *caller)
> +{
> +       return __do_kmalloc_node(size, flags, node, caller);
> +}
> +EXPORT_SYMBOL(__kmalloc_node_track_caller);
> +#else
> +void *__kmalloc_node(size_t size, gfp_t flags, int node)
> +{
> +       return __do_kmalloc_node(size, flags, node, NULL);
> +}
> +EXPORT_SYMBOL(__kmalloc_node);
>  #endif

You are passing NULL when CONFIG_DEBUG_SLAB is enabled but you want it
the other way around.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>