From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by nproxy.gmail.com with SMTP id l23so17903nfc for ; Wed, 14 Dec 2005 00:37:40 -0800 (PST) Message-ID: <84144f020512140037k5d687c66x35e3e29519764fb7@mail.gmail.com> Date: Wed, 14 Dec 2005 10:37:39 +0200 From: Pekka Enberg Subject: Re: [RFC][PATCH 4/6] Slab Prep: slab_destruct() In-Reply-To: <439FD08E.3020401@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <439FCECA.3060909@us.ibm.com> <439FD08E.3020401@us.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Matthew Dobson Cc: linux-kernel@vger.kernel.org, andrea@suse.de, Sridhar Samudrala , pavel@suse.cz, Andrew Morton , Linux Memory Management List-ID: On 12/14/05, Matthew Dobson wrote: > Create a helper function for slab_destroy() called slab_destruct(). Remove > some ifdefs inside functions and generally make the slab destroying code > more readable prior to slab support for the Critical Page Pool. Looks good. How about calling it slab_destroy_objs instead? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org