From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DB7C83F1D for ; Thu, 10 Jul 2025 11:09:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD2266B0089; Thu, 10 Jul 2025 07:09:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5B986B008C; Thu, 10 Jul 2025 07:09:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FC866B0092; Thu, 10 Jul 2025 07:09:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8A0326B0089 for ; Thu, 10 Jul 2025 07:09:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2B77055D16 for ; Thu, 10 Jul 2025 11:09:39 +0000 (UTC) X-FDA: 83648084478.04.4C1DF33 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 9835512000F for ; Thu, 10 Jul 2025 11:09:36 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qbMUvSgs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4o7jqbF; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qbMUvSgs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4o7jqbF; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752145777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vq8snJem4FdTPNZqvgPeOR6MQ4HAjTX+Ct0Ola0GFU4=; b=PIPLlxZ13MygGuZk/ofuzUeN1ZXb6SbIMF2Fa1DggZFeCVWgvuV5VBEIFoaTdKhLr7xnzK TkfOTf+t0yW4jf1NuVTHprunsAzwDx6euwgpDpteliavyEpk9w/ebePMrUBcS0F5dG+v6u Sbru8z2d+uoWSKZN/wFNoeHEuYbJCok= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qbMUvSgs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4o7jqbF; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qbMUvSgs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=r4o7jqbF; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752145777; a=rsa-sha256; cv=none; b=WO1UeY/ZhDhQ4uaxeu15JmCh24mB8d8H79WB10yUxmAET8F3ISAICedhTrIb9DvFXb/qN2 v31sfdmbjS4ufxjlBoGYh26RgdkxLfTgNUmalDGkijIEKhs68118PM3CdXBzsNu9Y2bMpe gLnpoMjP14RWXz3SyzgOIsoZlKx8300= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CF95C2116F; Thu, 10 Jul 2025 11:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752145774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vq8snJem4FdTPNZqvgPeOR6MQ4HAjTX+Ct0Ola0GFU4=; b=qbMUvSgscCThFkvUsLweEZXjK0xJ4RM91+plpjYgnSLGGUHkHulYitIBbTcZHd6VxSCW0p Iy8dFmo6pSRfbVajpLhjT/UEdMwAcCzITo9if5KFnBvMVbMnVUqvqUDXZ/iPMhaQyx6uvd pL9ENit65VMKPtvlNAHz7LA4XVx5J8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752145774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vq8snJem4FdTPNZqvgPeOR6MQ4HAjTX+Ct0Ola0GFU4=; b=r4o7jqbFqmcMACQc4Qv/dLgnenWkU/H3xAaPrZRPtfP4bw6p0DDVCAF7fe9tDtVfPJh2Ts pvLVf2QxuD6DDgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752145774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vq8snJem4FdTPNZqvgPeOR6MQ4HAjTX+Ct0Ola0GFU4=; b=qbMUvSgscCThFkvUsLweEZXjK0xJ4RM91+plpjYgnSLGGUHkHulYitIBbTcZHd6VxSCW0p Iy8dFmo6pSRfbVajpLhjT/UEdMwAcCzITo9if5KFnBvMVbMnVUqvqUDXZ/iPMhaQyx6uvd pL9ENit65VMKPtvlNAHz7LA4XVx5J8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752145774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vq8snJem4FdTPNZqvgPeOR6MQ4HAjTX+Ct0Ola0GFU4=; b=r4o7jqbFqmcMACQc4Qv/dLgnenWkU/H3xAaPrZRPtfP4bw6p0DDVCAF7fe9tDtVfPJh2Ts pvLVf2QxuD6DDgAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AE884136CB; Thu, 10 Jul 2025 11:09:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WbXiKG6fb2gsbgAAD6G6ig (envelope-from ); Thu, 10 Jul 2025 11:09:34 +0000 Message-ID: <841160e5-4ae2-4e8d-b2dc-aa93f17a5c00@suse.cz> Date: Thu, 10 Jul 2025 13:09:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm/mremap: perform some simple cleanups Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: Peter Xu , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Jann Horn , Pedro Falcato , Rik van Riel , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <067bd59f92c552fa4ed5bc22b051ec086bbc0235.1751865330.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <067bd59f92c552fa4ed5bc22b051ec086bbc0235.1751865330.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9835512000F X-Stat-Signature: kgsyenbryj1n7wpjya78af43wx5kjn38 X-Rspam-User: X-HE-Tag: 1752145776-174200 X-HE-Meta: U2FsdGVkX18A6HcxNdSFI4d6YAs6ChloyyeKVtPIuQtZJCT6kuvLSwgfub6TkpQXK8urFMPkaTFp58pIyA6qbtOR1h5yJPoYXQnAfvuiHbLvtKtd4+p7z+qfZ9XUpXFGqkDh/tSk/aZKRjbep3FqXZ7kbTBp2/yE4y5BFIz/UzkrWfUt6SRCO47tD/02SZLLynKh5D1MAlUaLolFurU5O4PmVXeQkeNNId3IhqeGv9BC5+AaRd1hdrSM7TqNUBdkZxnpTU9y36fbeawMO/voymR2/RbCTXOmPoPOlywD8K2HnekTgqDRykCjclZ3d7RyBKFSaFU8QSELrQeSHI8vQDGBELfDdvEC2QnAzOHuBypVDfgURSvthuhBtjDn3SQUGJEEjV7H18c2QJ7Iv9W+QWNuMZdtWxv0Y+iLwR/oY0GgRJ8fKNcd7/8Ze2iPCTzDEzduh8FJb4BJH9qi64eJBhyPbEJ0LQb7sMZOM5E0rJLi2dnqes45u/U9LLwd0Zf/PQ2bHQ5dxs5Xr2YOjPKvB/m0NNAE7sHzo3kaupz0Ww0n1v3THwikb2YrBeLtTT+o3hqyjIlM53gAU2+vsW6A/Yr1aMe3k9gW4qEDatQ/oMQ74E9llcmBCgh6YLycyQk7BwXjZXe7MTpTnTYftJncNOpqwTSqsZdERwviw4JvG+uH/n8RE9mly0REy4cVDBZ6iPsFdfpuX2UQe/63XFZVjONjzlMwCrE9JDtW29/L2py7GVYN5U2qnyovI7NV+GHx404yjQ6VZNMhTW4e+GXteGThjJQFQ/L01IJ7ffD9b7Fmx3SWgd5oKJ2gQJfQuRrK7usTaZWfuVzHk+bDD9qtCReil4AWDopapZ7WzAJkEWEr/TkODoMm3XbvlJL4xLYTOPj1sCX3yNkKUui3T8KpstTvo+el17NrOp0dlipso3a+gn3cBaWFkwGzIXs9zFIavIISYWZHMy8sLNJx8mk ARhvIvgS 9c3do/oYxnKRgwMZY5fPF1Ie02QBn9sH5bE4SvVuwKUFHgPNriuEhTyfzjqs5Zl+Hfiyrcad8WwHPzLn/fhH7YGIeiVpL+0VFgbBBbfls2jRtwifnNX2twAAN6kIa7cWizeVxfB9jZENu/olsJLbVRsahjyB7tBGIlGbZpw4vpBMEB1wpdEww2CYg1itn7WZ5qr+qd69uLYjbXZWybjUgbHloTZQ+nEP8swVScBXtsAf9x4ru4e1XYYb/dqE6v56z66ALau9MlHHrugKTAOu5D0bCe5YSPvjGxX74m44qXhizpsG79WqbCjZm8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/7/25 07:27, Lorenzo Stoakes wrote: > We const-ify the vrm flags parameter to indicate this will never change. > > We rename resize_is_valid() to remap_is_valid(), as this function does not > only apply to cases where we resize, so it's simply confusing to refer to > that here. > > We remove the BUG() from mremap_at(), as we should not BUG() unless we are > certain it'll result in system instability. > > We rename vrm_charge() to vrm_calc_charge() to make it clear this simply > calculates the charged number of pages rather than actually adjusting any > state. > > We update the comment for vrm_implies_new_addr() to explain that > MREMAP_DONTUNMAP does not require a set address, but will always be moved. > > Additionally consistently use 'res' rather than 'ret' for result values. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka