From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28EBC00140 for ; Fri, 12 Aug 2022 18:27:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44AA36B0072; Fri, 12 Aug 2022 14:27:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAF38E0001; Fri, 12 Aug 2022 14:27:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29AE66B007B; Fri, 12 Aug 2022 14:27:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 183F26B0072 for ; Fri, 12 Aug 2022 14:27:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DC404141CFE for ; Fri, 12 Aug 2022 18:27:27 +0000 (UTC) X-FDA: 79791773334.16.7D5FC77 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf04.hostedemail.com (Postfix) with ESMTP id 26E6640038 for ; Fri, 12 Aug 2022 18:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660328846; x=1691864846; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J8PCRcRxT28IiRu+oG8WalqgKIw6ylYNh1g9F5tucFE=; b=ZGOo5lg1BZfUdQtKZ1z0rdAJF41G4G7RaDGED5it/o6/vOU/dAHvvL0g 7h+rWyJkfJJlU7LNITtXlT51TyV1DIlKcrYYv3hldeg6QjBg10aidinmb UFcYAwLZjuNbcuO92iSuVcjoCoxU+2pnciYp9oGrSBjuTERuFwVW5yDfg JvAXrl388RUBshrcpB3rvLmYub9db30ZkN69OKgB6w6aMiZu5lbLyNdJE oqeCEexA+ZOFlnuF/1e4z8zXinKbo2zYQshTH7TZuOl/mwUrU8H7lfwZO WSgNC61NYCwON45pRP9pdPikZfYNQRMAnwTAXIx7RZg1G6iQMGM+uy7la A==; X-IronPort-AV: E=Sophos;i="5.93,233,1654531200"; d="scan'208";a="208570613" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 13 Aug 2022 02:27:23 +0800 IronPort-SDR: fLeCnjLnWE2rlDMKu3nbJ/yB7b1lV8iPzEq5fPNhLQdxNxW3Rt2bgK8904p2xmjAgNfQD6sK54 G4ucWdlh1DT3RUq0+ClkYtJfIU6XsN6lJ3JePYFlGO58IN0msUhqYk0mqlh59i+feIc6Hg6/uz 6hdNZ/57e2TLXZhmO9TGmT47SaGz6H4xoxLKsBw0Ialmnp9JDWI8f7rJjPAUE5fI6CQEu85Mjp RN4ztza+QxJKrLVfE6rXbUufC0ojtfw6PdDL7wFH4lt+NarDryeoHLhSCwgr+S+uYUA5u/TFFZ UDUn9SyfqMOowSII8MNrISWa Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Aug 2022 10:48:16 -0700 IronPort-SDR: bs3lksn2UxsWBERgQo7OoMJD/jTdhaguDcjRNPtUk655s0mao3rlXd0VvFiNtFF3gpfWvZuaVq P7c3Kdi6IxpZmIn8PoCiRAiXjLNebbQNilU0IDHRVQbNGlYVmJ7KpAJ8TAiQRFULbqmQEeRkmf ktSLtcerJ50w9UWUhjLHZGx5QNFIodMaZQlKcqDSzXNn/PbW+QVuuHxAyqnoVJRTTgt61enQEM 7u3ugVdae0ypuem6BroLzGUS29kiSSmv+6PcvDXlWOK4bx3psSfRole9d9CHJYqrQ8c9wI3rFS vik= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Aug 2022 11:27:24 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4M4Bwq53tVz1Rwry for ; Fri, 12 Aug 2022 11:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1660328842; x=1662920843; bh=J8PCRcRxT28IiRu+oG8WalqgKIw6ylYNh1g 9F5tucFE=; b=qOjZ2eJigFW0bMEdf4pTu7XkilFMPaqV8LU/rsqiMzEgNo3MD8p LJ+T/7TijflwtiaYE0Q9JqQ/07i9X3G4HfNUvtxrKFpyzh2N+CwjiYe0tCBSAARK v1DhM78Ix7hFJAJF3R0hdJkCyHo8LSzmIAEjTjy4WDBkvrVR5eRHYRrqodx0Qe4Q UEiNag8pfV2UFyNDwB0cqcMVo/Wg9KgOes7yxK7mE6U7g09iRl7N2wXmChO+7CZj pL7s64hInkI6XqVt2sgeGywtw1N1fbuMG/bfL1YDSkSFGN3DN5QP8vo+JzVwyjq7 QH32SYunbwB2VONkgLgnS48VEHs7tiLQGPg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZP0pOTWckBU0 for ; Fri, 12 Aug 2022 11:27:22 -0700 (PDT) Received: from [10.225.89.57] (cnd1221sqt.ad.shared [10.225.89.57]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4M4Bwn4CJGz1RtVk; Fri, 12 Aug 2022 11:27:21 -0700 (PDT) Message-ID: <840a5f98-a53c-ce08-2833-f41d8c9a015b@opensource.wdc.com> Date: Fri, 12 Aug 2022 11:27:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0% regression Content-Language: en-US To: John Garry , Oliver Sang Cc: Christoph Hellwig , "Martin K. Petersen" , LKML , Linux Memory Management List , linux-ide@vger.kernel.org, lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com> <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com> <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com> <4642848c-a386-d6a0-6255-8b16800e0548@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660328847; a=rsa-sha256; cv=none; b=M6zwQoJlkVDcUqmrCsBABeBI8YWh/IkTbpivtqGddfKs8V20xF+aItm/aGD+ny67T4xud4 QpTvcPCNdISVWsBzK8P/pRH07v5sI5JZR65lUqkRBla48k4cBa/bQRG/BNyo1xIeWiBZB8 UixcHSIqqOef5ox2IKwtDiOGhTEgbys= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=ZGOo5lg1; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=qOjZ2eJi; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf04.hostedemail.com: domain of "prvs=21649182b=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=21649182b=damien.lemoal@opensource.wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660328847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dCnzg6ADuamKv54uwQiIvj6YWETEsD18E1xjdbqTdr4=; b=p7KK2v02ASmvrKJjqkvWjSV5mOxB8NyknkT6s2cIryr+KjaeRawyBnFOV9nolKdRZsxbci X35d1QTkaSp66Sr2CQKE58+4BtKcI6mkf5wfNDAJJZvNxbvun5a0YBe4HYzsjIgpIz0OlF LrmeMIKIQKBrsmfAotDpbHcGleTRw+0= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 26E6640038 Authentication-Results: imf04.hostedemail.com; dkim=none ("invalid DKIM record") header.d=wdc.com header.s=dkim.wdc.com header.b=ZGOo5lg1; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=qOjZ2eJi; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com; spf=pass (imf04.hostedemail.com: domain of "prvs=21649182b=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=21649182b=damien.lemoal@opensource.wdc.com" X-Rspam-User: X-Stat-Signature: coi7gc9yxrt6hac5ufhxfq7xxtptkozd X-HE-Tag: 1660328846-793248 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/08/12 10:17, John Garry wrote: > On 12/08/2022 16:41, Damien Le Moal wrote: >>>> we noticed the commit is already in mainline now, and in our tests, there is >>>> still similar regression and also on other platforms. >>>> could you guide us how to check "which host driver is being used for this >>>> test"? hope to supply some useful information. >>>> >>> For me, a complete kernel log may help. >> I had a look yesterday with my test rig. I did not see any difference in the >> default max_sectors_kb values for various drives between 5.18 and 5.19 (current >> linus tree). The test machine has 2 AHCI adapters: Intel and Marvell. Both use >> the regular AHCI driver. I have another rig with different ATA adapters but it >> is powered down and I am traveling... So cannot test that right now. >> > > FWIW, on QEMU I get a difference for IDE disk for ata_piix host. > > Interestingly ata dev max_sectors kb also gets capped from 32MB (LBA48) > -> 256KB due to swiotlb max mapping size. (It would be capped by shost > default max sectors 512KB without that swiotlb limit). I assume capping > due to swiotlb limit is not occuring on Oliver's machine. Yes, I was suspecting that we may be seeing a difference for anything that is not AHCI, e.g. with other drivers. But that seems to be the correct thing to do, no ? How was this working before without applying the swiotlb limit ? > > thanks, > John > > [ 1.497233] ata7: found unknown device (class 0) > [ 1.498341] ata7.00: ATA-7: QEMU HARDDISK, 2.5+, max UDMA/100 > [ 1.499030] ata7.00: 209716 sectors, multi 16: LBA48 > [ 1.623795] ata2: SATA link down (SStatus 0 SControl 300) > [ 1.624633] ata1: SATA link down (SStatus 0 SControl 300) > [ 1.633395] ata6: SATA link down (SStatus 0 SControl 300) > [ 1.634200] ata5: SATA link down (SStatus 0 SControl 300) > [ 1.635094] ata4: SATA link down (SStatus 0 SControl 300) > [ 1.635887] ata3: SATA link down (SStatus 0 SControl 300) > [ 1.636748] scsi 6:0:0:0: Direct-Access ATA QEMU HARDDISK > 2.5+ PQ: 0 ANSI: 5 > [ 1.641298] sd 6:0:0:0: [sda] 209716 512-byte logical blocks: (107 > MB/102 MiB) > [ 1.642188] sd 6:0:0:0: [sda] Write Protect is off > [ 1.642770] sd 6:0:0:0: [sda] Mode Sense: 00 3a 00 00 > [ 1.642783] sd 6:0:0:0: [sda] Write cache: enabled, read cache: > enabled, doesn't support DPO or FUA > [ 1.644149] sd 6:0:0:0: [sda] Preferred minimum I/O size 512 bytes > [ 1.645142] sd 6:0:0:0: Attached scsi generic sg0 type 0 > [ 1.655145] sd 6:0:0:0: [sda] Attached SCSI disk -- Damien Le Moal Western Digital Research