From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C238CEF177 for ; Tue, 8 Oct 2024 13:50:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08DA66B008A; Tue, 8 Oct 2024 09:50:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03D666B008C; Tue, 8 Oct 2024 09:50:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8DD6B0092; Tue, 8 Oct 2024 09:50:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C0BD16B008A for ; Tue, 8 Oct 2024 09:50:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0F637C1BA3 for ; Tue, 8 Oct 2024 13:50:53 +0000 (UTC) X-FDA: 82650570828.10.A87B48B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 3F2301C0008 for ; Tue, 8 Oct 2024 13:50:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IgO69pU0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728395426; a=rsa-sha256; cv=none; b=VW93BujGxChp1a0yrsZxStXGaqwUdxkBfmXJ6xXbCv6AwB11BlA6nN3HFATbYQiZOfGFTF Bj0UlppQUZiFr538Oqp3VPFt2DS1N8PhCe8lHtNeRHmv9aQnv441l0+ht9dYPbTcvRa8Xm 7kqTqWVQ7ar/R/zypGcAA0N9xRk1vdQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IgO69pU0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728395426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MT0bxc5ocflF2NBeIeTPIzdqx+Na4ZpQOoABhBBbK7M=; b=VA/Xsfc9zrwSL/9bdIujguewEw30/mzqf7kloXY6P0JWso6Lw73KS6EwY66U37VezETWfb o15Fby/SqprhaXt3D9W3vPI697gnnFodSsbJEGcX//LKv1yyqZ7OUvGEr0mLjlMHKm3Xz2 ZVi7Xg1mE5pMwqvvJ3zkT2Wc4Crb0Ww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728395451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MT0bxc5ocflF2NBeIeTPIzdqx+Na4ZpQOoABhBBbK7M=; b=IgO69pU0MCWZo8B3pMLf7+ysStYD0FTHqG7o2D7OqLyXXj40Wxjs9gPv5AuhqqPFG4VUqS zStJ4jPlLLT9wm5KY2H9tOJ2qiBR9d8ZNDWlWdn+TdaWG6NzjfEeIUERYUjsDnR8CcDwkU Z29jKR9B5tel+y/rQcUdbR/rIiLLKoY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-MRo-fMq-NnCbZSEqIAB7Hw-1; Tue, 08 Oct 2024 09:50:50 -0400 X-MC-Unique: MRo-fMq-NnCbZSEqIAB7Hw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37ccd7c3080so2367397f8f.3 for ; Tue, 08 Oct 2024 06:50:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728395449; x=1729000249; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MT0bxc5ocflF2NBeIeTPIzdqx+Na4ZpQOoABhBBbK7M=; b=jvWe8a6zFfK9FUxgArQbF+pQDM4kC/3il8b7jKCgqrSiLboklje37/PjE5qzUdCIg6 5nindBbvc6IsyisVe0TCcP/DiMkXXT+PyvwFGR4AjVJyVLbDiyAFewLeZ/EiwRCoCWww 3ezvUqJgaPuNiCB22DPSlsgkJgCAc5QYB2/6YbhthWY/FZFESnpIQ++CbBm0vftZDi6O q8JIiVTVTU8CvOl6WibzsUSlVAEsNFmMMUO4g87ExQoLZtefPxu9iP1LS4+VvQxdnYMM mASL0jC+NT8Cf1/eq2F9HHR3qirpaNNJOuBVd+ylmLiFyBTVzPYjXLbcMfs+sBio54pE 6UPQ== X-Gm-Message-State: AOJu0YwK66POSjuR1YJjc9n5p2b7NHAucSC3B9lsddNabgb6kCyKkyhp VwVbxjTBGQX1/Na9BrOH1Pac8ChogN9fG9YN6Ny9RLblDnJppYUfwh5oJlbPV25UUGeMDrrjduA EEmZzBXrUAObLX3qUcNvH8KKUBacHxbcW2Rg/0a4849EBW0vI X-Received: by 2002:a5d:5f88:0:b0:37c:d179:2f77 with SMTP id ffacd0b85a97d-37d0e6bc9f8mr10618937f8f.12.1728395449020; Tue, 08 Oct 2024 06:50:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPGcuh7LT/fL7mV+LBdDFv+cetxVNFifhM9W983OFP8K5hhjwy2yDaqbTm0hLUmw/qyAhdkw== X-Received: by 2002:a5d:5f88:0:b0:37c:d179:2f77 with SMTP id ffacd0b85a97d-37d0e6bc9f8mr10618915f8f.12.1728395448532; Tue, 08 Oct 2024 06:50:48 -0700 (PDT) Received: from [192.168.3.141] (p4ff2353a.dip0.t-ipconnect.de. [79.242.53.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4304efc0460sm20598045e9.1.2024.10.08.06.50.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 06:50:48 -0700 (PDT) Message-ID: <83eb128e-4f06-4725-a843-a4563f246a44@redhat.com> Date: Tue, 8 Oct 2024 15:50:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/2] cma: Fix CMA_MIN_ALIGNMENT_BYTES during early_init To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: hkbek4aypa9ugy6he6w97ymkn3m7tkpo X-Rspamd-Queue-Id: 3F2301C0008 X-Rspamd-Server: rspam02 X-HE-Tag: 1728395452-802518 X-HE-Meta: U2FsdGVkX1+lOXTsFvyKR4+i2vljJZ7k1G5+WZWPSsQSLBonFM0wRhuyHg4JrdPhLEsWnswkkkDOvXrTH3OOQwTxfVxKCn24srcm7bgrh8KDhkfQsZAkHx4rCe4S9JCDUQgDXuFY311yMQInbSV8vMP0eds+Sv+p/qYiX/7aoT7/nCgtuBmytQ5bijKCMPZkKGrFOtFkVZg2B/2io1J46KvTBv3+u2aaZYgSzWkHS87HGeVF6yftYTeDHX7t/QGyKxL+uxR7PEPEwQBzh+8zNMoL7qjRFPMktF95M5FqLMQxz2JDoeLWLKRPxn/Q6asBNmcnS2uAkMz77yov6Tflc1ddwdbM9wGnqrVpvYPoc6mqF0z+OvX3UDIgW1CaMXwc1uId2bn4bgItA/FjWsrz+0De20lTQPG02KQ/pdnrrNS0H7/v9EOYt7MVGjtb0I5nPGhftCPjhA7YunYEGrraSpjFoFoqhTorMffaELgUqLMJNj80o6qf8azV9hPdKTrVKvBIquw1GzVFWuPahG96GLHQuCxGUTX0eQFMXf+VmDiZ/yxHNk9OgMjD/YAUVYoGlafaazHQ4T6V7ycc2+QGcWbAiLG/uUXO4FAkjPBg131R7mcX3S0y9CWPJz9+0Ch4SHrkruwEpjyXWjCbJDElfeNijn694ZLpxkxNl0rHzh8fpCUbKvULbbLlDTKaJkCQSJlUQAm+vNa7ianC4bBOe1E3w1qjZaPuyEpT8rjupd4ZAEyIrHQHYk6HdRay+Sm7fBR7YXqMtPFub9RdnonbooyhqJOghXNKgj58HeJ6mgFGxjEpeQXPNXI8tg8i0HMYBxzxvG2sMG52NFf11CkDyunvqJFHMC/rwWaXCI6LBNX2biBN1yTwlTBZ0X142GLPEd6G9JnIk9+7Dkpb41JbGGz/B62DoFZQr+GvgEcAs9vjxxkOAvBMfGhU7SneG6YfAxQv0/1L4pVBW7j6Bev nNpsRWil Z9qeRf1bqiB1QmBEtycQKnmd2YSPnXQH7oQkhvLStZUw/UJWFZncxjsGXZusvXRhB9rWZ1DqFhfR779ce5CP1mp2kxvXt2wXVIJx9HluvTUPgl5aKg4iiVUl5+0oHuVJJOp1JO/x60bnoCdWz+h61kiSM5XadGWY0+wl20rKJkyRF0rJZde1QR0tPJoscfxG+wRT/tLZiz+XjuAAcLezs7qOCg2v1q+fIN4DbkPYJicp1EAvVJx7BhDKG6PAAfy92qP3ow58t5oDLIJdWv3p02gduLC34d6SEd34NgeMGvVfnIroznH5T8c+RV2gKewg05SoahtouRZOJwhvdhm35Lrxxqe1fKgxIGOZfEvU1Em+G/3Q582yIWV1CgbfSxwCkFiY4twBscNEgwpkysz/ueHDfZ5lzxZZK+vSvKb35tEvgJrTR3UddR+3JmFKIrg605UbsCpVvlDQ2lji5Ec4gsxso/J/FdeTe988SgUyuI9gjS5WcEI52kkioEWKzi9SV4kR7arGsVFp4ZNhztoCx5IZdUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.10.24 15:27, Ritesh Harjani (IBM) wrote: > During early init CMA_MIN_ALIGNMENT_BYTES can be PAGE_SIZE, > since pageblock_order is still zero and it gets initialized > later during paging_init() e.g. > paging_init() -> free_area_init() -> set_pageblock_order(). > > One such use case is - > early_setup() -> early_init_devtree() -> fadump_reserve_mem() > > This causes CMA memory alignment check to be bypassed in > cma_init_reserved_mem(). Then later cma_activate_area() can hit > a VM_BUG_ON_PAGE(pfn & ((1 << order) - 1)) if the reserved memory > area was not pageblock_order aligned. > > Instead of fixing it locally for fadump case on PowerPC, I believe > this should be fixed for CMA_MIN_ALIGNMENT_BYTES. I think we should add a way to catch the usage of CMA_MIN_ALIGNMENT_BYTES before it actually has meaning (before pageblock_order was set) and fix the PowerPC usage by reshuffling the code accordingly. -- Cheers, David / dhildenb