From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7272BC3601E for ; Thu, 10 Apr 2025 18:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2819280120; Thu, 10 Apr 2025 14:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD62228011F; Thu, 10 Apr 2025 14:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97522280120; Thu, 10 Apr 2025 14:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7A4BE28011F for ; Thu, 10 Apr 2025 14:36:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4EF01812B9 for ; Thu, 10 Apr 2025 18:36:42 +0000 (UTC) X-FDA: 83318990244.17.6469100 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id EE51E80004 for ; Thu, 10 Apr 2025 18:36:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Dd/JwoEH"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744310200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zr+Ng4jJFOHIi/H/AZxmASCM4Qn5ASJYm7koFScbolg=; b=VuJNb/CdKTkhs4gFyvtPR2TR92Cuv+HNhAKH/J4ECmj6S++r8f1dIb5z6gNuzi83A2Fz7B cvC9zEk3DWtQ5Jn4Fl6XUapY/mHKOBizKP3wYLZXLqlx5ZWIiNDC0rkB5YxzHJAZcdaRL1 fJhXMMRn1fLune0eF+HLFxz+s4HTlb4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Dd/JwoEH"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744310200; a=rsa-sha256; cv=none; b=hSujHc6aii7PE9hHeaqnQ9aq6j0DwEN6tb1LuCAWty3EdmcwW8zCy75KpR7v4UrCldcSaO gDS2HAXgvjSu1SSwk8Ex7LEa1DdgsrtwSIyCv5LUf4DFZT6SL7UpQlL+P+QwSdUMwwXZiq R83TW17NdSrmYNdMwCioqU6tUBezPco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744310199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zr+Ng4jJFOHIi/H/AZxmASCM4Qn5ASJYm7koFScbolg=; b=Dd/JwoEHuR+EIcvaDoyFPJinGUVSJ10H3d2ZAB2i8/iEUZrzKy2GYXZ7JSb8V2Gm0K6Op+ braEldHURCzc7zcLBEGQtxx2A5Li7dGWoxCMCIQoFRfN8Xe7MUzPqIkhzodxHlSOPxhZxr MfNkjCIQx1vbH8EHYky7zmHk6XjY6pQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-Kot6JiR9M9SV_CXBiuTQTA-1; Thu, 10 Apr 2025 14:36:37 -0400 X-MC-Unique: Kot6JiR9M9SV_CXBiuTQTA-1 X-Mimecast-MFC-AGG-ID: Kot6JiR9M9SV_CXBiuTQTA_1744310197 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39c30f26e31so721633f8f.3 for ; Thu, 10 Apr 2025 11:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744310196; x=1744914996; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zr+Ng4jJFOHIi/H/AZxmASCM4Qn5ASJYm7koFScbolg=; b=HjcdG/ESNk1anB3X3NGlgjBPnLngqJ23Lm/MhZUQi8d4Tcor0GbUaJl5E/p2hO2HRU r4PlA14pGXU/0HR6JaZ5u5Cbg7JhDCMt8InNAIsBaeFmznD0IsWGupFYCnGYZSSyXhvE 2oUDMa26NVrDWHC4O5c+pokfRHQhI59/8VvUWbGQpPDTmfG2Ye8GMuCE5dBzPSn3LxV6 8jpEmsYCRnsIPMpFq4ymbNmabpW/lJ12mcXSs8uS7NJ9yewplmpgFkwCMHRHncICa9EE mEBelJ0aI5y0G+GSx1s5HlPOulvKqszxEkVMafT8kB0n67Bt2YWHq9K/bMdFm0LBWDAK EVdA== X-Forwarded-Encrypted: i=1; AJvYcCWA+++ziPwnuHrR2a/Z2K0fa09bgRLJxf3YlMLoQP0Y1V9hmiGcAbQJNHtKKGLinSua2p9AsvS7TA==@kvack.org X-Gm-Message-State: AOJu0YxaCu5Rm7+W47SpXI3ZnXiiTPaLCryYTp2XYnLWe7AywtBepOsZ 1YnKESKznJYv2yixjLeqO5J6YYyjqZT9hy24ty56xPP7rziqis6CGMyLKviDbhfyPWyVIxKlv26 +e6ULQVJE5YO6csVCyih+8L2TfDlSnGKy5Hs/jK/y2c6HMbo+ X-Gm-Gg: ASbGncu9+K2T1JNbbV0okAk4B74ebGeL2AK5G19h38iOc859MHHXEZipufjn3pM9vPA qQQYatIiqd3IPn/jOPwbjL/qM9sAyP5ICFPwziFlCpgDNQChdhH95vV9CqugpAK8qFdTlUQ8aBT 29SE79nFynUKNk8IdKX/1W6Qxy99aV1UzY0LaX0fdUl5pOs/ukloUyyvzfUg9XZ3h10GSzLtMD1 kDDPZFz/TGG3aQg3P1lr7+0Ga6gkPTB116vhCiKCdLUUo9VDpRvfVr3z1Byzdjqm6Tf7h504x1I n3m7H8c74yhj5bDL5DDdhb4W5Ul3P0979hOqcygPGw== X-Received: by 2002:a05:6000:40c7:b0:391:487f:27e7 with SMTP id ffacd0b85a97d-39d8f4ea82amr3475371f8f.55.1744310196635; Thu, 10 Apr 2025 11:36:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVaFm+41IJ7zizfBFTSY/K1PgcFhHzilk0IMx8IpDGRbcrJzSKoZ7cYNY7rCyvPExpXJUHnA== X-Received: by 2002:a05:6000:40c7:b0:391:487f:27e7 with SMTP id ffacd0b85a97d-39d8f4ea82amr3475347f8f.55.1744310196268; Thu, 10 Apr 2025 11:36:36 -0700 (PDT) Received: from [192.168.3.141] (p4ff232c1.dip0.t-ipconnect.de. [79.242.50.193]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d89362fcbsm5439717f8f.5.2025.04.10.11.36.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Apr 2025 11:36:35 -0700 (PDT) Message-ID: <83e8b1b3-fc73-4a49-9f6c-36489c3f39d6@redhat.com> Date: Thu, 10 Apr 2025 20:36:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Introduce free_folio_and_swap_cache() to replace free_page_and_swap_cache() To: Matthew Wilcox , Zi Yan Cc: nifan.cxl@gmail.com, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, will@kernel.org, aneesh.kumar@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org, Fan Ni References: <20250410180254.164118-1-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8V5kPN4iVJRcVPpFyC4AY9GAADUqEZ6_M0IWd2YDLNk_1744310197 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EE51E80004 X-Stat-Signature: xpjnz3rag5w1bqkrmkwtpdif6e569meu X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744310199-724091 X-HE-Meta: U2FsdGVkX19Lbi6x7R4qD0nz9I8i041yMYM1j1f8jTvtSab4TK4B0rAgf8weqZ+DPJbjeIR1qULlQkz1i188yZS5Mruriq4bKfa8RAtJe7EuQrjaG10OEZU0B9LtT8G/xHjmMwnzrp3j1ZShwXDW0dvOildg1Ji6ABImoTEubDo/T5khSlc6kJCKZKPmPQ3HB2vupH5AjjSlD1BIVy9xjHvtfgw39smSXqQWL0Vtr8NGTBX2BU1Ytd2dqpxMzdx0t1rx8Os0j6BZ5f5aI+oGI3dR7tMKEEjCwzm3Q/58/uzuk4GNg82Efo2ptws3K6zRbk5/0W6O8Ufw6V0/F95tENm6qvNjm6E8FfyP2IkDJlnnUnpZvZcxeBWiLO6GGvOHFSoiZHz0emLvzCv/4MgB3rztBwYlWzuFL+Jr/0VCjufVFRSIVBjNXFAyBlwKJESGQOW7jquVLE189g5uQYE1tTHElHA/7dCU76j6+31rnt7+ELwSQErmALwSestOh4B6sSudQk3ChYQ0c1UQp7yN1QHeX4jI4pmWo/wE/6Vjh9m4neUhM79pRwiV8kcM7qqRDOSpXz/PxxdNXeX2f08XHDsN2m1vXWCA87fGtTBz1TH6EyW0RGIXJ5D+J/9l4NssELGxr2q26NKGLI/JjPcvYvk14lHaUodaDYVVQEglc7h61kbRLnlyRhyBKbDOoqfgOQ7Ely4RaXn94uaXSrwDqqWcMBw9VzrXEFErAC9AFEwnzFh4eAj9vJoLCH4q9dYIBIz8KD9KG+sfBUWzblR5q4iOhW3ta/oz+XRheI+a6Bj+yfw/zXMKQnQlAqVV7NU70iDg07jTGIoPHgjpYeDq1bTvVDhQfKMvoikvtROFLIlOD6ONO8thO7yEbzXrIbr4yCBEukijB6x0MHMxn2xYH6XAZ23ianP9Pz+EqdZIito4nrvdNwk4JW5pVqxT+XSMAKNSPMhNZI1ihqSzSyf 42YRdl4R VNEwwEtnTLUhTKJcI7CLhODxhEUA3QRtHn1LTKbzbMEjPWRbnfz8rmGIiNsF771FBYmIiAfDSgc8jFhDHh2L2iWphaO7Dh/3jjyKkp3qA5ccyz8fxi+zmuRrIpnOCAt0neJ9b1EnuWf92myBJW4P9lQbg+ThSbBkK+0J35/2Rv2/MDPqoKmhwWFVT2tNwx2nb+HZ8ZTYH/n4XC4tzEUh96X1braOZp5OmzzegmuiUVDHKmuWzJ4Xs1XF/uTU1AItPPKznBBM9PNtz6L/BVWbu5EUjH0Vb4/Y6R41V0ZN/69p11OGfI+Zw6a11CH3dRZo9N53+H+y7Z/v24bmvKqhvypqLBre+nfrutrPOsg/7OmwUKOTi4B+028weS8HAHPEuyJh+jaJvA3PIFCjSvJAbaDSmxYDoRLnvNBwzrNxvZdxudu3yNFY3KScn5RdIPOGfjNYewhq5nTBufEJAlhapqG0ke13sP4HUxfI2NTfdBvz4ZGEulACvxOem96BUkefVo04GDVIQbeU0fTtZA+u40al8w3zb1llshhQr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.04.25 20:25, Matthew Wilcox wrote: > On Thu, Apr 10, 2025 at 02:16:09PM -0400, Zi Yan wrote: >>> @@ -49,7 +49,7 @@ static inline bool __tlb_remove_page_size(struct mmu_gather *tlb, >>> { >>> VM_WARN_ON_ONCE(delay_rmap); >>> >>> - free_page_and_swap_cache(page); >>> + free_folio_and_swap_cache(page_folio(page)); >>> return false; >>> } >> >> __tlb_remove_page_size() is ruining the fun of the conversion. But it will be >> converted to use folio eventually. > > Well, hm, I'm not sure. I haven't looked into this in detail. > We have a __tlb_remove_folio_pages() which removes N pages but they must > all be within the same folio: > > VM_WARN_ON_ONCE(page_folio(page) != page_folio(page + nr_pages - 1)); > > but would we be better off just passing in the folio which contains the > page and always flush all pages in the folio? The delay_rmap needs the precise pages, so we cannot easily switch to folio + nr_refs. Once the per-page mapcounts are gone for good, we might no longer need page+nr_pages but folio+nr_refs would work. -- Cheers, David / dhildenb