From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA97C7618D for ; Thu, 6 Apr 2023 13:57:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F6B96B0071; Thu, 6 Apr 2023 09:57:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A8776B0074; Thu, 6 Apr 2023 09:57:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F4D6B0075; Thu, 6 Apr 2023 09:57:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 686E86B0071 for ; Thu, 6 Apr 2023 09:57:49 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 25C1C1612BC for ; Thu, 6 Apr 2023 13:57:49 +0000 (UTC) X-FDA: 80651119458.06.3AFC01E Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by imf27.hostedemail.com (Postfix) with ESMTP id 9A9E140021 for ; Thu, 6 Apr 2023 13:57:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dAsAdK9V; spf=pass (imf27.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680789465; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZwjbDL5RnCNXJ7w11XcKwq0d9Uw54uiNfMuw1QQDbuU=; b=dnEBoTLtVVG5MGFnjfDnd/VGmdxku++VRFWZWD0tBA3W1wXuXIO6E87Ne9NtJIit2H5Slf iTbUI2GwMyI51NTCeMFNREb4FRYnlVemywXRYbQnL8AZaS8y8tXE1aypElaq/fmXofQxk6 nEu1N9/1Aj3Ln3jmVzow4rgrsV7gqqw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dAsAdK9V; spf=pass (imf27.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.47 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680789465; a=rsa-sha256; cv=none; b=m1Lza86oTmEHeN1OOOziQL3F8zRdym9VcfY5L/xH7OVRDKMYNpJBHyPFHwQLyhsWFBlmyQ oCE8ZU7m9OyFk0IyjzGX2vYAV0DIlfsMlLWpvlDEpkvy5fQ6PrUjChRfb7Wz5Zu58GCrUv qiJxYg9PdzA1niJozOaJowEeyEC+fUk= Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-183f4efa98aso1341651fac.2 for ; Thu, 06 Apr 2023 06:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680789464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=ZwjbDL5RnCNXJ7w11XcKwq0d9Uw54uiNfMuw1QQDbuU=; b=dAsAdK9V4ARLjY+zpgrgkhY7ni0OMNQFhBTsm/tVaLuPmWugXEVINMNvIWsTZcXpLL XwZjMz8BxHO28Ox6DxJriD0g3b+DnDP/llHPr99iQX5UdCydECkInG7AmpFE5SxCGTaR X2CGJF1VT6WeyH3W1YrlcRuOj4Qt1Oo0vO5aWsLbxzg9KSpbtJEnE9iLyDe2IHUzg7lh iSlNGIRNtOrdPdB9X9RDqCHSNQQUDmnfs1AyYv/gXtm2ndBHjcHRqbGYIUyn4O8eysim bVl7N1o50Wq+MeFrNX/zMDrjMZpezqPo/9AXMiojdxZGH+bL7px4YBU+nGfPIXSfddKH J3CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680789464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZwjbDL5RnCNXJ7w11XcKwq0d9Uw54uiNfMuw1QQDbuU=; b=TRIwqEePHQZo63Zb5958ZvoTUC4IAqGUfrPDYk4dvvm6EBIlrcFTLoivvfbTROVgOm HjEJi+IMzmsMiBxyc3LLDDYLkykm8cY23yGIqnD2EnW7yFBtF2U1j7epspKXl5Ocw9jx L6MxmUO25etTMTEhWWjCIpZosgZ9w4lwKWgUMMEkHWK8V3l2orvFxWaDZF9/WfVasBGt f7wAObdtPDOsvq6Y1QfBT3mF6+SZM+WCiF1gtwVUhDsBjcpTTeGdfFCHl4YANpm28Dp/ Af0Qs1AtEAKUY8xQ/8jKrLMLQmq5w58BOiGd7ehG+gUOP//fa9qzEWInXS1798uUGjb7 R/3A== X-Gm-Message-State: AAQBX9dzwZNS4/CQU941qhLhKkQqlVFq7Rqm8CNGXozJiFittn8HzF7G 0uKebrzcM96YoGDXkNdV4aA= X-Google-Smtp-Source: AKy350ZG7Q26V9uIzMXnISrNBOoWfbciLp0ikFwAyPf6p8ameENR1AD1HDwtkd5TDO9VFK1RPauH4g== X-Received: by 2002:a05:6870:b006:b0:17a:cd1e:b0d3 with SMTP id y6-20020a056870b00600b0017acd1eb0d3mr3261318oae.3.1680789464608; Thu, 06 Apr 2023 06:57:44 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id tk9-20020a05687189c900b0017ae6741157sm703896oab.4.2023.04.06.06.57.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 06:57:43 -0700 (PDT) Message-ID: <83e6bc46-dfc0-0e95-e69c-5b996af1e50b@roeck-us.net> Date: Thu, 6 Apr 2023 06:57:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] mm-treewide-redefine-max_order-sanely-fix.txt Content-Language: en-US To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <9460377a-38aa-4f39-ad57-fb73725f92db@roeck-us.net> <20230406072529.vupqyrzqnhyozeyh@box.shutemov.name> From: Guenter Roeck In-Reply-To: <20230406072529.vupqyrzqnhyozeyh@box.shutemov.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9A9E140021 X-Stat-Signature: owrcxstdywzwj6stkhxhzk3yxdo9tpqi X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680789465-633785 X-HE-Meta: U2FsdGVkX1+YBvB0fhKW4Ep+Vm0GRQF9n3Sp612lmMQAKlA71NUdHbwmO+ysH6S12LcvAfk6f/ugL5+mz+0pL+hiqjJaB5JZXXomhccYScC4L/L5t+uZu2YD4cQtHO4H0IHviJMniETIg3oWEsrKBPlkvN2w4mrlYM9b6t4F0QmPcC40Ck3Z2ouEeiSTPtG/cJvpj5iGH1B9NdhKwahGxKsc3Vqf95Uacoudt2D4Yh2blevIW6WYliXOETGSMEEblkgDPSnT8Q+k2Vl3BpPlnAeUKXN1O3neTklpEHTTQxjXLO07NTl+iKhXzel0a+lV4EGmcN3ItTdVmZi5LdzlLTkKvYVg1XfrFzHJdw8v2eAjFEcDL42ZDUxwlUCYgc1eCndJ4vwcj8GBb0rXNLQlAgADplNNLqTCgTsK5Xu2AQUlZ577r9s/Kxd9ArgBlemxZspnjDqKcInve0Hi/DfCggwRqG+xebsGkweQYfvgXk3kxIBCg3ASjVt40SQr9OiXBlsei5ju9dGHbnchDsJIxvdBMYzBOLDzSWj9xg1TfzJ+vVWbBG6Y/4Xng3dzG5xZugQ/96Y10v/00WrnYc0gFjiuiBQvLUmc1xiyJpNtfn2RG05FtB+8By+ByQXsenFZAGbVdHGk7JtCqRyhDCn2nfplhVqeibKN0AVFpE4MlPj4EnWLgqtpGM2gY+ZxjBeoQSwjAjseHaUuJuRyzWks9I0VYQLoqDW7olx9nRDJ6IXgJqny8wvfcbAi7reC7WvGmgyDDveI430WDcxwE4krE1g/9mYqSQjDujRkwXg0r7ywssQpgbd9YkDuYH2OfsvOBewaGkHyQApywZJ+TBcZYRmJpM4w7kMBVfUlzz9ws+OSyMJYpictHW16Mje97eiS2WEY70dr5mDam1kRRr4WiA0EHL/CjOJaXwGufHOyF37B053O8W4mDX0XYO1XzCcTvHIebh+fsHGBHPR5Az1 XAbRq0/P 8Ma8cCERU5zSWSZVE0ZU/eJG3mvKQAujUKYhrGdZmBSRb2BelHzun/bECJK9dbZALrX8+4KIS357cLk05YKeqr2xDNbr3aFTCTUjdhOjnlmjbqXshyYKo58qo+PRYw4uNalOcu5Sx6GZ1HX+RdcT8Icz7EZRQdv2z1RVXcVKx/EWlOmw/Hy5nmIynowajR3fk1N2SlmaW9Mshg3qvxKeSaS97Xq0Laws8vQfZhuOtPVOF4w3ECURl9LtLDIPzdr9Upm1oyFdG+M4cz+7Ya8wtDt6XJIhNY+hJBy/LvLbkBYZJmUU0ZuWkVEWj8afs+xrOtY4vtzYCxmVLlmIAbybb7IMsz6WJw8fFeNAIQV8bii2Kc6hmb16lhzQXYl3XEBr2dfFd1GjtSYw8xxi6mw9yiYZ2DtDPUhcMTFGCGASDyvwuTqAHyCig7sHvVF5T9I/6PBZ13YbdgkfGLCv9Eg9hHFlD92Q98gu0NjT4bf4AOWPkINcFwH4h1FowQlj5wQTuWtX5cT4yZUuuIjfeudTbQ8p3PmBeVLnCOZupNJ8L4TnkbfbVy7HofPQPhXf8H0BLA3rS8HURSrTsMLLrFDnBVAOFSD//LgoLZDahvqPrgmxxFOd6knfYU88M4nRm/6sDNutpUwA0GhZlyAXMgCekbOgjLSWaPmp/GpM9h9NUjj584t++6F1A21rCxraORZCTdFbc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/6/23 00:25, Kirill A. Shutemov wrote: > On Wed, Apr 05, 2023 at 10:20:26PM -0700, Guenter Roeck wrote: >> Hi, >> >> On Wed, Mar 15, 2023 at 06:38:00PM +0300, Kirill A. Shutemov wrote: >>> fix min() warning >>> >>> Link: https://lkml.kernel.org/r/20230315153800.32wib3n5rickolvh@box >>> Reported-by: kernel test robot >>> Link: https://lore.kernel.org/oe-kbuild-all/202303152343.D93IbJmn-lkp@intel.com/ >>> Signed-off-by: "Kirill A. Shutemov" >>> Cc: "Kirill A. Shutemov" >>> Cc: Zi Yan >>> Signed-off-by: Andrew Morton >> >> This patch results in various boot failures (hang) on arm targets >> in linux-next. Debug messages reveal the reason. >> >> ########### MAX_ORDER=10 start=0 __ffs(start)=-1 min()=10 min_t=-1 >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> If start==0, __ffs(start) returns 0xfffffff or (as int) -1, which min_t() >> interprets as such, while min() apparently uses the returned unsigned long >> value. Obviously a negative order isn't received well by the rest of the >> code. > > Actually, __ffs() is not defined for 0. > > Maybe something like this? > > diff --git a/mm/memblock.c b/mm/memblock.c > index 7911224b1ed3..63603b943bd0 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2043,7 +2043,11 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end) > int order; > > while (start < end) { > - order = min_t(int, MAX_ORDER, __ffs(start)); > + /* __ffs() behaviour is undefined for 0 */ > + if (start) > + order = min_t(int, MAX_ORDER, __ffs(start)); > + else > + order = MAX_ORDER; > Shouldn't that be else order = 0; ? Guenter