From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478BEC7115B for ; Fri, 20 Jun 2025 23:29:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B57F06B007B; Fri, 20 Jun 2025 19:29:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE1906B0088; Fri, 20 Jun 2025 19:29:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 982BF6B0089; Fri, 20 Jun 2025 19:29:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8516C6B007B for ; Fri, 20 Jun 2025 19:29:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3AE7A104AAC for ; Fri, 20 Jun 2025 23:29:46 +0000 (UTC) X-FDA: 83577373572.18.9DDCA18 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf07.hostedemail.com (Postfix) with ESMTP id 2F7984000A for ; Fri, 20 Jun 2025 23:29:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=pftSBXmE; spf=pass (imf07.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com; dmarc=pass (policy=reject) header.from=citrix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750462184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YQ2eaHvE+DUGUCT+tt8p22ZyvVmrf9rbNhrUi9BbtKM=; b=etxJcWVvH+fMEE47OBfLpwy5NDYi7m+wmJmW0S0Hoo5Z9QaA4DKWfrULfTTP0zDFfczgsq T3HGSrFBHjXXI0eyN7OXymsj8u6xBNn68KlSGz0EL3EUfqbyU0D8E7hVYdlShVDMKLuP3+ Dbpdu0IwNUcv4Jd6tfvnQfjTJmjVfHE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=pftSBXmE; spf=pass (imf07.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com; dmarc=pass (policy=reject) header.from=citrix.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750462184; a=rsa-sha256; cv=none; b=ubXxGR/9uvCHaJHzCdPSE4OT2bprCAiD0S4nhRpTknNa+DjALqo/cg+5lrkna4xHsjSvQ/ Lc6JcEqluRBx0/kEtmR0yH+2RT7Z7Pdr0CxkYiHgGlhf4trPg48ye2akfolMNBUeK8sk7t DRZJ3Wh5VYcOm5gElB5PzLQMxILe1fk= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so26530275e9.1 for ; Fri, 20 Jun 2025 16:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1750462183; x=1751066983; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=YQ2eaHvE+DUGUCT+tt8p22ZyvVmrf9rbNhrUi9BbtKM=; b=pftSBXmEU9CYB8lRP5TymkzWUQ1kEBxvt3qH5keKh3dFTKyb0DJ7MBVAnfvCzbFRY7 zV7XaQ2MHr/FlWSYOTK6uW92aZBp+Czf4yOegA57cjf/vNlfsJ1HiPjael5rmNdD93Oo I/wzLuVkpJCHpuyNf0w+2VuevOcZdrHPwRWQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750462183; x=1751066983; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YQ2eaHvE+DUGUCT+tt8p22ZyvVmrf9rbNhrUi9BbtKM=; b=bsvccJQzEP6ASlx3tL6EBkgm7FiMvM3dF1XKWdHXGPUexHGUyPL3Cg/fldXDICKyvG rsKc34JGEoxC5C+xR6YExyjZ0ZMBgCzSeoeJ9Gk1nVBmDqRqXShP91LI3RzLCFAFm1z/ vbE82l/pZDCE1eRbOIMtedIDuKG1utbtjZCNWNoEK9sR+POgWYVf6LXRT3uNlf9DrJ+y /qwd1qHoXSgTtZlvt3ePIvTPOP7F4yUYdc4LjmngmjErrLPpAsSlscGNiln92zeiWaPQ O6h5m7rGlJ3xHqymTGyXXPR/DmqZXE6uDribtdUs+vICmNapFrxZNP+b4KQhorQiw+Op Tl/Q== X-Forwarded-Encrypted: i=1; AJvYcCUFkua93T8i+gKUkvWXGxfXyU+h80rC4RdFsROz3FgYVxSaIBkx3aG7T24Z7lvYGVFOOzz9aH9qEg==@kvack.org X-Gm-Message-State: AOJu0Yw0MJEPU2spjdACK4VVIWa8dUDyzIDsUYY+i4VkW/akFBj3zmgg KgOooyPgUVDL3Ca0cdpuMJUEMyZA6B/rrKZfc7M8RDCN1CnXx2QLadIGbG9/bHb/yHM= X-Gm-Gg: ASbGncueYUxKu7T3tehceQnyYmGncs7sV8EvrLlioYl7ewsK+mgZ36ja/cWLTL7/vuy DYJ61vDgU7uEzP37ZupblXKh3+vFF9LzN4Cyhm++yoFYkyLVWAXzd3NPbg71sRFFAYnaNA67/zq k50RX4owz5yzP6mdhEgl04JiWovO1a0h1zt1qJ1friiVq2PKKwVbo8g/eOgDdCI3evuxVqT1F2H mSyIR0jayYnnlDV3Ugf5CkrGPj9IbYtPmLwOb72ZlLjJ75jVULDEkdNEI9YzAaO3LL57SVWRbqG 0ypmqKAWkEjMnQ3DWxV+yGisf7HQVNYZeYQJk5+l8rGcXsSSOG4EfgsS5qfgG1jW+qnhL/MGdln ZZAfJHEAkUMhAnmtSGKDgF1Vm6BY= X-Google-Smtp-Source: AGHT+IGgRZHxkj2pQ+l7/rk0whCWEYGExTTse7TuxuHuH1Xq1Z0HqPD/2OxQrgjoH7P7iFf5EIxSVg== X-Received: by 2002:a05:600c:154b:b0:43d:40b0:5b with SMTP id 5b1f17b1804b1-453659b885emr40942275e9.25.1750462182540; Fri, 20 Jun 2025 16:29:42 -0700 (PDT) Received: from [192.168.1.183] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f1d91bsm3142259f8f.42.2025.06.20.16.29.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jun 2025 16:29:41 -0700 (PDT) Message-ID: <83e4ffb4-26e9-4fc9-90ad-256a1613ba7d@citrix.com> Date: Sat, 21 Jun 2025 00:29:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 07/16] x86/vsyscall: Reorganize the #PF emulation code To: Sohil Mehta , dave.hansen@intel.com Cc: acme@redhat.com, aik@amd.com, akpm@linux-foundation.org, alexander.shishkin@linux.intel.com, ardb@kernel.org, ast@kernel.org, bp@alien8.de, brijesh.singh@amd.com, changbin.du@huawei.com, christophe.leroy@csgroup.eu, corbet@lwn.net, daniel.sneddon@linux.intel.com, dave.hansen@linux.intel.com, ebiggers@google.com, geert+renesas@glider.be, houtao1@huawei.com, hpa@zytor.com, jgg@ziepe.ca, jgross@suse.com, jpoimboe@kernel.org, kai.huang@intel.com, kees@kernel.org, kirill.shutemov@linux.intel.com, leitao@debian.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@rasmusvillemoes.dk, luto@kernel.org, mcgrof@kernel.org, mhiramat@kernel.org, michael.roth@amd.com, mingo@kernel.org, mingo@redhat.com, namhyung@kernel.org, paulmck@kernel.org, pawan.kumar.gupta@linux.intel.com, peterz@infradead.org, rick.p.edgecombe@intel.com, rppt@kernel.org, sandipan.das@amd.com, shijie@os.amperecomputing.com, tglx@linutronix.de, tj@kernel.org, tony.luck@intel.com, vegard.nossum@oracle.com, x86@kernel.org, xin3.li@intel.com, xiongwei.song@windriver.com, ytcoode@gmail.com References: <9d351d80-66fe-486f-bdb3-370859dc47cc@intel.com> <262c0fd2-ac66-4ce7-903f-4062f1fe1d6e@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 2F7984000A X-Stat-Signature: siycr8tumo9pan1i7oas34gb4cyufh4a X-HE-Tag: 1750462183-368033 X-HE-Meta: U2FsdGVkX18fEfVGgzA3bVGZnNZQZdC+C2W/OVgTuZ8JdRj0aCEui2BxstRKYTgq8LFaGIjTCv7rL5jQTVegBS3iONl5DBp0tlP+HKCJRhxnCE6kKzQfJmv2pRqgyKcLJdO3sm7nAk1hEKaB+ITF5VHgl51wK6KXXrOXjZKaKpX1m15TfEYpxar+TUjw5G5moxIm5UBDI5EZi+18jtNRplQdPrDyY/hON6Yhx0U3iF2VqeqeZpo8k+jo0Lr5gy550bA4RplNTVOrktBffmi6r7YwJ8ZXaJk67F1dvOcUFf5J1rRJgelkXTKbbWONg5huDARf9uSw5r/tHRnKSDW7wL1F+/iIlkpvqpP4vaAB9XQSzm8G6dKWoAHXQkDxwDgCTab6AnTPMl5fnxEkh/W5xBMCWVp0Di8pYh/RTx39VRlgc+n7InycgQ2bjVBsTu5JbXAfz24P7LbGp8HaYu+9r0md7czJr3/ni2xYZld6jKsUy6We003RrtMbSxqId4sDi018d88DdIxaiuae9g6Z7wAuhDqr64M2sEtCtVlD6k65lFZd88sK/iXwFSR3qLkUJjwoDT7kEhCnTGcxVJJ7JfcqtuVyykaZsO8kUkW+zTwEQBuV7JLiz8AeLWRAhDvpKALgk++35se/kdXnvGKU/vpHE2tGhSonnfp9+93BBXWLpAsmsDfmwJDrfNTrL8UlGLjreGEdWv7gg6WCSHCoAcg4Oz2ehSw9zQxL7WUT5C6wnGw3Dt+r+cSTbjwDtmYHenw+KZOH1ERDkm4oP1Y7ZSU6KZGYcwOP3hIqGOgO44Q9ApUcN6hangiwJK/stI3J5G7W96ukUoKpPevuhbbeyBmF84emO8g/7sJd3cZh/1yb+GNjFjRmlzdXvp+YhWPY16pC4WEgz+9cT1xEKDUHpsiIx7rDYjkJYUj6VMx84s0Y9KfiAkSmSsw5NO0aXCTfLZ/ZXJDpt18oFaRVrTQ 09nP9bQJ OBS8WRVzkpHrdJvuwYKPTKv+t4wQa9u60CsW0X/zq8qTFF1WGkH4OsMMuO7imFO8Ns4+t7J4LEQhbMOs0BnJd5OZ2KZmZUeJe2Uq7EgdwuDj/91qgqwxmC8FiL7LoTYAWZnWj6uaVLhDqns43UMuRzVcbf+NdXcj3/eVG90M07rEjzS7BlsvR5obZGh9FVOq7LEK+OBCvGT1Fp0Q3FjP7CBtsrFpV+fHDidXwLBnyZh8EzRfGkRnbyVAilhVd5GUAHN0AzPASiugK4iDjbzNtWppRdFl+nbjAMLAoPUv6ytbzrOTxJjVmYKeO8GH7/qfcshc+OGtI3UuU4QDzeaeiobGfF0DUYPbESaR1P5v3F+GtX5D1P805tCp6/fyr/ucUUrtDorCn135aWCvtYyJrVFHB9LLoGYHxIEhddAXfoJJNLEzULVh5bfGBWnmZMKDN+W1i2+bcaeufnawHFOyswARGvM60GMy3pI37HlqB60CU7v3rqUufe4C2drpm7bD4BXFf7fx3SRING5zJi+cyYwqFnbM8lqhyQ96u6bSaS4xLxyQfnxScn+lLBf40lraTALhm/8wvyT+ikiI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/06/2025 12:18 am, Sohil Mehta wrote: > On 6/20/2025 4:08 PM, Andrew Cooper wrote: >>> But, the resulting code is wonky. It needs to do something more like this: >>> >>> if ((error_code & (X86_PF_WRITE | X86_PF_USER)) != X86_PF_USER) >>> return false; >>> >>> if (error_code & X86_PF_INSTR)) >>> return __emulate_vsyscall(regs, address); >> To do this, LASS needs a proper interlink against NX || SMEP. >> >> If neither NX nor SMEP are active, the CPU does not report X86_PF_INSTR, >> meaning that fetches are reported as plain reads. >> >> This leads to some fun corner cases in SMAP and now LASS too for virt. > Maybe I am missing something, but LASS works pre-paging so it wouldn't > generate a PF, right? Oh right, yes.  This is a preexisting bug in vsyscall #PF handling. It simply became obvious with Dave's suggested rearrangement. ~Andrew