From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EEDE77197 for ; Tue, 7 Jan 2025 09:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C25086B00A8; Tue, 7 Jan 2025 04:24:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAE876B00B9; Tue, 7 Jan 2025 04:24:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A27BB6B00BF; Tue, 7 Jan 2025 04:24:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 76D746B00A8 for ; Tue, 7 Jan 2025 04:24:06 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3D5D3160805 for ; Tue, 7 Jan 2025 09:24:06 +0000 (UTC) X-FDA: 82980119292.27.E77684E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 7C0E1A0005 for ; Tue, 7 Jan 2025 09:24:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736241844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6jA30ID1W/7/7ogTwqiCTGjsVA+UOtm0dKxYnyJ8+Q=; b=nnxLXPnnZInCCCtQYOhcVEBYF73+rIKUtzacRCtNZm3hhAFWHuyCBjmR2Cui41V3/mbdk7 2A/bCikjuMbDoMWAIaI6qSMuXKulFQixyQIK6otr9FAyL0UuozmBlychHo0rpK+v8QPPpJ 3S6dey5EzEnAVYzyoeCnUioZm3DsJp0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736241844; a=rsa-sha256; cv=none; b=hIMiQF+bfSTeZyVn9R99viyGaedKFCXjrgAaSuiuJdZI+c91YlSVtMfkTMKgeTfD8fw5S0 RJhpciFX5zPu3CkhjBRWkzwNBU2zZhcOjVjhKf8KfEr+4b5PJcPZ2LxpSWjXlMFO+plhG8 5d/st6m9RY0uw/w7bh9agxBtvkPuCFc= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADFCE143D; Tue, 7 Jan 2025 01:24:31 -0800 (PST) Received: from [10.57.93.53] (unknown [10.57.93.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96F593F66E; Tue, 7 Jan 2025 01:23:54 -0800 (PST) Message-ID: <83df51a5-5eb9-4470-92a1-e69fd12b98b4@arm.com> Date: Tue, 7 Jan 2025 10:23:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() To: Qi Zheng , Alexander Gordeev Cc: peterz@infradead.org, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <8ada95453180c71b7fca92b9a9f11fa0f92d45a6.1735549103.git.zhengqi.arch@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7C0E1A0005 X-Rspam-User: X-Stat-Signature: 8iyjxwd3gupxkgmhsq1rogjbik8eg9ei X-HE-Tag: 1736241844-347709 X-HE-Meta: U2FsdGVkX18Mtz9VT2rUu9TNEWIpKS9sOry9GdCbPyigybLdjK5+nIFwsG69/iPfINTGSe4TrO9sOrgW/ouPHh7DXo4Ac4kflIspadPtxgS0eT5x9QuL4qTz9VFx6mcDzEX23+TSHDG2DSb1q5bLxT+B0UrSrDFu2uRcUXCYQuJCtrHAfu0oHr12n2dQxdoRhJ4/eXc0Bp3DbJki8W+WtiOmINxrquBOI43ZoyPhQMf9N0JrdtBot2yLElpNbLMsGdU/I/S33T5ZYHkVQBZehqPsAkSZg1n/jn9Ev+TryqTIZR9TexTG1uxSHooDlItvNfRDxOOQsSlh/CiwfFEuvR6Cp1FDz8Jo4AOnjkCP0Wo2WNwkJJDN2Zxt/EG+22u8BNeVfia7fa9ajfCKYHJnTImR51eOpRAF/M6JTFr0M/97gpEk8aa3/+hE2Vd6vQCGiQDeN7o0VBHXjObHkKxVH5JJPeBPWhtxlLErcnCgPvr/r+MOLW0ZbgHO+5MYLRUOi1zFcUw0qljIyt26B17gF6bvaIAome0M2Jo1zn6oiTqywEyA9/2YIBWMzzNl4VuqwTZD6BEtN0P7y3gLvdWxMiqjiO4sYwrP9VEyeFZQPn/I0LQbfFIb1kK9/jT1XyQstXiRnvykFW41VisR/erdQY0Q0n2ct4jKBkjJCzT+CZk/cnKeY1qNdVWpeq7nbh4yJ/EWTVsbFhLnF53f9GWgENNd46AZ1lzDGlVgPRnQH/W6hVVNHiiithT+QyJQlgGodEXFJBfrYNZP2hhp/wLLQ6jsGj5gCSllw6ekhBFuoY73aiRo7FAGUi5kAq7gLRrQYWRnNeQ8HbIVKKRSCnGtR+BUnfIMdADiQgs+u1q2CUEMIHc43hNe6zE9ap9U4ZwmgsxxVuqrutYGoNutj0SWm87W7rrv8wC5wB5GhwKoqdwErrkT0juIASDQpdYDggNCC7NCvA2GrmmFPCE1tb7 6L6fu8ym h4UFbSaTJDMkNt6riU4TpCwE6wOMApnD5s9y3SfTVWjAHUSYJyWwL2N+UoCxFBluAiiLcAlbxBsrDWEIsh0zxuuyvCoYvbmllWMnICJyybMdu/BWwqqxxb/jPglMEH9lQI6wD8bgepaLV+2NR6MgQZoRED+6zvtLJqnMK8n1Gc2fJyzuLXnwJYP0Elph5FPaXvuV/kGD19Gl6rTn0JRWCVHbznDiHJgIJABrEZRzGmH4/eLTxmsatjmNcRVubwlDbjjN9IpCOuFOXufZS1RzBf+y0YHH9ZQ0zTe/fdkJS983CNR5ghl3RHh74pRjmjPTGIHwFNUvjUQjVAS/GCyHp2isaNG5/9MT3MTqKyflBYWCj+/sjCqbAaq31KA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/01/2025 14:23, Qi Zheng wrote: > On 2025/1/6 20:36, Alexander Gordeev wrote: >> On Mon, Jan 06, 2025 at 06:55:58PM +0800, Qi Zheng wrote: >>>>> +static inline void pagetable_dtor(struct ptdesc *ptdesc) >>>>> +{ >>>>> +    struct folio *folio = ptdesc_folio(ptdesc); >>>>> + >>>>> +    ptlock_free(ptdesc); >>>>> +    __folio_clear_pgtable(folio); >>>>> +    lruvec_stat_sub_folio(folio, NR_PAGETABLE); >>>>> +} >>>>> + >>>> >>>> If I am not mistaken, it is just pagetable_pte_dtor() rename. >>>> What is the point in moving the code around? >>> >>> No, this is to unify pagetable_p*_dtor() into pagetable_dtor(), so >>> that we can move pagetable_dtor() to __tlb_remove_table(), and then >>> ptlock and PTE page can be freed together through RCU, which is >>> also the main purpose of this patch series. >> >> I am only talking about this patch. pagetable_dtor() code above is >> the same pagetable_pte_dtor() below - it is only the function name >> that changed. So why to move the function body? Anyway, that is > > Ah, I just don't want to put pagetable_dtor() in between > pagetable_pte_ctor() and ___pte_offset_map(), so I moved it above > pagetable_pte_ctor(). No other special reason. 😉 I think inserting pagetable_dtor() there makes sense. I wouldn't say that pagetable_pte_dtor() is being renamed to pagetable_dtor(), because in fact this patch replaces all of pagetable_{pte,pmd,pud}_dtor() with pagetable_dtor(), and it is arguably clearer to insert the latter higher up in mm.h. FWIW my follow-up series introduces a common __pagetable_dtor(), inserted below pagetable_ctor() [1]. - Kevin [1] https://lore.kernel.org/linux-mm/20250103184415.2744423-2-kevin.brodsky@arm.com/