From: John Hubbard <jhubbard@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>,
jhubbard.send.patches@gmail.com, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] block, bio, fs: convert most filesystems to pin_user_pages_fast()
Date: Sun, 27 Feb 2022 14:13:43 -0800 [thread overview]
Message-ID: <83d98cfc-79db-bfd5-1404-1b7133e5694e@nvidia.com> (raw)
In-Reply-To: <8b5b35fa-3c70-adc8-ca3a-4829388c4d12@kernel.dk>
On 2/27/22 13:59, Jens Axboe wrote:
> On 2/27/22 2:34 AM, jhubbard.send.patches@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> Use pin_user_pages_fast(), pin_user_page(), and unpin_user_page() calls,
>> in place of get_user_pages_fast(), get_page() and put_page().
>>
>> This converts the Direct IO parts of most filesystems over to using
>> FOLL_PIN (pin_user_page*()) page pinning.
>
> The commit message needs to explain why a change is being made, not what
> is being done. The latter I can just look at the code for.
>
> Didn't even find it in in your cover letter, had to go to the original
> posting for that.
>
Sorry about that, I'll sit down and write up something thorough for this
patch. It is after the central thing, and it got neglected here.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-02-27 22:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 9:34 [PATCH 0/6] block, fs: convert most Direct IO cases to FOLL_PIN jhubbard.send.patches
2022-02-27 9:34 ` [PATCH 1/6] mm/gup: introduce pin_user_page() jhubbard.send.patches
2022-02-27 9:34 ` [PATCH 2/6] iov_iter: new iov_iter_pin_pages*(), for FOLL_PIN pages jhubbard.send.patches
2022-02-27 21:57 ` Jens Axboe
2022-02-27 22:09 ` John Hubbard
2022-02-28 22:49 ` John Hubbard
2022-02-27 9:34 ` [PATCH 3/6] block, fs: assert that key paths use iovecs, and nothing else jhubbard.send.patches
2022-02-27 21:58 ` Jens Axboe
2022-02-27 22:12 ` John Hubbard
2022-02-27 22:15 ` Al Viro
2022-02-27 22:27 ` John Hubbard
2022-02-28 3:29 ` John Hubbard
2022-02-27 9:34 ` [PATCH 4/6] block, bio, fs: convert most filesystems to pin_user_pages_fast() jhubbard.send.patches
2022-02-27 21:59 ` Jens Axboe
2022-02-27 22:13 ` John Hubbard [this message]
2022-02-27 9:34 ` [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages jhubbard.send.patches
2022-02-27 9:34 ` [PATCH 6/6] fuse: convert direct IO paths to use FOLL_PIN jhubbard.send.patches
2022-02-28 15:59 ` Miklos Szeredi
2022-02-28 21:16 ` John Hubbard
2022-03-01 9:41 ` Miklos Szeredi
2022-03-02 8:07 ` John Hubbard
2022-08-27 8:36 [PATCH 0/6] convert most filesystems to pin_user_pages_fast() John Hubbard
2022-08-27 8:36 ` [PATCH 4/6] block, bio, fs: " John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d98cfc-79db-bfd5-1404-1b7133e5694e@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jhubbard.send.patches@gmail.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox