From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F26CC3271E for ; Mon, 8 Jul 2024 10:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D7136B007B; Mon, 8 Jul 2024 06:58:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 487066B0082; Mon, 8 Jul 2024 06:58:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34F186B0083; Mon, 8 Jul 2024 06:58:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1688C6B007B for ; Mon, 8 Jul 2024 06:58:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2186AA127F for ; Mon, 8 Jul 2024 10:58:25 +0000 (UTC) X-FDA: 82316286570.18.EB0F73B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf10.hostedemail.com (Postfix) with ESMTP id 4F32CC000E for ; Mon, 8 Jul 2024 10:58:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720436275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ib6jH5XbHyynpkpFYZKj4jtYQCinBh1wB0RC/1LrrJw=; b=HI+ooQ/mGXV3Z6JP5CPbZx0Fk5Zo+i+8WwNo8U6uajxaVmyx/wJmx6xu53WMRrwN0em2LL v0ZG0OoGCk8tySim3SBI78FN7rzbtUQ0OCB514T2Fbi/T7Cm4dcnLcN5szoDq3rcstl3YP poHN7zDaHyKhL+QeO24L5s1cjGpnS3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720436275; a=rsa-sha256; cv=none; b=w3VZS3NAVCaGDzKeEYisZPMtL/WcM0y/PpFdPs8j60JGNmhBnpirEK6HxvGw+j0ElEisCH 9TAuCUPVKGRiA0JotZkyctMyCbTtE4OytBJ/p9O88gqIUMsRPBFaryIar5A22VgyWe8sSc mUgCGxlBPkG8P0hltZJsbhBRkU28aW0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf10.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WHh0v3jkTznZbg; Mon, 8 Jul 2024 18:57:51 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 03C99140416; Mon, 8 Jul 2024 18:58:16 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 8 Jul 2024 18:58:15 +0800 Subject: Re: [PATCH net-next v9 10/13] mm: page_frag: introduce prepare/probe/commit API To: Alexander Duyck CC: Yunsheng Lin , , , , , , Andrew Morton , References: <20240625135216.47007-1-linyunsheng@huawei.com> <20240625135216.47007-11-linyunsheng@huawei.com> <33c3c7fc00d2385e741dc6c9be0eade26c30bd12.camel@gmail.com> <38da183b-92ba-ce9d-5472-def199854563@huawei.com> <0a80e362-1eb7-40b0-b1b9-07ec5a6506ea@gmail.com> <15623dac-9358-4597-b3ee-3694a5956920@gmail.com> <200ee8ff-557f-e17b-e71f-645267a49831@huawei.com> From: Yunsheng Lin Message-ID: <83cf5a36-055a-f590-9d41-59c45f93e7c5@huawei.com> Date: Mon, 8 Jul 2024 18:58:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Queue-Id: 4F32CC000E X-Stat-Signature: fhuqoebzupx8fw3kh9em3f3joeeq7yqg X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720436301-663803 X-HE-Meta: U2FsdGVkX1/4XL324yycpkDRisUogT5EP37/k6qtfWBQa4BtJGfTlpnHyBwfrWwyx1mPurTXNt9tJHrCBwrfRWOpj8LZTtYhGpJVQiWHsFsc/uDet20gpglZ8fquoUlS25/cWX3PGd4+WbRFHHIoE+Qb20Bwgg+9o3d/6YX6K6+W+jOlN7FX4h9nuZgZkjxFpINSTajtYiZeQOacUfpFnepp97JZJcDLrWSSPnMP7d5HUu+hFPXnbJ5+zy83PQbdcS+KSSUJtz99nVhEpbqOy3rd44+95jv+MMn26XPZLV1kJHBpetV3Eji/r8m9xqXDjiRpT3F0gpOaFFHuQO+eTMod2oohsDGHdy6rg5hyetq4Zlw0QJm0krGTAeQSvjEY8Ah5RfVQ9Sk1oZktehwweaur8tGX4KeU/Lv5JsCkJBsLeiN+XHtc3/u0KjAx0Uv8kfV2M5IMI4/1puyRnPUkOAeuFa1N8kaR4RwbKyxhNJgXbOsuGHQqOiWRZkpR3C6CqnizjhpJ9BDRL9/nlpKa3HYVfe0BTOaCzC8i1hfU8FPgu+Ekb7xPEDWtQjDXI1YV0xQgLpdKcsBz0Axngx7hP7OK0OE2tmGOPCf6CImVu3fs8rPq4P3PHpxp3zcLF49zjv0SNGhawv/8YX37rTDZItEKmLgy72tynGYPzeS+BDeXV5EPhPgmCm+gfaOuX5VHk/IEFpC21YRSbTUCRM4XVHSZDXLyjpfYaMV787A0NupQFVAo0To16Jv6+WxPlDrlVgit7OfCekMbnqjwxst2RxBn127SmgpOFB44FnO53kC7UqPa1k2zJBFMzAgk58LQ8h3kbD5CkXMA9PdpCmGymcKxQyUBx8tm+vvu+rWZS5o5FOf9tEsyvUbQcjbS7gAtP0BmWcFaznXkKmtP4HIOuEMllYXcjBG4ToQgpcHep3O5OqOXsDC7qzNUfZx1M5jYKrlEaGCy9D6XcnqfjfF nGAhGv4r f9d43s7YoZ4MfCXkUUnLs4blY7NkK9m5Hc01ktg4oK2nI1FG7pmcqMaKM6KaEZ86d34/E9A6oI1dvO2Ga0jhJHpMFPaH7U0VNPeb8fJjo9NyymHGgAgbGCBg4ziQPxzTyTR+8KeI05JdiDW4VmrwZgz8oaqeWJewPHrPk3KeH+L9i1iBIxIFDprEZJ0WWCRHoyEVkO1aU+hO4vVSs7zsgvE2v+FxR73SLXfll6SYZxLTzvvx15d6HG7TBuDYPsFFApDO/D3ufnX7c42d/xkVjz6xM1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/8 1:12, Alexander Duyck wrote: ... > The issue is the dependency mess that has been created with patch 11 > in the set. Again you are conflating patches which makes this really > hard to debug or discuss as I make suggestions on one patch and you > claim it breaks things that are really due to issues in another patch. > So the issue is you included this header into include/linux/sched.h > which is included in linux/mm_types.h. So what happens then is that > you have to include page_frag_cache.h *before* you can include the > bits from mm_types.h > > What might make more sense to solve this is to look at just moving the > page_frag_cache into mm_types_task.h and then having it replace the > page_frag struct there since mm_types.h will pull that in anyway. That > way sched.h can avoid having to pull in page_frag_cache.h. It seems the above didn't work either, as asm-offsets.c does depend on mm_types_task.h too. In file included from ./include/linux/mm.h:16, from ./include/linux/page_frag_cache.h:10, from ./include/linux/mm_types_task.h:11, from ./include/linux/mm_types.h:5, from ./include/linux/mmzone.h:22, from ./include/linux/gfp.h:7, from ./include/linux/slab.h:16, from ./include/linux/resource_ext.h:11, from ./include/linux/acpi.h:13, from ./include/acpi/apei.h:9, from ./include/acpi/ghes.h:5, from ./include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: ./include/linux/mmap_lock.h: In function ‘mmap_assert_locked’: ./include/linux/mmap_lock.h:65:23: error: invalid use of undefined type ‘const struct mm_struct’ 65 | rwsem_assert_held(&mm->mmap_lock); > . >