From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ACBC77B72 for ; Mon, 17 Apr 2023 10:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 628048E0002; Mon, 17 Apr 2023 06:06:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B0CC8E0001; Mon, 17 Apr 2023 06:06:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 452AB8E0002; Mon, 17 Apr 2023 06:06:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32A388E0001 for ; Mon, 17 Apr 2023 06:06:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E812CAC0C0 for ; Mon, 17 Apr 2023 10:06:39 +0000 (UTC) X-FDA: 80690453718.06.A7BE186 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by imf07.hostedemail.com (Postfix) with ESMTP id 97D6040013 for ; Mon, 17 Apr 2023 10:06:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681725998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvoChs07TtJBvrR9nhSHHHd5bNpAHt+w/vyzQ3c9n4c=; b=rqnOpJyoi4cLfZLpzYfb/+NEc5OoFQEFEMmDXuuhQ/aymabyPI/dQmvyhi0hmEn+pwMOvJ /J3kWhj7PTd16jnDqq5fFuYos2wUggxowS8rotfOWkPnWaLQCR8lKaNtutjhY3pv3+ICwW rFaKirwNNlUYfK7AQjVrDWm4c225o+Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hal.feng@starfivetech.com designates 61.152.239.71 as permitted sender) smtp.mailfrom=hal.feng@starfivetech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681725998; a=rsa-sha256; cv=none; b=cifi+ZM52JUlAm5rfBZ7ZAD0EG0iAn33pxV6cRpce/BOJqvakt8j2LACm+5AHtK7dnMJIX gymyfXFGhHox0xr3mS3sopkefMDfGLE6q/Qo8UxZ9aGmFa+PcKMnGcuNwt4OuBpwSp2wnY T6aAP/wNlM8ajLX/tuG6nX3cqizjj7w= Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 276C824E289; Mon, 17 Apr 2023 18:06:31 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 18:06:31 +0800 Received: from [192.168.125.87] (183.27.97.249) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 18:06:30 +0800 Message-ID: <83c5a35a-c646-cbc7-83f9-c02fcb24e069@starfivetech.com> Date: Mon, 17 Apr 2023 18:06:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Content-Language: en-US To: Conor Dooley CC: , , , Stephen Boyd , Michael Turquette , Paul Gazzillo , "Necip Fazil Yildiran" , Emil Renner Berthing , Xingyu Wu , References: <20230417074115.30786-1-hal.feng@starfivetech.com> <20230417074115.30786-2-hal.feng@starfivetech.com> <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> From: Hal Feng In-Reply-To: <20230417-buckwheat-wilt-92a4e85a5ca0@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 97D6040013 X-Stat-Signature: 8owfp7cj16w9j73q1bjeath8xszwhn1o X-HE-Tag: 1681725994-886356 X-HE-Meta: U2FsdGVkX1+HUBll09uYIghOtJwuiNRQc0L6VYpbiH39kgR99HyV9W3LtijzxQlrs8vjo/Ij2PJPk0ueywkEiXAiy7rRXeGKYPEqxKusu4qZ8XR9NUK0XK9HKsdC/7/P87UF0iNI4hgMjrkhvyXTa79JvDorN3tTaS1wCmIj9sLtT+WYE9sF/VccIwd35rB4dnTJIgpfupVYymdqz8ztRaLFpr32fZTWMzGREuq55FfeteSICizpfu2XVgQgNR9DZqqoKEljN6mpaC8XjRkafBpyraIP9o5esoq5lJNUrzdcbmrq4JPE2sfh1s8zThDpeqNYvJD/dpgUfFbhNzvcuKpwd1XLislkNcrPSl9Z/5XT3jRiZEXEYDGHOUATJN+besU0gtBkLWlMx02Vg13OpSjSqiqnHl76CdXM0lWBbVxzshTXr+sr+WTHkK7mIyNg+1qPJRUSFbZBgUF1CBWN84AAmVvtRuSJ/1vUs6OCKtKPefaCpvpcGE3uIfZfFF4mqzR0WWf0AYs1L/RhRY9xxw9CXCnrnWVZj+bGeDF01wxzYHJX//4vSTunPL+R5FnVwPbK2LTWWpwzqJzlew1JByL3cfGRcQOBBhoWlnNCt6UPuXtA6vbSMu+qJ36nStDBN/H02VIHK4KyBTzUJ7RV5fZ+FwPn3Joog62vIYNPyBflxO8yYt7oQZBaREzv/AK63wwvhycOKDa63Qzh11NcUGVNfZQCTXzqXxG9k5HG08s55z2rV2Ma3fAQEJItdEpWrRT9tNGosuh5S8OzFkGmTqh1ztkTnx5BPFTglLLYxWnFaqib6AjzEGEoQSlGOK/4+9UadDZ5EzICVwJIR+vkYp8oxMCfJDOCzQwGFyRx9E/DgOQHC24862od3DAqXG3KvKcLO3bJPlqdVsvkbgwfGFttH8JQC16d1NjmoTOx3gxCGRLHb8k5tIzoyWZJap1c4QdPPSRvxmzfLS+YmAV Qe/wP20+ LqQSxbLWvrAAYRuF3qI3FFRpQtIDQ3LaSPCniNl3hVX8rFfV+iFg9ne2mV24l3clJSwATRyOtDPa9+uManikKzoyQ1P47eAwLrnGvvKop9RCWpEHYA8w/nfhrrLV4ZG3ZkMgozfyEiNo7s7/iCabw8o3DAxAYVIXTYwC8AWWAQSws+APa1QMUOT3S9VwK1ZhB+QVkzHQHJjHiq9+7ykWLOwywfrcDI0XVwplpie56G9rg4cg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 17 Apr 2023 10:54:09 +0100, Conor Dooley wrote: > On Mon, Apr 17, 2023 at 03:41:14PM +0800, Hal Feng wrote: >> When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), >> RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS >> and CLK_STARFIVE_JH7110_AON. >> >> Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation >> test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant >> selected options of CLK_STARFIVE_JH7110_AON because these options are >> already selected by the dependency. >> >> Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") >> Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") >> Signed-off-by: Hal Feng >> --- >> drivers/clk/starfive/Kconfig | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig >> index 71c1148ee5f6..3fad4adee841 100644 >> --- a/drivers/clk/starfive/Kconfig >> +++ b/drivers/clk/starfive/Kconfig >> @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS >> depends on ARCH_STARFIVE || COMPILE_TEST >> select AUXILIARY_BUS >> select CLK_STARFIVE_JH71X0 >> - select RESET_STARFIVE_JH7110 >> + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE > > Hmm, I don't really follow the logic above. > Why not just make the if be `if RESET_CONTROLLER` rather than > ARCH_STARFIVE? > I'm probably missing some obvious reason why not. Note that RESET_CONTROLLER is selected by ARCH_STARFIVE. Thanks. Best regards, Hal