From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F79C10F00 for ; Thu, 28 Feb 2019 12:39:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 586B9206DD for ; Thu, 28 Feb 2019 12:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IbMr9pBJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 586B9206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB17F8E0003; Thu, 28 Feb 2019 07:39:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8BDC8E0001; Thu, 28 Feb 2019 07:39:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C774D8E0003; Thu, 28 Feb 2019 07:39:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f69.google.com (mail-yw1-f69.google.com [209.85.161.69]) by kanga.kvack.org (Postfix) with ESMTP id 9A6788E0001 for ; Thu, 28 Feb 2019 07:39:20 -0500 (EST) Received: by mail-yw1-f69.google.com with SMTP id z64so11248556ywd.12 for ; Thu, 28 Feb 2019 04:39:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding:dkim-signature; bh=kyaLnB1yS2uNDTq/sCdbM9/derGqD4nWTMhtRkekS5s=; b=JUyT3uVhGZC0LgnGV2KuLS9/QUfLpQm1lXON4NzkT4KezRZySfgLubqlnkbRQdrNw1 Z+xZKickvp5FIGzxSiDfxBZKLwFUExLxa2bRSNooIQj3TIWNjLJyEzHTpE8QPDY0ObGv MQyeB0Rb7CdW1DpMorUButXRck9/BeLREAtcj9XV7LFOF6diCb3OqMuMa7I1lVOMqhoL JMRNIOQKNNjtRLbObAW0l1pjd8DuQqjkF4t91wd0PRmB/m8OKm25oIP3nYJVF2CZymHw m+EDSohVdV+MRuyGS57D9fyB+OBtXts0hN6PDRyIbEd5M6J4w/pF1N4249KixnwVkv2I GI4w== X-Gm-Message-State: AHQUAuaaYDXRhEPfEvz60RI+Q2P+k6IMYdKezo1Oa31KYxpL1F9AzemP q11d4PtswzKc9DCiZ0sua5fvT0773ApYhixPGXMiuk/zJygJaQSl9qZq+vcTnGNyNT/g+vF9sTK ZPdjQWAFJX1WTrVktw1w8TredPl9A5X1vzHPpPO5qQmsGxvhKeZO/bMWMWU3rGpb6hg== X-Received: by 2002:a25:60c6:: with SMTP id u189mr6219398ybb.113.1551357560356; Thu, 28 Feb 2019 04:39:20 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibq30iD2wp2LnAEkOB4CYN0zJXjecSkbbVmPyYAQc3t1W0jQceu2KJrWL6nHHZcjhurDoOL X-Received: by 2002:a25:60c6:: with SMTP id u189mr6219349ybb.113.1551357559454; Thu, 28 Feb 2019 04:39:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551357559; cv=none; d=google.com; s=arc-20160816; b=rPSlSB3WcdHHeBphDaHRb+MCHc1DiYQH9ykVGM+qsLjYjivQFsYnw7qA7+dHOjOqPR v25QN1JjlOW8rbCMl+uje4cyU0HsyRwg762hNcq0pShdvNmgkX5riR3Y8oBPu2Wglywk QO+PRY/AUeaWS/WKzBHTrdmIDuDk7etJ/0jHs9XU1LF3CUHMN1OlWBFD8x/SLVfI8p6T GD0hd87lpdnP4vbkciW8KCcKXQdJMYQBRWFO2jRlNRSyJgcYKrgZwQ68Gy2HGpGsGXE2 5wP8z9o03Mc253wFVB1NM8qu4S5NXIa9JIGNAiLAze9qcSDI/ly3GF2psFYSW406WurL AdeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=kyaLnB1yS2uNDTq/sCdbM9/derGqD4nWTMhtRkekS5s=; b=xBhGBnigLojzyh+wZnrVxaBvb6PcQ3zZrg0eJ5BXemiQPcfLHOZxn3jlilu6IX7pOw yN4w+lPzqJCltiYWs9fcFM1mehQVLxsRu7z4hroKn9ihAYUVUyer8xLGrkwge+sZAHZv RcAhm07uYpMrNwqlLNf9kcN9XuuTIkxBoABbJXbX4IA/BuLC/IfNi8R/Y1ePUn2jTz1q a3V83pgZYye0Eld28vnMi0g334srz1HNrlvfm3JHMFMvcDjzGZzoomgIbKNdCwrcxQxy VJXNQS1uScaQX/kZv1opiRbjfMKcZye9do1NyZSOFmK1Px4ojpeTJdxRro2vJhqMxFS0 cnDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=IbMr9pBJ; spf=pass (google.com: domain of jonathanh@nvidia.com designates 216.228.121.64 as permitted sender) smtp.mailfrom=jonathanh@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by mx.google.com with ESMTPS id 197si8449733ybf.108.2019.02.28.04.39.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 04:39:19 -0800 (PST) Received-SPF: pass (google.com: domain of jonathanh@nvidia.com designates 216.228.121.64 as permitted sender) client-ip=216.228.121.64; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=IbMr9pBJ; spf=pass (google.com: domain of jonathanh@nvidia.com designates 216.228.121.64 as permitted sender) smtp.mailfrom=jonathanh@nvidia.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 28 Feb 2019 04:39:13 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 28 Feb 2019 04:39:18 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 28 Feb 2019 04:39:18 -0800 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Feb 2019 12:39:11 +0000 Subject: Re: [PATCH V15 14/18] block: enable multipage bvecs To: Marek Szyprowski , Ming Lei CC: Jens Axboe , , , , Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , , Alexander Viro , , , David Sterba , , "Darrick J . Wong" , , Gao Xiang , Christoph Hellwig , , Coly Li , , Boaz Harrosh , Bob Peterson , , Ulf Hansson , "linux-mmc@vger.kernel.org" , 'Linux Samsung SOC' , Krzysztof Kozlowski , Adrian Hunter , Bartlomiej Zolnierkiewicz , linux-tegra References: <20190215111324.30129-1-ming.lei@redhat.com> <20190215111324.30129-15-ming.lei@redhat.com> <6c9ae4de-c56f-a2b3-2542-da7d8b95601d@samsung.com> <0dbbee64-5c6b-0374-4360-6dc218c70d58@nvidia.com> <20190227232940.GA13319@ming.t460p> <01155e88-f021-fbe2-d048-42e303fe2935@samsung.com> From: Jon Hunter Message-ID: <83c1e25b-4aab-4374-e160-b506eea9e68f@nvidia.com> Date: Thu, 28 Feb 2019 12:39:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <01155e88-f021-fbe2-d048-42e303fe2935@samsung.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1551357553; bh=kyaLnB1yS2uNDTq/sCdbM9/derGqD4nWTMhtRkekS5s=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=IbMr9pBJuBI/5AbD0dC5l3dawgXept/qlylzk0GIjWO3kmfIarTR/gWqLma/G6QW7 QA1IecDz5AXvEeEa1vA8ApQJcym13C8r5dqcQJFUMSda6+U4j4lZ0V6gU4W7aamSrX m+JRZW58fX6DtULpWLS9BsSfa4PjeWfP/3xcaEB3c22HZyi7lEpqH4l8AWCCiQl0D7 g8u2jtc3u01z33ZlZnGhXxk8gfT8LjZKgnLHRyeI+MxQUVwCBl4wHHBT/S1/WwV1cO e8wdRmwYaz3kMXRbC2iR1CDKeIJRnxvt4wP6qPVIH0DtIGLgbocKla2k/F6gPPwt7J oVQzg1220HnDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28/02/2019 07:51, Marek Szyprowski wrote: > Hi Ming, > > On 2019-02-28 00:29, Ming Lei wrote: >> On Wed, Feb 27, 2019 at 08:47:09PM +0000, Jon Hunter wrote: >>> On 21/02/2019 08:42, Marek Szyprowski wrote: >>>> On 2019-02-15 12:13, Ming Lei wrote: >>>>> This patch pulls the trigger for multi-page bvecs. >>>>> >>>>> Reviewed-by: Omar Sandoval >>>>> Signed-off-by: Ming Lei >>>> Since Linux next-20190218 I've observed problems with block layer on one >>>> of my test devices (Odroid U3 with EXT4 rootfs on SD card). Bisecting >>>> this issue led me to this change. This is also the first linux-next >>>> release with this change merged. The issue is fully reproducible and can >>>> be observed in the following kernel log: >>>> >>>> sdhci: Secure Digital Host Controller Interface driver >>>> sdhci: Copyright(c) Pierre Ossman >>>> s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 (100000000 Hz) >>>> s3c-sdhci 12530000.sdhci: Got CD GPIO >>>> mmc0: SDHCI controller on samsung-hsmmc [12530000.sdhci] using ADMA >>>> mmc0: new high speed SDHC card at address aaaa >>>> mmcblk0: mmc0:aaaa SL16G 14.8 GiB >>> I have also noticed some failures when writing to an eMMC device on one >>> of our Tegra boards. We have a simple eMMC write/read test and it is >>> currently failing because the data written does not match the source. >>> >>> I did not seem the same crash as reported here, however, in our case the >>> rootfs is NFS mounted and so probably would not. However, the bisect >>> points to this commit and reverting on top of -next fixes the issues. >> It is sdhci, probably related with max segment size, could you test the >> following patch: >> >> https://marc.info/?l=linux-mmc&m=155128334122951&w=2 > > This seems to be fixing my issue too! Thanks! Thanks, I can confirm this fixes the issue for Tegra. So feel free to add my ... Tested-by: Jon Hunter Cheers! Jon -- nvpublic