linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: jane.chu@oracle.com
To: Miaohe Lin <linmiaohe@huawei.com>,
	"Tomohiro Misono (Fujitsu)" <misono.tomohiro@fujitsu.com>,
	'Jiaqi Yan' <jiaqiyan@google.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [RFC PATCH] mm: memory-failure: add soft-offline stat in mf_stats
Date: Fri, 6 Dec 2024 16:17:17 -0800	[thread overview]
Message-ID: <83a8698a-fe11-42e2-8a4b-ea236721f93f@oracle.com> (raw)
In-Reply-To: <098640ac-f1c1-95b6-e367-a2673c3ceaae@huawei.com>

>>> And
>>> 1. total = recovered + ignored + failed + delayed
>>> 2. recovered = soft_offline + hard_offline
>> Do you mean mf_stats now have 7 entries in sysfs?
>> (total, ignored, failed, delayed, recovered, hard_offline, soft_offline, then recovered = hard_offline + soft_offline)
>> Or 6 entries ? (in that case, hard_offline = recovered - soft_offline)
>> It might be simpler to understand for user if total is just the sum of other entries like this RFC,
>> but I'd like to know other opinions.
> Will it be better to have below items?
> "
> total
> ignored
> failed
> dalayed
> hard_offline
> soft_offline
> "

The existing "ignored, failed, delayed, recovered" apply to UEs while 
"soft_offline" applies to CE. The difference between UE and CE is that 
even a recovered UE page has PG_hwpoison set, but a soft offlined page 
does not and thus could be re-deployed.

So if we want to flag CE pages, they seem to belong to a different 
category, something like -

/sys/devices/system/node/node0/memory_failure/Uncorrected/{ignored, delayed, failed, recovered}
/sys/devices/system/node/node0/memory_failure/Corrected/{offlined}

Thanks,

-jane

>
> though this will break the previous interface.
> Any thoughts?
>
> Thanks.
> .
>


  parent reply	other threads:[~2024-12-07  0:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21  4:55 Tomohiro Misono
2024-11-26  3:09 ` Miaohe Lin
2024-11-27  2:32   ` Tomohiro Misono (Fujitsu)
2024-11-27  7:06     ` Jiaqi Yan
2024-11-28  5:46       ` Tomohiro Misono (Fujitsu)
2024-11-29  7:07         ` Miaohe Lin
2024-11-29  8:26           ` Tomohiro Misono (Fujitsu)
2024-11-29  9:07             ` Miaohe Lin
2024-12-07  0:17           ` jane.chu [this message]
2024-12-10  8:46             ` Tomohiro Misono (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a8698a-fe11-42e2-8a4b-ea236721f93f@oracle.com \
    --to=jane.chu@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jiaqiyan@google.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=misono.tomohiro@fujitsu.com \
    --cc=nao.horiguchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox