From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F75FC83F22 for ; Tue, 15 Jul 2025 10:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A55FE6B00A2; Tue, 15 Jul 2025 06:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A069F6B00A4; Tue, 15 Jul 2025 06:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F5AE6B00A6; Tue, 15 Jul 2025 06:22:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 76CE76B00A2 for ; Tue, 15 Jul 2025 06:22:24 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3C1FB1DA011 for ; Tue, 15 Jul 2025 10:22:24 +0000 (UTC) X-FDA: 83666109408.17.67FEBB7 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 3AA57A000B for ; Tue, 15 Jul 2025 10:22:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GRlc/SBE"; spf=pass (imf15.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752574942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2crJGfvy9Jnr87YgMI4zA0rz0NIO2gRU/WUVx+zJOAU=; b=xTkwpTp7bIYRNdz2sSCFGVLfhA6LyXLmAAih4/TwbB1Kjhvs2KAfT3V2iEripSlZKDefnx gpJdVsC0UPVwdVipp1CHr9pgiDwVKnZhhz4DE8Tf1CTzy26xUNxC7bWooX9RdDgHgeFtoj ecT942k4LvEEMjvnILvVx0p59gCuwt4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="GRlc/SBE"; spf=pass (imf15.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752574942; a=rsa-sha256; cv=none; b=LOtX7Nspk930frduVegRjokylYf7evs9Rro/drenj9VQWJPZSHf6vnV5mRM1Du6lFhKw8b 1x1KgToRQXiTObJ+sJj6hvsjwXrdhHE0W8+egIjHO2cB6g/wINMH6ILKijKn9pmNHLXolO iuEQCtSGPY1kiu/nhhUxV/mmsxC7QFw= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-604bff84741so9972839a12.2 for ; Tue, 15 Jul 2025 03:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752574941; x=1753179741; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2crJGfvy9Jnr87YgMI4zA0rz0NIO2gRU/WUVx+zJOAU=; b=GRlc/SBEkFC9UAS99/BbVQ4EudoVdRO85MFjhbun0bIDcJnvTA8nvEXsYZQouOEB3j +bgFRoK9VVO6JExaoatEMc8iJFcM328+Raz13QJOc1f7lT5RJc7GFuSGZ7gUW7dttcWh yT4Ym7fRxVTb99azW4KgVVQ90jQJN1ok2gK98F0d3Fi7pSBEmKHBUsB10Ssq9wslPqIv PTdu0gA0Dz2XLkCmi2Lf1Kr/nVKPdL4WbpFXMRpw5cbty/eU0165er95CsfRxy0W7Wmu sxOQwKafkiIvAGx+K0cBkIPF5X/E3QkjnNL3a2AjW4ntu3ZWayn6j5jjJPPW9CgQ+6Ii MXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752574941; x=1753179741; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2crJGfvy9Jnr87YgMI4zA0rz0NIO2gRU/WUVx+zJOAU=; b=c71qXrEOWwaiFMmJdFEMOXyClpqY518y8kKN41yp6mXOOV72qVLIlKbM8lzhLWMr1W 1hQV5/1ga67Ye7T88KXStsJUUXzZ9tSfhYZyP7v8qGBVMu7BQWN4BA3DzL8n7EKJy7C4 oP7jXeDngvCbAfXYKS/JxrA3tSAFA3T0l1O0RDjwrLfGieLmFHoi25vuH6URfT0j8uOo R4ThSjcY4cbWPYiJKfO/RAcKGDngBchLCzrGtlh33m1C7gLw0X5jmdINCw+ormZ2ZjJq X20Y/T24pgSfzdgtoJ9g48njzcdpAKH9onam+tP+jGQmYXBEpVcOkd1EVzWhG67V5eNO 6H1w== X-Forwarded-Encrypted: i=1; AJvYcCUJyOBZ91YCDXfd804WMk90bI4Kq4hYTDBOTGbBx02g5nPvCtajIA8tq7Yiv+qIdT3ekXN5wONWcA==@kvack.org X-Gm-Message-State: AOJu0Yy5OUu127K8c/Pj3D+9iVa3NSl6D0vUYetyN+FWFSxCh/YEsvv1 uy7DtdtsOK8XD1GmSc8HDX0yciB0vHpzJv0iUP0az9HW21LIaVAat5/H X-Gm-Gg: ASbGncvccjEE29q2Xq0ayC0g8ZcxchjGszLILRtApjv8tU1psgpC2AHDbHFvcsiXUqu qmx9IXVzb5o7Fd26ITlYR2+V8GIqGPi45Xiwno0cpyf/7GMv/yL6rd9qZ8cCcBk68bRkzwli/JT lSS/qJYxOMJfW1Ftu3DbZQmClIZ5Slf0G3JFsa2OEpUsIYnaon283rP1fccXjQtpZhO3lYccmST dvAMxqT6QWHYJgPoqGlhwzHjfs8QLRp1h9/EsIKLSl2dCcMng/OJsmr99WGWA0I85YRfAfzJtcl IImQiEl82a8VRhMlhP5EzIi4ZdcC19W1UFZHZ/cl5tgfN5SgNJTWBYYETYOhPPLsrlXeULEfxSg 6R1l/fgaGVk6VQ1zcVAJWaQcWTaa9VHxciPc= X-Google-Smtp-Source: AGHT+IH2Fp/Hb7ISJckZNbpE6kxbt03ub1njSzKQw/Kjz/TN3XGfF0/RC3z3jw0kIXpvnI8LNZUctg== X-Received: by 2002:a05:6402:3485:b0:608:64ff:c9b5 with SMTP id 4fb4d7f45d1cf-611e76580bbmr14606034a12.8.1752574940393; Tue, 15 Jul 2025 03:22:20 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:a4c1]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-611d8d54112sm6292085a12.1.2025.07.15.03.22.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 03:22:19 -0700 (PDT) Message-ID: <839d5486-a92a-4ae8-a536-b4a0e3d595ea@gmail.com> Date: Tue, 15 Jul 2025 11:23:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc mirroring struct page To: Jakub Kicinski , Harry Yoo Cc: Vlastimil Babka , Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, almasrymina@google.com, ilias.apalodimas@linaro.org, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com References: <20250625043350.7939-1-byungchul@sk.com> <20250625043350.7939-2-byungchul@sk.com> <20250626174904.4a6125c9@kernel.org> <20250627035405.GA4276@system.software.com> <20250627173730.15b25a8c@kernel.org> <20250701164508.0738f00f@kernel.org> <92073822-ab60-40ca-9ff5-a41119c0ad3d@suse.cz> <20250714184743.4acd7ead@kernel.org> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250714184743.4acd7ead@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: kq9pdgg8fiewejxyzoz7acuf61uhodkc X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3AA57A000B X-Rspam-User: X-HE-Tag: 1752574942-898387 X-HE-Meta: U2FsdGVkX19cQ28Hx/5UjgOraXrb/yFszlcxfIFwxHV0CmWTBlKBHM31cfoR/IPtiqWD/nvoqDT5NVuJJnvGRH8nt5D5xuV1WuS4mde2qVlVM9tEgM9Ok228pfkHxiG7XKsAy3TMk1AOKamTRQOSm1WbwSvYxfR2ET5HMjxedeHJ83CVdHlh6H3ST4mHsfVj+/dWfBpRZGulFzv8hFqoeSdA8YjHA8HdQXKJsNbeqx6ElpqILUlY/WuTkkNsmXtYtR6qDTVHiq/FLOGA1EPW5g+u6uhgXehpmvypBPbGYic49P9/5Pb3ew1inQ7EraBHSrv5DDBrRMjBn3keLJzPO/gN13ir73JhzcxkE2C8Su9LdiMASC6oKynKGCuS187LznFueyZ0qIsmOtc1Xm6XBP+jLzJtrkDX95HDPKTTvt3TungIE0cL/x4+Ake8Pn3O+h+obeoP0a2WzQde2+Aj3EQDsBDFm/f7bwLiOPC6gvoRMfQvNqH0zVNEj4uW/+VaokcnxFHLgS51gZWyMBvMDSstbrrHnFYtl+v1q+wIx27/vsXp/UgTyTRPAhj/zM3AGrHEKO4iAzgAOOJzR1Z0xw+FplPG6eaHpYFqfWQbMzejw97LcrJpB0f0fwuYl1poQ6dX0IIZtdlzERo+t/UimEWK3cSRJ2iA0M7KSt46J3cz0cYx6SqMdVguWM+JucOu7LU/MF5gtoj8hjmSov1cWwM99m/BU5lIXPmmA3FDiKvZCiUarUp9qpnQYs6c0au3sG+wC+1ojb/KBWBgPl5bdBfCWdVNXjg4d4sjswHkVNBPrFHm7zK1Xhkzy+3tdxjqkP3/Z4IBR/fyA/N6QoXHKCExUp5QyoizQ6z/8qel3CVtfpKEoeJbxAigpatfhkaLwSeu45cls9LfvF1AD9ZSjFwRHzq9etXazStpMzEIrHM7A3VovHhnTA9bpNjrcfRuk4EhJPC+M3bOUWqUJXa FhDIEeDx NoY/5CR0C9eezijXPCMul8Ae4G3BpyHb/Lb6LYML6iB1E2wkZNPl6vgMimWNvQhLQwvsbsZGfozeqOztEPgQT/f0d7MOBI2rkrs7j8d/UAHoexixM1xX7NIZPImtLKrEuJrPe47fEaZDit+Tcu0lUWxOzTg5hc8PYEGOthX7scO2w2ukgEeHzESIFCs1/4Rvc95ZFlQ6oKiB8mZarZdQWCooptZjRgP5CABPPROqlz4y8uyZGL3NU+j+Ar4dyhY0nkcHmfp5yLMjUarNCQVSWIfOmhOsLEJ0A4uhADrlBFsKQgX19CDpuYN5KA0rGAklv4UjQqaUn0yabMZNnWMnYO3WnrZs1HAcb6ki5dd+RYYoDUuFmKbVd4/C5vyYm/OlGKwm4FzYcjhq6Knnxc9V0m55A8tYkfZn1rHFZgF8YQkqRXLE44auqthSxTfoqhe0zDv2HyNVd5NNm9n8fUom6bOnPdZnZ0qs8911iQBzb+yFszKSU02cOYIBWD2ZvaPrfLhsvvO3fh84mqL9xm1DwZSszdxv76i5GdpAZO3KtJnex8Pv3/Q24tqpCSqccn0xxSbReaGndQAsj2IRxQx4T4lDtLUXfxvre2Y0jJVZpcMI9SSdmGbv0MWst69JL61quEyGWlq/RcZxNUlQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/15/25 02:47, Jakub Kicinski wrote: > On Mon, 14 Jul 2025 22:58:31 +0900 Harry Yoo wrote: >>>> Could you please share your thoughts on why it's hard to judge them and >>>> what's missing from the series, such as in the comments, changelog, or >>>> the cover letter? > > My main concern (as shared on earlier revisions) is the type hierarchy Quick overview. struct netmem_desc is a common denominator b/w pp pages and net_iov, and contains fields used by the pp generic path, e.g. refcount, dma_addr. Before, pp was using type casting hacks to keep code generic with some overhead on bit masking, now it'll be able to look up netmem_desc from a netmem and use it directly. That's pretty much what I was suggesting niov / page aliasing to be 1+ years ago, but unfortunately that didn't happen. It definitely removes some type casting hackiness. > exposed to the drivers. v10 adds a bunch of "pp_page_to_nmdesc(page)->pp" in the drivers, Not sure I have a strong opinion, but it can be turned into a helper. Converting things back and forth or blindly > downcasting to netmem and upcasting back to the CPU-readable type is > no good. -- Pavel Begunkov