From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A00BD13570 for ; Mon, 28 Oct 2024 10:01:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 201906B0088; Mon, 28 Oct 2024 06:01:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B1D46B0089; Mon, 28 Oct 2024 06:01:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02ADC6B008A; Mon, 28 Oct 2024 06:01:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DA0B76B0088 for ; Mon, 28 Oct 2024 06:01:52 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BE69A141D45 for ; Mon, 28 Oct 2024 10:01:28 +0000 (UTC) X-FDA: 82722568698.27.6B6C0F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id A0DCEA002F for ; Mon, 28 Oct 2024 10:01:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iISyG2c1; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730109631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w5nVrwZnWBtfvpW73+GNuZREFsNeTOMqg+v6cqzoFyE=; b=0BSx5RM6WhSoBwOj7V7IbF1t33VPzDalenATZgJzc5QHKribV0nZNcBsX0p22dvjfZxv0K o0jdFLs+f5m3KWpgCKaJa3NU5uS8GhzcQU53qvL+cjA03cgPCEhb5L03BK8y6yiU8dsmwm nUBwWmsJ52oBqr6WCBbfGnOQkNfiYa0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iISyG2c1; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730109631; a=rsa-sha256; cv=none; b=H9ZDlOhq3kIfksMcrtVNuCGWF8ZWz7NNoae5+94a5cbKUdPr2T1CIB5SMnfFY/eQO9qVZ/ 4xK9cWJXQLIPJ05Rv3hH1XkprOwdTWV5mCXnztoR2XOeH6qX2w7eznYgZd/MyBU5VZQhVS l5UtQ7MBlHmv5Nso5x0tPXpjkEOhVuo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730109709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=w5nVrwZnWBtfvpW73+GNuZREFsNeTOMqg+v6cqzoFyE=; b=iISyG2c1UPKJ6Hm2l0GrI1H81k6v4J/AmM1N8LRn4FXkGZNRDWNwD5mGvQZ4PT5ZJnhCaL UXtL52f6drokkhYzTf90zovGys6YTX1PJo7q5CXbi0HR+FxJQVER/ZWAu44UK5cENvfmJw 2jYJShZdr/M49CwI0+WDVVQ9gtQVziI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-65JXH1sGOKOnA3TTggmsug-1; Mon, 28 Oct 2024 06:01:48 -0400 X-MC-Unique: 65JXH1sGOKOnA3TTggmsug-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d662dd3c8so2222406f8f.1 for ; Mon, 28 Oct 2024 03:01:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730109707; x=1730714507; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=w5nVrwZnWBtfvpW73+GNuZREFsNeTOMqg+v6cqzoFyE=; b=MdZ7ybMIuivPY3mu21uId8KAf8eWc+IdsZitUupHu2tZWb13bB2KwCQ3QbUKp9P7h7 b1pY2WX9vusZ5LmtMU8z/eC6U3s/tGoArL4GZd2YHjATtTyb98jMkuddL+wRWMAAGQm8 QNWBZ4YKopPEdyoQW+a4L1g0PqAdNnt7v20TJM6HbjYlG9WWncXWHzD9pmEzxdDnZqEF sw4hicgBcFVXgQKF9wr7MDHL3z86nkLaEj37gmVN1hJu7XR56LvHT6R5xt7hK3+/FQr/ J00+Nv7f+6pZaFIWKQXzaekzeeUDi2JVvnmxjajKqvskqcKGTeOFJtlZQyXgYIrLKFST le7Q== X-Forwarded-Encrypted: i=1; AJvYcCVLrRmr9b1FMlr9ik2toFOouMLniSTZ86jSGsy2v+c0oEj/5IB6sRdpFf8bWpldM4pIh95oXzpuOg==@kvack.org X-Gm-Message-State: AOJu0Yy9oQJncwTKdsHwZvpwBvIvP2iHB8fp+6j2hgntxvDhun36z3h8 jQSXtAbZM//bid5lBazi6DdqA4sec0wg8m9CGEcUOL1EBuJCZ+FF8VN47f6Qk+HqnLHtyO7pH75 yGR/5oqwMRPubInQwSwoXWjaUq9zkt+ntDodUgSlMkdQToGJm X-Received: by 2002:adf:ea8d:0:b0:37c:ddab:a626 with SMTP id ffacd0b85a97d-380610e69f9mr5761658f8f.7.1730109707138; Mon, 28 Oct 2024 03:01:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUfxZ5J/+qT2nz5kV2yNoFg/rnDTb82YgSvcwHZIV18zrz7N5pbZT0ecKJmO6IhF9errOLfg== X-Received: by 2002:adf:ea8d:0:b0:37c:ddab:a626 with SMTP id ffacd0b85a97d-380610e69f9mr5761629f8f.7.1730109706739; Mon, 28 Oct 2024 03:01:46 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b13246sm9034827f8f.11.2024.10.28.03.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 03:01:46 -0700 (PDT) Message-ID: <839d4c08-c3a9-4163-b74e-06d309d7d9dc@redhat.com> Date: Mon, 28 Oct 2024 11:01:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: use aligned address in copy_user_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <20241026054307.3896926-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241026054307.3896926-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A0DCEA002F X-Stat-Signature: 91bg8nb35dp7ras36pkp8yisfkt3mcti X-HE-Tag: 1730109693-431960 X-HE-Meta: U2FsdGVkX1+mxw2GBXgE/WRWv+CScJHeYbt2eml5whswoRBRetGAyUoQxdOqy+7TME5vVCu5dVWm0F204lQHnO6vO/XvPqdhMZDoif3KJDExkiPpjbPGXJAa+1Yihn9XnddOynITgl6wKmE452CsblpGkO0SyyqEYbTOed/ovQOr1utD+RHKfKOkgJ9Fx+FxwzCpH5zQhKITBOWqZR4Tv5jW6NKOtJ0X8TN2WcjHmyu94Bf1NV3CHOFreXttJ6myR/BJhejatiHvZRdQ/sGT7Z26Ol9uEhd0BNqmTkfx5cTHTLTGmgPXIqSknu1f32HzVyPo36r/DA4vhORX3+B6VvFPiEWOWgCH6FfDrLOqZIvrwBs7VzvbU8E/y/EIVSafb1/+N2xIpwPg4wxEw03I8DClFSkVLdlW08k92Xp4AyvzBSmCEqqByk7v89Bh+N5oPX1cVFWGF95gTpSGcVBPKWDp5oKDxb9ZvZn9EcGGh5wpoBK+zAMa4u1pUbqxaywxtDmCoGiqOFY9+nj89JmfpXuIX963MkFWPztstfUuFMKzxYBU6vt4qYzyqpo/7hDn4zk36C0KqR73Lo1RlT7RS5mY55F1B+4Se0vMgvhfAuyp9D4iMgwCxq8QU/hyqmulPA8M42crLqVte6EIIYi2roGG0U3qnNG/2nFh6rCnKmn5cciUm+AbtOIIO5jdvoWxwe75hpw+Z5omxD4jEaH5RpurNDTbIncpnPWpKhagEJamOm9Suon0NP8midZ1QJkI3pELRHzuKfybKV/GBbeIxwQv39JpJstI57CnSVVAUVOkL3f5CqhkkH8SeaG3JWTQIAJAu36VmReJYPpIm4JWGnJWE+zg22h8Ntqv1sXO1k2ODXrPjcRxOzviHj4Y6UtwkvS5SvZ9tV4uDgGnlvBrWKcW6UTvHj0JxoRbGMrWFkLgf9ODfk/bsLZcqdwFzxH7L497q24kaliL9yeMZmt OFZw5a+K QshCAjIl3ipQ8fa1A+j3fttQ1cNn3+IO+94ssMz5gfvSAFeGIH10GX/5kYH7vT4VFNozXabZe+syecA1+UuUX+/JZPsnn8jB3aYI22It+w8BWkf0ccG6V4taI6IhuX2jyy9lH6liHWqNfpNex6gUQ8gdP9u4pGMTIlsFpl6Z+utJ1aW1lagqZa34TwwS1KlQYV5vuEyX+m3FPZUN4p/TT8tCGf9+/OXWKtFYRSlUeBfwEo/0QHFqxISAXyI7bxP0THt2oLEI+8DB+8ikXAZLj630Q7AKDUl2PAD+YA4fpGsGd6InIXZp4aImZs3bGVQdjH4+jFKV8pywkp48ntD9ju1F8mWG3NYsrAwXHIOGjWO1aeYlnkilp/KplMTS5gRo0XLKyd7rMb8DV1X+Yjco2uBCK2dfSubFymERJtt5nLfnBtji6n1GZmvM2c6KxdNwuAQGSxwYqFmAOz3a1gLVd+JTGanyDl5K0q3t0O/nfqEnlvltAIpUKr1Qsu0oorRUG0HQZfJWJykIO+cWSu+GOoLUEJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.10.24 07:43, Kefeng Wang wrote: > When copying gigantic page, it copies page from the first page to the > last page, if directly passing addr_hint which maybe not the address > of the first page of folio, then some archs could flush the wrong cache > if it does use the addr_hint as a hint. For non-gigantic page, it > calculates the base address inside, even passed the wrong addr_hint, it > only has performance impact as the process_huge_page() wants to process > target page last to keep its cache lines hot), no functional impact. > > Let's pass the real accessed address to copy_user_large_folio() and use > the aligned address in copy_user_gigantic_page() to fix it. > > Fixes: 530dd9926dc1 ("mm: memory: improve copy_user_large_folio()") > Signed-off-by: Kefeng Wang > --- > v2: > - update changelog to clarify the impact, per Andrew > > mm/hugetlb.c | 5 ++--- > mm/memory.c | 1 + > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 2c8c5da0f5d3..15b5d46d49d2 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5338,7 +5338,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, > break; > } > ret = copy_user_large_folio(new_folio, pte_folio, > - ALIGN_DOWN(addr, sz), dst_vma); > + addr, dst_vma); > folio_put(pte_folio); > if (ret) { > folio_put(new_folio); > @@ -6641,8 +6641,7 @@ int hugetlb_mfill_atomic_pte(pte_t *dst_pte, > *foliop = NULL; > goto out; > } > - ret = copy_user_large_folio(folio, *foliop, > - ALIGN_DOWN(dst_addr, size), dst_vma); > + ret = copy_user_large_folio(folio, *foliop, dst_addr, dst_vma); > folio_put(*foliop); > *foliop = NULL; > if (ret) { > diff --git a/mm/memory.c b/mm/memory.c > index ef47b7ea5ddd..e5284bab659d 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6860,6 +6860,7 @@ static int copy_user_gigantic_page(struct folio *dst, struct folio *src, > struct page *dst_page; > struct page *src_page; > > + addr = ALIGN_DOWN(addr, folio_size(dst)); Same thing, please make it clearer that there is an "addr_hint" and an "addr". -- Cheers, David / dhildenb