From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268AFE7719A for ; Sat, 11 Jan 2025 20:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8262C6B0088; Sat, 11 Jan 2025 15:12:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6096B0089; Sat, 11 Jan 2025 15:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 650796B008C; Sat, 11 Jan 2025 15:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 45A036B0088 for ; Sat, 11 Jan 2025 15:12:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F374CC150E for ; Sat, 11 Jan 2025 20:12:17 +0000 (UTC) X-FDA: 82996267956.10.D3479C7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 5B37FC0006 for ; Sat, 11 Jan 2025 20:12:15 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZAG5kyHg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G78zZQ1J; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZAG5kyHg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G78zZQ1J; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736626336; a=rsa-sha256; cv=none; b=LgotJS+KT1dI4SF8nkm9VMQPbfqKleiOVPIxL4lEDTJRXUOS/EK0eLNhZFOGNOx1fin0aV bdwJb2hSRmUibOTbUubSKlbq0lQZn5WYa2VZ8OQ7q70FX7iXZemrm5KWIM4YVoyG2UulbG aLDqpnla5UfNVesFy0pnrOrNfZ8haFw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZAG5kyHg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G78zZQ1J; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZAG5kyHg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G78zZQ1J; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736626336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gumTng/OKY2csMOYFzctpewdvsxy7ETIncVuXdiqsHk=; b=W8ss1WLoHM2DbU8BXpVYCL3FMHSP0UpTGZYkFZGEUtiNsYL4rZ7wjby10iol9FJVYqsZNY 34bbxvUIaAnivNMx9QxkmoP8IgiQQvpqxPCZluxK5JKyoU8fmuo6AHGwATJ0P1gSirysLW euRNXnEUmMXlzl+ST6wolMBBbrwWU/U= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A6B0F21160; Sat, 11 Jan 2025 20:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736626333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gumTng/OKY2csMOYFzctpewdvsxy7ETIncVuXdiqsHk=; b=ZAG5kyHgDJTOaLR0EwtGjU3tf9jKgMFGj12w+ajEWTmHeVXTxILku8QJ8nq94mMDN4cvMY YPJAS6ylAIkqwiUDWWV6I4cRZRY1Dkf7tcrqKkZzb/iZfK/2kvCTqmihGDZvfImtMMT4Cz Cyh7sX34sArLrz31rP/m4vNc6W10gQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736626333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gumTng/OKY2csMOYFzctpewdvsxy7ETIncVuXdiqsHk=; b=G78zZQ1JmblPkNuo2dIIuPDkkIOD6P8pUmzLCA+E0ehbVWJPM+obk+cC/ANTtISrAQYI90 6gScu6+siCCSUDDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736626333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gumTng/OKY2csMOYFzctpewdvsxy7ETIncVuXdiqsHk=; b=ZAG5kyHgDJTOaLR0EwtGjU3tf9jKgMFGj12w+ajEWTmHeVXTxILku8QJ8nq94mMDN4cvMY YPJAS6ylAIkqwiUDWWV6I4cRZRY1Dkf7tcrqKkZzb/iZfK/2kvCTqmihGDZvfImtMMT4Cz Cyh7sX34sArLrz31rP/m4vNc6W10gQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736626333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gumTng/OKY2csMOYFzctpewdvsxy7ETIncVuXdiqsHk=; b=G78zZQ1JmblPkNuo2dIIuPDkkIOD6P8pUmzLCA+E0ehbVWJPM+obk+cC/ANTtISrAQYI90 6gScu6+siCCSUDDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E5C5139AB; Sat, 11 Jan 2025 20:12:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id URP+IZ3QgmcXMgAAD6G6ig (envelope-from ); Sat, 11 Jan 2025 20:12:13 +0000 Message-ID: <839258c6-58e3-48e9-9791-0f4ab3ec2fb3@suse.cz> Date: Sat, 11 Jan 2025 21:12:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: fix kernel-doc func param names Content-Language: en-US To: Randy Dunlap , linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton References: <20250111063257.910991-1-rdunlap@infradead.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250111063257.910991-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5B37FC0006 X-Stat-Signature: n3mytaek9tizfmyfhq45375x5upt5zgr X-HE-Tag: 1736626335-460788 X-HE-Meta: U2FsdGVkX18dUvwSfDHVw9v5HtlUdcp9ciqmwPdKJqiaFqRbTSeO2tD+7tL+dp81bJ+ojOFHdymP4PnUkLauH2M5UO38RHa63eOYK/zOMyU5fUjhmvypHP2Qq/j6R34jHJM9GPJdn57YQ0OVTFBnC1ABM1c5PRcU9Ktbbm9BL/JDosUAqn2zmzjQGhFEQhrLrSBA/0t0aC+pPE95Zq3JIiyscR0uSAEgEbYQGjC3nQUBAOPvJTH4Wvt0G1GV3uIN63gFikApc04HqdhbKO++d7+Jo7dxLVsSehzf1K6qSVqlBikuhJDb5UZNA2zgZHMdfsmzvYrIjsy3BRBC+IwULtynQYE9ar4Y8u7ml5GdkIFGqBS6AGFbZxODGXlwQ4lUhZd6xoxHKeIiYjHAF3dwS+cqL6RDcmcoscf8NIFPlwBPs3fbumOwUF70AgPDiJLZKIyx9K0ACz4rMOExKDJkR+lwTFDAekkI2/xvzwpkoRcm7tep/AIHhvU1w16AmAUTFniC5AGEhfBOUoh66lEOts8inXmNnAktjuTuHyRdJ+FZfIt5AveZNTgUJwiBUCS7llNB8F1XXzfYsFDrS38TJ4c4Poo15c/xuuVCglQT32AyD6L1loNUkNJuH3zL/R823LcuHXebqFv67MfCcV+EMu3RJ5XJ1EhLPCtKmM2SNGo6xQ2QTqsGRwXKPK7umkG3vPWkIIAUR2/JhKm8fz4G9apEozw5BOusWjpzoVm644VI71gyDrLZgqFiP1OHwsX/E4+y35aDX4vSiTgvb1XdqE1yFWRf3WbrLDertsec/9A6i14ZXyTeC9+sq/R0hw2bQBC3IcvAdL5mOfTD42hIkRVylEOKB9tV1y+dqu7qNhgPL6TLwm2wtwQrOGwcYUxoaUp/1ugbp6xZ7GfmUpdg9H6wzSYfpNB6Dg+cDfbvGMntFlBBT+ifvKc7i4HDUvzWeSn8s8ThKmGPlDRIDco Q43DsT6f ACt6FBQWji2slafoGMc9nAjdp3r1IM3v09PQv0SUIx/SQoI+U8Wb8nUKU22ML70UM46CBvfOzq6PLoFGhWcvJSBzmlIdTFBvQ1COoz8iLAldGD1lPmS1A0F3Vr1bMnKr1mvhTlDT7VFOGfJrnUrQyXLCyMqH6BJvgJdmvBOGnYrZbO0IBJiYT0nsMHptpWNVC29V6GDX7xn+XSoTd7mH17ET5+V1QxzhEioA9Uhdvo20NjJL4VNpcT91rWqUv3uCrhLn7a6hLh0ni23aCe80qRTzGzvi9+ND77PDv//+AEX30xnMRXKOOfvH+CwbW/mSpYShfhb13sUr25FplYwzIYLU2LPOWr68soGUuADn/lA6P95EHmyoam6PTeQ0RNmurSsqcD4xVXHJTwOLOxSriUza2Suo3Z7sTpY+3oKhGVzIBXPE8qm6lXIxbps7kGQYuRdTEHTUbL6cXYkuOKz2jAMvyBdcjZmrDE7NwJgj+atQOP6CbWp88BqATuNA2f6oXyFtD5TmRh4ILkOY9zCRpWhkhgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/11/25 07:32, Randy Dunlap wrote: > Use corrected function parameter names to eliminate kernel-doc > warnings: > > slab.h:142: warning: Function parameter or struct member 's' not described in 'slab_folio' > slab.h:142: warning: Excess function parameter 'slab' description in 'slab_folio' > slab.h:168: warning: Function parameter or struct member 's' not described in 'slab_page' > slab.h:168: warning: Excess function parameter 'slab' description in 'slab_page' I'm unable to get those warnings with "make htmldocs", what exactly do I need to run? > Signed-off-by: Randy Dunlap > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Vlastimil Babka Anyway the problem and fix seem obvious, so applied. Thanks! > --- > mm/slab.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux-next-20250108.orig/mm/slab.h > +++ linux-next-20250108/mm/slab.h > @@ -128,7 +128,7 @@ static_assert(IS_ALIGNED(offsetof(struct > > /** > * slab_folio - The folio allocated for a slab > - * @slab: The slab. > + * @s: The slab. > * > * Slabs are allocated as folios that contain the individual objects and are > * using some fields in the first struct page of the folio - those fields are > @@ -159,7 +159,7 @@ static_assert(IS_ALIGNED(offsetof(struct > > /** > * slab_page - The first struct page allocated for a slab > - * @slab: The slab. > + * @s: The slab. > * > * A convenience wrapper for converting slab to the first struct page of the > * underlying folio, to communicate with code not yet converted to folio or